Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 2 Jul 2022 09:26:10 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-gpio@vger.kernel.org,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        UNGLinuxDriver@microchip.com,
        Linus Walleij <linus.walleij@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Terry Bowman <terry.bowman@amd.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        katie.morris@in-advantage.com
Subject: Re: [PATCH v12 net-next 9/9] mfd: ocelot: add support for the
 vsc7512 chip via spi
Message-ID: <20220702162610.GB4028148@euler>
References: <20220701192609.3970317-1-colin.foster@in-advantage.com>
 <20220701192609.3970317-10-colin.foster@in-advantage.com>
 <20220701200241.388e1fd5@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220701200241.388e1fd5@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkJRc1IrdWJCTzVMU3JFb1V2emoyVVR3REg3dmIwU2VUNXdhd1hVNjB5Zkw4?=
 =?utf-8?B?SHpDN2pUcWJSOFRjZFpPWHQvdURJM3ZwYnlIMGVHWWwvRG05UnVZTE0vRHYv?=
 =?utf-8?B?dkViSE1vL0hBWHUvTWdnRncybll0dHZDSnU1U1Njd2lCN2s0TCt0MW0xTnJy?=
 =?utf-8?B?THFPcDFwalJmMVU2dlpOWUdzS25QMEhXVldnV014ak5DMlhUMFF5bDlMV3d0?=
 =?utf-8?B?aE1sYUU4Y21CZVhzVUpFQzBpYXZhaW1PcVdWdnBjNG5PdjJmd1pqWlJIYnlx?=
 =?utf-8?B?clRkMHVySzRFaWErT0FNMHo4S1RqT2pRRGg3VkIzZU5GZ3ZHMDArczNFTDJr?=
 =?utf-8?B?R3RnTUZFQXZiUE9OaTJVZk5hYkVob3o3TXMwSHNNaS9qN3JCUGdrZnBCVVNL?=
 =?utf-8?B?WDNmT2FkeE1hRytQWHd6YU5memJJbUpPT24xdThzVm1GYTQ4clRyRDVhTTlO?=
 =?utf-8?B?Nm5pY1BRWTZBd2RnZ2VBbFFBSGJZajRNZXpxWWNaZVVYSGxQTzlha1V3M1pN?=
 =?utf-8?B?eU1uOTQ4MzdCdVVHSitONEhtTkhJZHd2RkFlaEUydHUxTklWV05WSTZoU1Na?=
 =?utf-8?B?OHpxcWI0ZHZ6bXdCMGpzUWJZN3hWVWZZMG5DbllWSjJQazU3Mk0wMVVML0Y4?=
 =?utf-8?B?dFhyS3Blby9Gb21pbjhxWFpQR1F4c3M2Z2Zabis5M2d3MnMyajVpYzJqSWw4?=
 =?utf-8?B?amZhYlpIZGpEU2VEVHQ4MWtWa1ZCTjg0bitWSUlpem16NFZ5Z1lQWWtTV3BK?=
 =?utf-8?B?bGJGRGlPMzJPbVhrdkwxcVkvZldUNG1GTnYybExGQ2NPdHFZZ3Y3RVd3NWJT?=
 =?utf-8?B?bW5iWGFyUkNmUTZvaGI5M1hEUFppVmpwbVV0a0VtdEVFVHpSM1hWTlliTW9W?=
 =?utf-8?B?QjFST1V6RFpDOUVKU1NzdkhoWkNzZDlnNjRIRVMwRk1RamFEUUpOcXNpazZQ?=
 =?utf-8?B?WnFuVnZIdDlpLzlrYzV1Y25Va0xPRlZ0U1drOHlrOVc3ajNqYXdGdlI5c0Nj?=
 =?utf-8?B?ZDFUeDc4Y1hCaXhlZENMTHRJTHFJSFliTUR6cXJMVDlzUnRnYzhPdjlHNlQ4?=
 =?utf-8?B?Tm9XbU9tL1VBN0JTeUM3OGpFQVlUaTFVN0xNcjZaQ1dMZE94L1BKY2FITWwx?=
 =?utf-8?B?MldSSjZWd1VpelNQVnhWdEppaCtxaGcvWWFSbDRoS1BpUEZjc2ZHWnVaYXU2?=
 =?utf-8?B?M3MxYm1EYnhKSTV3ZGpPTUhNU3Q3LzNiQ2ZWb2ZETVNydG1MS0ozZFU1RXBO?=
 =?utf-8?B?dXF5VVNnYVVmdkdWbm1USU5IYXdpckFMQnRUdmx5U09lQWJqbjdRd2gwZjlW?=
 =?utf-8?B?anFWWWtoWlFEUk51UDBsaFJJd0ZidUZnSi9CRWxYL3BRaXpHWXk2ZVZQNkJF?=
 =?utf-8?B?aVpHMUNCdTFMb2ZtQmpvYUszY2NpeWJLRlo5c05GZm93ZHB5SDhNU3h5RFQy?=
 =?utf-8?B?a0NwQXJJSkozM1FRQ085WHVpeTlaTEJvVWxpYlBZNkVENFAxL3pJZ3pLTTF1?=
 =?utf-8?B?MWFSNDRxa3lNNGxOR0JzSUpHOVhETnR5dk9rbG5pcXQxdEFxdlZNRG5ZWi8v?=
 =?utf-8?B?UUplaFU0a3RnK1FtaGswNUpBS2twKzZORHdGSFJyNFhxZWEwaHZyNGZlR0E2?=
 =?utf-8?B?QzB6VE81WkJaTDd4OGFTZ2cyVHRNanFlazFmQ2dmWTE1US9CMHI1TCtEMHdr?=
 =?utf-8?B?bTk4MXVRcnJjVW1JdGR5T1BVVzJ1WmhFUWhMT2xFMzJCSlZ1R3h2c1d5ckJK?=
 =?utf-8?B?bnkrcmJuNlZNOEl2MmRNUkRrTnNqbjBvcDk3Q2gxZXM1YkZOcFFKOWRFL1Z6?=
 =?utf-8?B?Uk1qWGNKTFVzT25NdEM5UU1wQmtwaVpWUG1IZ1FNS0YwWTRKdlNYcTlsNTFP?=
 =?utf-8?B?SlR5THEwYURrUUM0NmZueW0vUkRDaEhUL3Z5MFRQd3FQZ3BvV3hmdXZoTmlN?=
 =?utf-8?B?eWs2MFoybk5ZOEUwSUhuS2hiWGJPOEhFRUdCTml1MHhTeEdPNGx5WkkxKzBu?=
 =?utf-8?B?Nm5QeXZhVThGNEs1bmlYV1FsRVF1L0QrcWVwMzJ6c3RidzZBd1hIUzZWeHhZ?=
 =?utf-8?B?NDVRN0IzTlNXREwwUG1VTFZMeXJRZmUzTjkvUEpSREY5c0pSeWg2OEJlbEhE?=
 =?utf-8?B?L2hKa1p1T3lwWnhWTW5kL0ZpWmgzeDJDQ3lydlZBYzJPU0lQNjcyaHlJMTdn?=
 =?utf-8?Q?5xW9RxenMtJ59v9g3092w9I=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0945c1f2-81ae-4f16-d1fd-08da5c479459
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2022 16:26:12.9725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VdhFPPXscWKHZDCeSU+/zeXKWR8k+1tFR2seJuT4BY5BLgUsRkIyTKfGymCPN9J21xTB7QnVe7B5C4tv81rU9CEOL42zWjomdlK1KduedH0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3158
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 01, 2022 at 08:02:41PM -0700, Jakub Kicinski wrote:
> On Fri,  1 Jul 2022 12:26:09 -0700 Colin Foster wrote:
> > The VSC7512 is a networking chip that contains several peripherals. Many of
> > these peripherals are currently supported by the VSC7513 and VSC7514 chips,
> > but those run on an internal CPU. The VSC7512 lacks this CPU, and must be
> > controlled externally.
> > 
> > Utilize the existing drivers by referencing the chip as an MFD. Add support
> > for the two MDIO buses, the internal phys, pinctrl, and serial GPIO.
> 
> allmodconfig is not happy, I didn't spot that being mentioned as
> expected:
> 
> ERROR: modpost: "ocelot_spi_init_regmap" [drivers/mfd/ocelot-core.ko] undefined!
> WARNING: modpost: module ocelot-spi uses symbol ocelot_chip_reset from namespace MFD_OCELOT, but does not import it.
> WARNING: modpost: module ocelot-spi uses symbol ocelot_core_init from namespace MFD_OCELOT, but does not import it.
> make[2]: *** [../scripts/Makefile.modpost:128: modules-only.symvers] Error 1
> make[1]: *** [/home/nipa/net-next/Makefile:1757: modules] Error 2

Yikes. I'll button this up. I'm surprised that I need to import the
namespace of my own module... but I don't have a strong enough
understanding of what all is going on.

Also, allmodconfig never compiles for me, so I can't really test it:

make W=1 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- -j$(nproc)
...
arch/arm/vdso/vgettimeofday.c:10:5: error: no previous prototype for ‘__vdso_clock_gettime’ [-Werror=missing-prototypes]
   10 | int __vdso_clock_gettime(clockid_t clock,
      |     ^~~~~~~~~~~~~~~~~~~~
arch/arm/vdso/vgettimeofday.c:16:5: error: no previous prototype for ‘__vdso_clock_gettime64’ [-Werror=missing-prototypes]
   16 | int __vdso_clock_gettime64(clockid_t clock,
      |     ^~~~~~~~~~~~~~~~~~~~~~
arch/arm/vdso/vgettimeofday.c:22:5: error: no previous prototype for ‘__vdso_gettimeofday’ [-Werror=missing-prototypes]
   22 | int __vdso_gettimeofday(struct __kernel_old_timeval *tv,
      |     ^~~~~~~~~~~~~~~~~~~
arch/arm/vdso/vgettimeofday.c:28:5: error: no previous prototype for ‘__vdso_clock_getres’ [-Werror=missing-prototypes]
   28 | int __vdso_clock_getres(clockid_t clock_id,

I'll try it without cross-compile and see if I have better luck.