Received: by 2002:ac0:de83:0:0:0:0:0 with SMTP id b3csp379657imk; Sat, 2 Jul 2022 21:45:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uXdow9MNygNtOFgu6DbkJblWr8wzHIk5a5BgMyJ0xCeu5BbJnbEnpbw3AXkzUGcYvFwVrQ X-Received: by 2002:a17:90b:4c84:b0:1ed:5264:c4e6 with SMTP id my4-20020a17090b4c8400b001ed5264c4e6mr26883935pjb.230.1656823503990; Sat, 02 Jul 2022 21:45:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656823503; cv=none; d=google.com; s=arc-20160816; b=XO3xXyZYFwATIpTZbzDVkefkAbVMzRVIW16uYCpHKjqoNM7aSWnUyAieAJikXaCB3Q 4L9ODeA1HA2nAkoHbz5zwoXX1HPrnlmA7AhePIwoqqkQxHlrvNN9P225Cgjdpzc73mRC A/kQxvcrUBxokPEyhoWvEDNZSKpJUwzqzBQ2zhCb/fb0SrDzUBWuCsu2M8NU/qBUo1rv OEZ1rsYZydTzTT83ACApY0v8u76bZqkMK2tnVoXPd01HceTyOxr4h4ekbcQEuB6+w27h hz/W+6HEWgKGIzDJjTPiZxxmqONDoh6kc0bjW4fFGylIcJtmv62uKZh4M6FG2++3KUyI fHeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=nWUbM1QO+xcB9DJ8bgLAmaBbOykL1mmTX4oz4sv5DMU=; b=gmbIKJdvJ2UKXprShPDJM50VyfBM2/luT+GZqzg9TpF1zu9sxzILtD3WDlF63j4k1m NwD+2uG8x/BsRNPsCifNJkpF0ECrju0U7do+C0ijA/3uCpNUhfkel8QJql32ysJYaktT JkW1st8Umaf86jETUUH3++YZIGJKv1DCMRCOeaCbW74KnlIAIhWVbusQUC3V/oprmbc3 9ufAB5G2MzksM2Jdlox1hUK7e6bTtxnP7tIAyFHNMJ5tbJshdAyhtuEjvdV6+7QtnVU9 xmjQb+hhLystR54Ae6+6D4hJiP7bQKqICd2cmGy5+3S64R1MpcRfDv07zHXcdRk/NIk1 z0cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i5DSNyHZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t7-20020a17090ad14700b001eca73a8038si8723468pjw.114.2022.07.02.21.44.51; Sat, 02 Jul 2022 21:45:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i5DSNyHZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232458AbiGCD7p (ORCPT + 99 others); Sat, 2 Jul 2022 23:59:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232516AbiGCD6d (ORCPT ); Sat, 2 Jul 2022 23:58:33 -0400 Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1530DBF63 for ; Sat, 2 Jul 2022 20:57:40 -0700 (PDT) Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-10bd7fbc0ddso2841943fac.1 for ; Sat, 02 Jul 2022 20:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=nWUbM1QO+xcB9DJ8bgLAmaBbOykL1mmTX4oz4sv5DMU=; b=i5DSNyHZXPTWebDSN8WALRkLrbQ2w9ufTMW4wMGpaCjvY5jDk3vbHcYQsmP+dy6k7g ELS5plsRe2pYZUkM/U4h4pQOzIeuGP2K++NaArenbUDKmwUMQQlq20lhmdMAtKWHhzds vqOaupLzAHoJd9ULlRHhOJyBqW4KOfplvFIXk/bgl4wxmEjwxVtTajLDNbAvedbZelJQ jRZluosCe+3v691ZnCdq77oKiW7/S+U6OMHF42mz8rd9+DHvWVMeaYaOo4T6EU34D4bb dd080dLVA1xUoMoRO5/zMqbjr0ETcZKBHhiOnCwcAKuJ7XU6HtJ4Ztn4HutVqSjO1R4F 3gfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nWUbM1QO+xcB9DJ8bgLAmaBbOykL1mmTX4oz4sv5DMU=; b=cI5sZIcSRgnSP5i0egZ35BqgGF9Rg3jX5RecnQevS4338UmJlQ0ON83tDJwqcPgwGw cC03idh8kgcE4cYf/2nNnOFQ4q2qhEkYiYi4jAfq8RLqk1pI+lCgHk7U6+5EMpLbO/S+ hJLqZYcLHah+QJ9Vktcb7BduFpvuhiLoiWnBGXcf2bC5ftfW+i61w2EcWa6t203M8xat ZJPzRpn2ew28uhQHBKCvyKBW9M4zjFdHWyOVWvPlBPppuCnRrHrcQG2tiKpUi5Iyuay8 WYpZtIO7Wi0iMDSW8OnENxEnETt01ytaVUsATvqhCsVO7eORCX2PqJnuEqgUMrM91wvO EIeQ== X-Gm-Message-State: AJIora+3Qr0wzhp3cnGS1uO5BaPEJ5j+0zenCzRYEeAuzW9mJERyOj1e ShYZ5lb5tw7Eam6/hzScngpjVDh8xwiKfQ== X-Received: by 2002:a05:6870:1601:b0:108:2d92:5494 with SMTP id b1-20020a056870160100b001082d925494mr13866510oae.109.1656820659840; Sat, 02 Jul 2022 20:57:39 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 25-20020aca0f19000000b0032e5d0b5d5fsm12965910oip.58.2022.07.02.20.57.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 20:57:39 -0700 (PDT) From: Bjorn Andersson To: Thara Gopinath , Andy Gross , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Miaoqian Lin Subject: Re: [PATCH] soc: qcom: aoss: Fix refcount leak in qmp_cooling_devices_register Date: Sat, 2 Jul 2022 22:56:33 -0500 Message-Id: <165682055970.445910.6550423116947481475.b4-ty@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220606064252.42595-1-linmq006@gmail.com> References: <20220606064252.42595-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Jun 2022 10:42:52 +0400, Miaoqian Lin wrote: > Every iteration of for_each_available_child_of_node() decrements > the reference count of the previous node. > When breaking early from a for_each_available_child_of_node() loop, > we need to explicitly call of_node_put() on the child node. > Add missing of_node_put() to avoid refcount leak. > > > [...] Applied, thanks! [1/1] soc: qcom: aoss: Fix refcount leak in qmp_cooling_devices_register commit: e6e0951414a314e7db3e9e24fd924b3e15515288 Best regards, -- Bjorn Andersson