Received: by 2002:ac0:de83:0:0:0:0:0 with SMTP id b3csp610109imk; Sun, 3 Jul 2022 04:46:17 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s8dFy4g/y9WaSoj/YJ+lYMBJKxlKN9Jbo99t0IffzJAvAEDMrMOBEXMfco3EMaodNE2gE5 X-Received: by 2002:a17:906:6a03:b0:726:c0e5:d58a with SMTP id qw3-20020a1709066a0300b00726c0e5d58amr23416011ejc.288.1656848777107; Sun, 03 Jul 2022 04:46:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656848777; cv=none; d=google.com; s=arc-20160816; b=ADQ7GRz8bnyv9WpQvTCOkCyV/ei0rbbP9GAOOiYSQmqQOGmFdtL0RiTt9Jz7ODFFG5 0/7nV+PgOP7SnxGX3DtDAVdFQQkJQGL+fz8X1y9KiwqyBAjaiMuMffD2vqLntg4N0pAc P7kQSgMgZ/Un9b49x4zPKQ+DeDDXUaEk2uNHIBm/b1Oca6rcKFyDcEjIdGfMwuFbABCv ud1ZP2IRsBibXILcWqUsqFy3zIVHtyjt6gk68Vua1M7QO7Ee6D4LaPKkbm8F1WTJZ6d+ qo+Ia0YyV2GcIOtBYVLJT98jrmZx1YaU459faCEYhRZBVb9rv6DaocEVLlNqrfPi+E5i Gv1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rZqhPkJ0CR85z9ESubOl1xFBOlNGBxzn4hcF0bRK5rs=; b=qdlXXxHmHFFLYVn0s0+V130KvZaGZEfBl6eNE7OvAEsqUKMyVi7EEvnJBWUKK7mhfh X6QZdI8uhr3RVqOiDEFCzc0MacaBqufQeo86hTNCsHyw3D0vm9eAiTAuq8s2wwOLTzkH bT2gjG13CQ99aQUr7xQ/n4j4RztxbEoDIqgHYG3Z91Mj4hRjC7SytDJMEfjjCWkqn/jy 2taGP7D73AW5Tt2pWz+vugajAvAjQVpEd0rz5N7DKpwzmzphPiHHU9GvYcuDjOxQf0DR 9A5vlIL/39MSjjC5m7LjJ4arvcAMKMIBM1RZCK5N5zt/i50BVd+7coXwTYeLsJr16Lqo QcQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y4-20020a056402440400b0043564b8b9adsi7839688eda.160.2022.07.03.04.45.49; Sun, 03 Jul 2022 04:46:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232442AbiGCLLl (ORCPT + 99 others); Sun, 3 Jul 2022 07:11:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231169AbiGCLLj (ORCPT ); Sun, 3 Jul 2022 07:11:39 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E5BE9592 for ; Sun, 3 Jul 2022 04:11:37 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o7xVi-00047D-2z; Sun, 03 Jul 2022 13:11:30 +0200 From: Heiko Stuebner To: Daniel Vetter , Brian Norris , David Airlie Cc: Heiko Stuebner , Sean Paul , Sandy Huang , dri-devel@lists.freedesktop.org, Doug Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state() Date: Sun, 3 Jul 2022 13:11:26 +0200 Message-Id: <165684667535.1187961.4152536263848598.b4-ty@sntech.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220617172623.1.I62db228170b1559ada60b8d3e1637e1688424926@changeid> References: <20220617172623.1.I62db228170b1559ada60b8d3e1637e1688424926@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_HELO_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jun 2022 17:26:52 -0700, Brian Norris wrote: > It's possible for users to try to duplicate the CRTC state even when the > state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other > users of __drm_atomic_helper_crtc_duplicate_state()) already guard this > with a WARN_ON() instead of crashing, so let's do that here too. Applied, thanks! [1/1] drm/rockchip: vop: Don't crash for invalid duplicate_state() commit: 1449110b0dade8b638d2c17ab7c5b0ff696bfccb Best regards, -- Heiko Stuebner