Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 03 Jul 2022 10:54:45 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     sedat.dilek@gmail.com, Sedat Dilek <sedat.dilek@gmail.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        Namhyung Kim <namhyung@kernel.org>,
        Andres Freund <andres@anarazel.de>,
        Quentin Monnet <quentin@isovalent.com>
CC:     linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5Bperf-tools=5D_Build-error_in_too?= =?US-ASCII?Q?ls/perf/util/annotate=2Ec_with_LLVM-14?=
User-Agent: K-9 Mail for Android
In-Reply-To: <CA+icZUVpr8ZeOKCj4zMMqbFT013KJz2T1csvXg+VSkdvJH1Ubw@mail.gmail.com>
References: <CA+icZUVVXq0Mh8=QuopF0tMZyZ0Tn8AiKEZoA3jfP47Q8B=x2A@mail.gmail.com> <CA+icZUW3VrDC8J4MnNb1H3nGYQggBwY4zOoaJkzSsNj7xKDvyQ@mail.gmail.com> <CA+icZUVcCMCGEaxytyJd_-Ur-Ey_gWyXx=tApo-SVUqbX_bhUA@mail.gmail.com> <CA+icZUVpr8ZeOKCj4zMMqbFT013KJz2T1csvXg+VSkdvJH1Ubw@mail.gmail.com>
Message-ID: <1496A989-23D2-474D-B941-BA2D74761A7E@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On July 3, 2022 8:54:41 AM GMT-03:00, Sedat Dilek <sedat=2Edilek@gmail=2Ec=
om> wrote:
>On Sun, Jul 3, 2022 at 1:06 PM Sedat Dilek <sedat=2Edilek@gmail=2Ecom> wr=
ote:
>>
>> On Sun, Jul 3, 2022 at 1:03 PM Sedat Dilek <sedat=2Edilek@gmail=2Ecom> =
wrote:
>> >
>> > On Sun, Jul 3, 2022 at 12:57 PM Sedat Dilek <sedat=2Edilek@gmail=2Eco=
m> wrote:
>> > [ =2E=2E=2E ]
>> > > util/annotate=2Ec:1766:33: error: too few arguments to function cal=
l,
>> > > expected 4, have 3
>> > >                              (fprintf_ftype) fprintf);
>> > >                                                     ^
>> > > /usr/include/dis-asm=2Eh:472:13: note: 'init_disassemble_info' decl=
ared here
>> > > extern void init_disassemble_info (struct disassemble_info *dinfo, =
void *stream,
>> > >            ^
>> > > 1 error generated=2E
>> > > make[4]: *** [/home/dileks/src/linux/git/tools/build/Makefile=2Ebui=
ld:97:
>> > > util/annotate=2Eo] Error 1
>> >
>> > This is with Debian's binutils(-dev) version 2=2E38=2E50=2E20220629-4=
=2E
>> >
>> > $ dpkg -S /usr/include/dis-asm=2Eh
>> > binutils-dev: /usr/include/dis-asm=2Eh
>> >
>>
>> [ /usr/include/dis-asm=2Eh ]
>>
>> 470 /* Method to initialize a disassemble_info struct=2E  This should b=
e
>> 471    called by all applications creating such a struct=2E  */
>> 472 extern void init_disassemble_info (struct disassemble_info *dinfo,
>> void *stream,
>> 473                                    fprintf_ftype fprintf_func,
>> 474                                    fprintf_styled_ftype
>> fprintf_styled_func);
>>
>
>[ CC Andres F=2E + bpf folks ]
>
>The patch-series from Andres Freund from [1] fixes the issue for me on
>Debian/unstable AMD64:
>
>[PATCH v1 0/3] tools: fix compilation failure caused by
>init_disassemble_info API changes
>[PATCH v1 1/3] tools build: add feature test for init_disassemble_info
>API changes
>[PATCH v1 2/3] tools: add dis-asm-compat=2Eh to centralize handling of
>version differences
>[PATCH v1 3/3] tools: Use tools/dis-asm-compat=2Eh to fix compilation
>errors with new binutils
>
>Compile-tested only (LLVM-14 x86-64)=2E
>
>link=3D"https://lore=2Ekernel=2Eorg/lkml/20220703044814=2E892617-1-andres=
@anarazel=2Ede/"
>b4 -d am $link
>
>Andres, you have some test-cases how you verified the built perf is OK?


That series should be split a bit further, so that the=20
new features test is in a separate patch, i=2Ee=2E I don't process bpftool=
 patches, but can process the feature test and the tools/perf part=2E

Thanks Sedat for drilling deeper, identifying Andres work as a cure, thank=
s to Andres for that patch kit!

- Arnaldo=20
>
>Thanks, Andres=2E
>
>-Sedat-
>
>[1] https://lore=2Ekernel=2Eorg/lkml/20220703044814=2E892617-1-andres@ana=
razel=2Ede/
>[2] https://lore=2Ekernel=2Eorg/lkml/CA+icZUVVXq0Mh8=3DQuopF0tMZyZ0Tn8AiK=
EZoA3jfP47Q8B=3Dx2A@mail=2Egmail=2Ecom/