Received: by 2002:ac0:de83:0:0:0:0:0 with SMTP id b3csp895994imk; Sun, 3 Jul 2022 11:32:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vz2nWPULTDQ3uwKOQz9qP3s3rgwbC7zwp0W0LsFYpLe5UAMJ0HxJiFu7HKGiudQpnBmoCi X-Received: by 2002:a17:902:e494:b0:16b:dd0e:e11e with SMTP id i20-20020a170902e49400b0016bdd0ee11emr4160223ple.7.1656873136214; Sun, 03 Jul 2022 11:32:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656873136; cv=none; d=google.com; s=arc-20160816; b=QHSOQdWvs1SXi78HymF+D9NHCx6o6/PIjLgnek6RxwZqDB4wHkMs31Bg208Y1oJlc/ u0PDj58wtkfJif1offr2cVeN/omAtywOBbLmBoqXc0TQMx/FsR/aZItyXjcqKhzPiKlE AkOgJgCS6Y8MX7jhR7UaNjbYPNVpRuroMfMgpvwzOMs01jJo6qO0RYASXBuAOOfc99GE oh4GsU9yttgZBqEf7mMO9m/DkJJjQtdT86RHqd9dvn4q5Lo6Ek+K4JudrDOeSooX48Vy aIPnlQHMGJCUDG2xJCyaYM6dlIDdjDor3SgBL4ke+PXvufztl1U57Y3H11ZEIwGNBxoG li6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lYiarM6ryCuSTp2tU29BbcCVirvvghP4xAIxJ7FKWQI=; b=w9oZcs8+mHoNtk081XfehmMoAMb0FdWvnaELwE3ntkHwUiUCHxxbop1SkXWR6M7bOw gjxNLlwQBRqWotJsbvNQmAAEoLm79fu6EvK2hRmHU3EKSrMV9lQ+7j4Sst2cHAN/IaPR yNsJzy5+C1XShhVIQ6QFhopEwgMIWQTl6nEkMp4aD86NncJs2cDp+E0aEsE56+oV4v+s lfH7VA20Ab/ZhqZqfKGvooeU5c7lVj18fIDznOh8oX0zD6KKGnVNgHBcYcSZzvFjobK6 wTz2LbYAcgd/3keF5NUSx8efCZvvEvPnGC5zGEAby1RZAB9i265MfhlikElFamlR5epM 4ApA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linexp-org.20210112.gappssmtp.com header.s=20210112 header.b=X1DjKI+m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s14-20020a170902ea0e00b0016bde475187si3082518plg.438.2022.07.03.11.32.04; Sun, 03 Jul 2022 11:32:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linexp-org.20210112.gappssmtp.com header.s=20210112 header.b=X1DjKI+m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232565AbiGCSbc (ORCPT + 99 others); Sun, 3 Jul 2022 14:31:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231909AbiGCSb3 (ORCPT ); Sun, 3 Jul 2022 14:31:29 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0E623886 for ; Sun, 3 Jul 2022 11:31:28 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id c131-20020a1c3589000000b003a19b2bce36so1123499wma.4 for ; Sun, 03 Jul 2022 11:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linexp-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lYiarM6ryCuSTp2tU29BbcCVirvvghP4xAIxJ7FKWQI=; b=X1DjKI+m1eU/WtbCOKdkKYpTrI92MOgpcrTaKGWVrqwoRuT7SV+0OAyxJE79WtEmq7 BUoYGsWeRJ3J95S53ewFuYGYF1N48wTly80F6st20feP7pDAIMXNkT/iOrTKu48IZbwH SG5Aa9RHuPG2PssE7gZgj7h0KScuYUMSyzSmAcBTXXIlF7jNXhLwr0WsrcK0EWKP2sTC 28fxD2dnvOv04h8MUzSUmzyCAUznzbpyNiL6zi3nsQ9l9zLRLoP6w1jx0wncKSHCFpy2 GG/MhL1sFRiz612ygQTmW52cmS2/VeCMbO/oo10qEJGRpRSwxlF0vWQbYmVqgHM7vN3Z PAjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lYiarM6ryCuSTp2tU29BbcCVirvvghP4xAIxJ7FKWQI=; b=3YFVqUbBPEPtHbh761LCqzFN4Ffa/jiKfrh9Km/3gl+UqKSyOIyoD+mgb7JV/Inxh8 xLsXfdXFZ4k68EonZ09XI5tEJcelJNkt1NWMplkge23h0rE1/DTuULM4P/YM0Q20Zifg 8Re2H8Da0JtEnc1o/44nAV+UuEW7fBKDgyxjDEz6ZxDLkagH1rsJErqS2OVN2WMbXCjE zT5vG3OTfId3BuJKqjsF5nmI5IiHff9BgKEqeHtAHRFMK9BIIUVtgytx5GjfgV8+2Q/X NdpWaiVED4ycXfi2sV2pJG+ucPdWE03B6NItPSom6Nz5ojif5CGuMpcHFBOfk/XUjk1e hl9g== X-Gm-Message-State: AJIora/qs22kAerSw+q7in/UkQZvMHtLIMVYM8yVFEU6I2cOlag1JkaV JFXqg9m7lxQ8CHANjmGchdOsHA== X-Received: by 2002:a05:600c:2207:b0:3a0:4659:a0b0 with SMTP id z7-20020a05600c220700b003a04659a0b0mr29806674wml.48.1656873087286; Sun, 03 Jul 2022 11:31:27 -0700 (PDT) Received: from localhost.localdomain (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id x10-20020a5d54ca000000b0021b85664636sm27504258wrv.16.2022.07.03.11.31.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Jul 2022 11:31:27 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@linaro.org, rafael@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@baylibre.com, abailon@baylibre.com, Amit Kucheria , Zhang Rui Subject: [PATCH v3 01/12] thermal/core: Remove duplicate information when an error occurs Date: Sun, 3 Jul 2022 20:30:48 +0200 Message-Id: <20220703183059.4133659-2-daniel.lezcano@linexp.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220703183059.4133659-1-daniel.lezcano@linexp.org> References: <20220703183059.4133659-1-daniel.lezcano@linexp.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pr_err already tells it is an error, it is pointless to add the 'Error:' string in the messages. Remove them. Cc: Alexandre Bailon Cc: Kevin Hilman Cc; Eduardo Valentin Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index cdc0552e8c42..e22e7d939c54 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -1198,23 +1198,23 @@ thermal_zone_device_register(const char *type, int trips, int mask, struct thermal_governor *governor; if (!type || strlen(type) == 0) { - pr_err("Error: No thermal zone type defined\n"); + pr_err("No thermal zone type defined\n"); return ERR_PTR(-EINVAL); } if (type && strlen(type) >= THERMAL_NAME_LENGTH) { - pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n", + pr_err("Thermal zone name (%s) too long, should be under %d chars\n", type, THERMAL_NAME_LENGTH); return ERR_PTR(-EINVAL); } if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) { - pr_err("Error: Incorrect number of thermal trips\n"); + pr_err("Incorrect number of thermal trips\n"); return ERR_PTR(-EINVAL); } if (!ops) { - pr_err("Error: Thermal zone device ops not defined\n"); + pr_err("Thermal zone device ops not defined\n"); return ERR_PTR(-EINVAL); } -- 2.25.1