Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 3 Jul 2022 21:18:46 +0200
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Kent Gustavsson <kent@minoris.se>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v2 04/10] iio: adc: mcp3911: add support for interrupts
Message-ID: <YsHrlmfxOkwzVvfO@gmail.com>
References: <20220625103853.2470346-1-marcus.folkesson@gmail.com>
 <20220625103853.2470346-4-marcus.folkesson@gmail.com>
 <20220625125652.2f988964@jic23-huawei>
 <20220625130637.223180f2@jic23-huawei>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="nkFejJuc99Xh3uiS"
Content-Disposition: inline
In-Reply-To: <20220625130637.223180f2@jic23-huawei>
Precedence: bulk


--nkFejJuc99Xh3uiS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 25, 2022 at 01:06:37PM +0100, Jonathan Cameron wrote:
>=20
> ...
>=20
> > >  static int mcp3911_probe(struct spi_device *spi)
> > >  {
> > >  	struct iio_dev *indio_dev;
> > > @@ -352,6 +382,15 @@ static int mcp3911_probe(struct spi_device *spi)
> > >  	if (ret)
> > >  		goto clk_disable;
> > > =20
> > > +	if (device_property_read_bool(&adc->spi->dev, "microchip,data-ready=
-hiz"))
> > > +		ret =3D mcp3911_update(adc, MCP3911_REG_STATUSCOM, MCP3911_STATUSC=
OM_DRHIZ,
> > > +				0, 2);
> > > +	else
> > > +		ret =3D mcp3911_update(adc, MCP3911_REG_STATUSCOM, MCP3911_STATUSC=
OM_DRHIZ,
> > > +				MCP3911_STATUSCOM_DRHIZ, 2);
> > > +	if (ret < 0)
> > > +		goto clk_disable;
> > > +
> > >  	indio_dev->name =3D spi_get_device_id(spi)->name;
> > >  	indio_dev->modes =3D INDIO_DIRECT_MODE | INDIO_BUFFER_TRIGGERED;
> > >  	indio_dev->info =3D &mcp3911_info;
> > > @@ -362,6 +401,32 @@ static int mcp3911_probe(struct spi_device *spi)
> > > =20
> > >  	mutex_init(&adc->lock);
> > > =20
> > > +	if (spi->irq > 0) {
> > > +		adc->trig =3D devm_iio_trigger_alloc(&spi->dev, "%s-dev%d",
> > > +				indio_dev->name,
> > > +				iio_device_id(indio_dev));
> > > +		if (!adc->trig)
> > > +			goto clk_disable; =20
> > You definitely want to use devm managed cleanup for these.
> >=20
> > There is a patch set that adds these as standard functions, but I haven=
't
> > yet seen it being picked up for this cycle (reviews have been slow comi=
ng).
> >=20
> > https://lore.kernel.org/all/20220520075737.758761-1-u.kleine-koenig@pen=
gutronix.de/
>=20
> Ah, elsewhere in my unread email was a thread that says it's in clk-next =
so
> will be in the next merge window.  I haven't confirmed, but looks like St=
ephen
> put up an immutable branch so I could pull it into the IIO togreg branch =
if you
> want to transition directly to that new code. @Stephen, would you be fine
> with me pulling your clk-devm-enable branch into IIO (with the fix which
> got posted earlier in the week presumably also going on that branch when
> you push out?)

Please do, thanks

>=20
> Thanks,
>=20
> Jonathan
>=20
>=20
>=20
> >=20
> > In meantime role your own with devm_add_action_or_reset()

Best regards,
Marcus Folkesson

--nkFejJuc99Xh3uiS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmLB65EACgkQiIBOb1ld
UjJCURAAlmAjxUJQVlUe+a6+y5i06nMoQcOicCOsxkIcXRqKsgwVkksbUNXX6cCF
Oe8mJ4pLud8SRxIPSlpRSkfHffgOpcMep0M7XfnvK0+b6naQH8tQF0LBnFwRd1rS
3o8HcG8k39RRCUzzfWO4lWFSVECC2VEZvNpIkcqy2CLGKLZc613kF6SzZnN3rZpO
Et69bTlQ0OyOyvpw0cDg0ENTJmP397EDxj5HjOXCsAMn/pF96YkmQ2FBZsjpyiYy
uQKvk/dzUpiLmbLYuE/vY0NMtb3RFkGGXITtOmVHraqKlgwbCfiGC5xflkSVJmkW
IhezmhzrkoUPIVqBsp/xndClbvunkwAde0sPklgYdXD/gJhUYBNq6Hcp4xTr+IUX
HLNb8Dc7VAofd00SedKzN5uTpxIsSXygrTE3Y0kcmUUvDMzs4Gjz1WAh2tCf5Z1F
x2/Mxjp+cIqd38knhZiaxfbIF1vKkmD5/M2NtcZnX2nnVCDb4RtPhN9uciPLaABn
yTox8uQucfAy9P6f/3fTjTj2ib/fv8p5mBzPHsHjQs7qBNZFRs3u6FwdckLJpRDX
x2dqQZeuiEfsd9LrpikZrF/WJOqwlX7WJu07ZRKa8Mj48y6OjM5Jg5lQNpej/hbe
xSadDlL+fhRAes43sTDiqUm/QLlJ+MHkmopCD0MUabtrRa2I07g=
=uWvi
-----END PGP SIGNATURE-----

--nkFejJuc99Xh3uiS--