Received: by 2002:ac0:de83:0:0:0:0:0 with SMTP id b3csp1065216imk; Sun, 3 Jul 2022 16:24:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u8n+v58Ye+iXpELtD61NEsoSUDlvHp4s4dMiCW+Mvramc5T/iD+KCa6UIqtKmzNd2/JjQQ X-Received: by 2002:a17:902:ef50:b0:16b:e2de:1c24 with SMTP id e16-20020a170902ef5000b0016be2de1c24mr2658613plx.99.1656890682001; Sun, 03 Jul 2022 16:24:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656890681; cv=none; d=google.com; s=arc-20160816; b=0VV04lpuMfyg/nnOO4AtoWSTyFAu3QpQKM3F6zJEidqYhaNnL+9WvHydsHg+l4gTkh S+kQCB6WOcwWgO20964QjFnW3O72CKOlT3BCblFoZWy2i9H1rg/S2iQ2ueUXPvlTATbB +UvxBjEr+MgsdjMmIkJI8ZwRP/jKks8ij0t56Z6KMl0e2j3KS2xO6/DYSb09cHW6FNoB vzM5K5hrvYdtZeGSf+6zNkY2hSvBwQ8V6mYGvPDaimqT5+85/nRksmj7HYdw9sBH1VN9 ANUpa+ANNS8l64mXNV3R7fe1Wbzfb/M356GsLdiUDiroB1mAZxIXL9kcuGgRrlnQsP+D kb5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=jM3TGPtxJkgmTFpBCG9ciqLYWyWJgBvv60WOzB8Av8A=; b=GVrCeR/UUBqXg6c2juAubCXfE7dIkT6K8x7z5IyMWV/1LRqUB4wQ2brPW5TCOglcVF qDhhs6haM3o7EYMf83NpvJ5giSr+Cqa+VIypv1RR3/06vhHYQS69N/wpF+kmPaekk0ff dqDEPjQmY1J6t6mySdAOKSgyJkD29Cfssl5AkY9LUnwyqD3ULcnA+1FJhuJZR1sogLjA EqtlfImpSl1LFDtkGfHhyVt1ICYfN95voElMmNvsD0OLpUcZ2S1nejftuLpAJhMNIrq7 NFFs+GnQ8BSX7Dm5pYKAsG9oY2Ux3+YmLKtWis4w6fXYIq4x16oH8YWCtHKdrD7AqbKQ qj5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=00wNNTZx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k4-20020a63ba04000000b0040c6435a3besi38863270pgf.309.2022.07.03.16.24.29; Sun, 03 Jul 2022 16:24:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=00wNNTZx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbiGCXO2 (ORCPT + 99 others); Sun, 3 Jul 2022 19:14:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiGCXO1 (ORCPT ); Sun, 3 Jul 2022 19:14:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99F455FBB for ; Sun, 3 Jul 2022 16:14:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4A8C9B8015B for ; Sun, 3 Jul 2022 23:14:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E006C341C6; Sun, 3 Jul 2022 23:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1656890063; bh=eraPqmwROOb16b2jw4w/lY5LSrsNKAf5gsz/yzIab8s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=00wNNTZxm5k38yElTqGTrmvzRw8kLFqJOvQNb0pINHpqZUz3XC1uBlfeDyPfed3pw J792ub8Tx5cnrQ2kh2UH9cLFNPndI8ZbNx4s3D0neHF7SVB9imOHoSOD7MdU4sNkk6 GrarUUdH0nG4C43R0bhMcRNp3CbR+F/XAp6TT1ds= Date: Sun, 3 Jul 2022 16:14:22 -0700 From: Andrew Morton To: Yang Shi Cc: vbabka@suse.cz, kirill.shutemov@linux.intel.com, willy@infradead.org, zokeefe@google.com, linmiaohe@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [mm-unstable v5 PATCH 0/7] Cleanup transhuge_xxx helpers Message-Id: <20220703161422.71e0c7316cca0442c682fcaf@linux-foundation.org> In-Reply-To: <20220616174840.1202070-1-shy828301@gmail.com> References: <20220616174840.1202070-1-shy828301@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jun 2022 10:48:33 -0700 Yang Shi wrote: > This series is the follow-up of the discussion about cleaning up transhuge_xxx > helpers at https://lore.kernel.org/linux-mm/627a71f8-e879-69a5-ceb3-fc8d29d2f7f1@suse.cz/. > > THP has a bunch of helpers that do VMA sanity check for different paths, they > do the similar checks for the most callsites and have a lot duplicate codes. > And it is confusing what helpers should be used at what conditions. > > This series reorganized and cleaned up the code so that we could consolidate > all the checks into hugepage_vma_check(). > > The transhuge_vma_enabled(), transparent_hugepage_active() and > __transparent_hugepage_enabled() are killed by this series. I plan to move this into mm-stable later this week, along with two fixups: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-thp-kill-transparent_hugepage_active-fix.patch https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-thp-kill-transparent_hugepage_active-fix-fix.patch