Received: by 2002:ac0:de83:0:0:0:0:0 with SMTP id b3csp1086244imk; Sun, 3 Jul 2022 17:00:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tgBGTBKLN9NYT6yxds2rDwq8Pbn6QTteclPldIWWr2wZqLlBBuG3iBJ2enN9X5zu/NDgcZ X-Received: by 2002:a63:6b49:0:b0:40e:64ef:1be7 with SMTP id g70-20020a636b49000000b0040e64ef1be7mr22787091pgc.552.1656892858155; Sun, 03 Jul 2022 17:00:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656892858; cv=none; d=google.com; s=arc-20160816; b=YmnzXNk1ePavJhEiw9S5wks7ScbbMbv1yEA1D5aL86IYJEQnlqY3JiGBDTVhnCRYfZ 0J3ohKpwR1HbMplFAsQaS37gE49GhanVTJI/jkF5yQDmaK6l0V8dnT5E3UOFwr20ynZ5 gUDLW02jlKFQJYR7dXoPc10vkEtljBYNfv14YHIZ8Wj7tyXg0xmyIl8kaEeFXAHN2b9M DKSr2p652+W+GO8XPIbpiVTTq4lX3+A9Q4VizHWPwCtHBXGkWBrCbI6rqCTECBGSCBf7 NVgBEtXlJOxjuxzFCoO7B1iuShTT5oEH6leqX4mPlOjLwb3pdS2nZra/xkiaMVhYpyBK 9cjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=ub39BLXTlwHSruSM7Mx3P3DEPX4rs6CL8UUP1zrrQZQ=; b=oVSm/WfOUEpKzlZI/z/ydpYyiKs/xM7UT0oIypKrq8x2MWEEFYYH1MLjxF4Ma7QXxZ /QSrd106mYEyTyyCSf6/8/59iQlqoz4tru28URQrMzZJr0NmFZp+ko40NoQphd/Gr9Wu EHLTYafY69KYK/qTIV9+zkuS9sVF5RFLqc5IMsbrs1r1CmpWNpLeG+lKMF3XBMqdtJap 0JFf0sYOkJNK1yGdwyrjI3GDsS/aZQE+jCYSXn8wkQowaU4oHJ843N49DO4i5DPRFRfe m3VmDRu3Th+kQAojsksQu84RrJuVK79WlM32Hb4gvouwYbSXELDbiVDvFD0eQAFFiLbZ 7MBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s64-20020a632c43000000b0041159a5892asi16977882pgs.614.2022.07.03.17.00.45; Sun, 03 Jul 2022 17:00:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232607AbiGCXSq (ORCPT + 99 others); Sun, 3 Jul 2022 19:18:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232571AbiGCXSo (ORCPT ); Sun, 3 Jul 2022 19:18:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8F415FE9; Sun, 3 Jul 2022 16:18:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 29366B80BEB; Sun, 3 Jul 2022 23:18:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1E4DC341C6; Sun, 3 Jul 2022 23:18:38 +0000 (UTC) Date: Sun, 3 Jul 2022 19:18:37 -0400 From: Steven Rostedt To: Christophe Leroy Cc: Aaron Tomlin , Luis Chamberlain , "cl@linux.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "void@manifault.com" , "atomlin@atomlin.com" , "allen.lkml@gmail.com" , "joe@perches.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" , "jason.wessel@windriver.com" , "pmladek@suse.com" , "daniel.thompson@linaro.org" , "hch@infradead.org" , Chuck Lever III Subject: Re: [PATCH v11 09/14] module: Move kallsyms support into a separate file Message-ID: <20220703191837.0157546d@gandalf.local.home> In-Reply-To: References: <20220310102413.3438665-1-atomlin@redhat.com> <20220310102413.3438665-10-atomlin@redhat.com> <20220628000526.11c57cd8@gandalf.local.home> <20220628081906.jln2ombfej5473xi@ava.usersys.com> <20220703083324.az24ou7nrngvp73v@ava.usersys.com> <20220703092305.1e5da4c2@rorschach.local.home> <20220703135708.kn535pdrqv24f7kn@ava.usersys.com> <20220703101344.59710a42@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 3 Jul 2022 17:58:15 +0000 Christophe Leroy wrote: > When I started submitting Kernel patches years ago, I was given those > guidelines: > - Always submit checkpatch clean patches. > - Try to never modify the same line of code twice in a series. > > Which implied to always fix codying Style while changing or moving code. Yeah, I figured as much. I'll go back and read the coding style and see if it mentions this. If not, it needs to be updated. The exception is when you move code. Code moving should never have any other changes to it, because it makes it much more difficult to know what changed. -- Steve