Received: by 2002:ac0:de83:0:0:0:0:0 with SMTP id b3csp1344198imk; Mon, 4 Jul 2022 00:46:40 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sqQbmSrTr4jTEHZ3rqv5Ly20PIay6ZVidU6fd4PlQAadIErikJXGJyolDfIpOf4T8jORwe X-Received: by 2002:a17:906:5512:b0:726:be2c:a2e5 with SMTP id r18-20020a170906551200b00726be2ca2e5mr27057384ejp.88.1656920800509; Mon, 04 Jul 2022 00:46:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656920800; cv=none; d=google.com; s=arc-20160816; b=VUByXGMtBMYzsn8QVp6W7fyVn3TXEiNlpNgHEtnERzsYCzcs1BG/x4+8PkX+vh5Zd1 3pcal2sQQcNbpMvx/Ru7S0wejoDU7VjYCWeRhN9QyEIsYqNfNIXiw1LExOh0GQLZ5EdT 8Eg3g8A7SjovlfOYJcGyyEkgS5TvcZ7CzzfSXh2loINZzqCrxlK+zTMrY2j2BXp7ZfG5 vcDmLOLYmHpDs9boomW8vHsTW4w3o6MJ913bdgK+GawW+N511mWk5fdsRGt9vAN+TmfA RNvaiNcq0TFFnWAI9Xid7/PSGsfQ0kGUDusRPYGM6bViv+mjXM7cyp7Ttylgboiudo6T lNHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=G1vd2EuZcVlPhRVzJ8gL9PvB6yn+NfR8tP8wvo3jMjU=; b=hdA44b+wz7Dcq6JguemrDP90P4IcsiWks54c/Ry62lwkSt5/AZmdNI+XpU1C9v3xMT 6dBEdrFvsNEWpL/jEtxOjEPEdz74DXyUJ/cfcxUs/dguCUd5SNX0PpY2+wDXhRmZzB87 xnvxMInYzyY/Yhax5jJa1Jmi62/5PCQ7hfRELJrOio0G439b68CAEBEAuEtrWDr+TBrP CkiZhMfrQRZtXaVdzUpt50zI0wdVqQqmz3j+BF7ALEIf54/jw/R+4WYtRuzyBXWu5sXw v16ArF2awjy1SNoEAVJclMpv9JGpk74UykJJ8uw6yAyTkZns4Zv8sqx/qY9ukT8Pit5B cIVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i19-20020a1709064fd300b007262adf73f3si14994138ejw.945.2022.07.04.00.46.15; Mon, 04 Jul 2022 00:46:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231544AbiGDHUL (ORCPT + 99 others); Mon, 4 Jul 2022 03:20:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbiGDHUK (ORCPT ); Mon, 4 Jul 2022 03:20:10 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 73F2C2ACD; Mon, 4 Jul 2022 00:20:09 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8ED0780C1; Mon, 4 Jul 2022 07:14:44 +0000 (UTC) Date: Mon, 4 Jul 2022 10:20:07 +0300 From: Tony Lindgren To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, aaro.koskinen@iki.fi, jmkrzyszt@gmail.com Subject: Re: [PATCH] ARM: omap1: call platform_device_put() in error case in omap1_dm_timer_init() Message-ID: References: <20220701094602.2365099-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701094602.2365099-1-yangyingliang@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yang Yingliang [220701 12:30]: > If platform_device_add() is not called or failed, it should call > platform_device_put() in error case. Thanks applying into omap-for-v5.20/omap1. Regards, Tony