Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <89f930df-5276-e3b1-7569-4c62ffdf135a@arm.com>
Date:   Mon, 4 Jul 2022 09:04:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v3 04/12] thermal/of: Move thermal_trip structure to
 thermal.h
Content-Language: en-US
To:     Daniel Lezcano <daniel.lezcano@linexp.org>,
        daniel.lezcano@linaro.org
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        khilman@baylibre.com, abailon@baylibre.com,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, rafael@kernel.org
References: <20220703183059.4133659-1-daniel.lezcano@linexp.org>
 <20220703183059.4133659-5-daniel.lezcano@linexp.org>
From:   Lukasz Luba <lukasz.luba@arm.com>
In-Reply-To: <20220703183059.4133659-5-daniel.lezcano@linexp.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/3/22 19:30, Daniel Lezcano wrote:
> The structure thermal_trip is now generic and will be usable by the
> different sensor drivers in place of their own structure.
> 
> Move its definition to thermal.h to make it accessible.
> 
> Cc: Alexandre Bailon <abailon@baylibre.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc; Eduardo Valentin <eduval@amazon.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org>
> ---
>   drivers/thermal/thermal_core.h | 12 ------------
>   include/linux/thermal.h        | 12 ++++++++++++
>   2 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
> index ff10cdda056c..60844e2d59bb 100644
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -68,18 +68,6 @@ static inline bool cdev_is_power_actor(struct thermal_cooling_device *cdev)
>   void thermal_cdev_update(struct thermal_cooling_device *);
>   void __thermal_cdev_update(struct thermal_cooling_device *cdev);
>   
> -/**
> - * struct thermal_trip - representation of a point in temperature domain
> - * @temperature: temperature value in miliCelsius
> - * @hysteresis: relative hysteresis in miliCelsius
> - * @type: trip point type
> - */
> -struct thermal_trip {
> -	int temperature;
> -	int hysteresis;
> -	enum thermal_trip_type type;
> -};
> -
>   int get_tz_trend(struct thermal_zone_device *tz, int trip);
>   
>   struct thermal_instance *
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 365733b428d8..6289b0bb1c97 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -80,6 +80,18 @@ struct thermal_zone_device_ops {
>   	void (*critical)(struct thermal_zone_device *);
>   };
>   
> +/**
> + * struct thermal_trip - representation of a point in temperature domain
> + * @temperature: temperature value in miliCelsius
> + * @hysteresis: relative hysteresis in miliCelsius
> + * @type: trip point type
> + */
> +struct thermal_trip {
> +	int temperature;
> +	int hysteresis;
> +	enum thermal_trip_type type;
> +};
> +
>   struct thermal_cooling_device_ops {
>   	int (*get_max_state) (struct thermal_cooling_device *, unsigned long *);
>   	int (*get_cur_state) (struct thermal_cooling_device *, unsigned long *);


Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>