Received: by 2002:ac0:de83:0:0:0:0:0 with SMTP id b3csp1376216imk; Mon, 4 Jul 2022 01:38:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1srxSPKX4k5WvIOoaxF8r4bjbL0w8gFFPUqrZmDvRIncmNgy/elZNF4Ab8FYkRgAwRDUFaW X-Received: by 2002:a05:6402:18:b0:435:9a79:9a40 with SMTP id d24-20020a056402001800b004359a799a40mr36397956edu.328.1656923909966; Mon, 04 Jul 2022 01:38:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656923909; cv=none; d=google.com; s=arc-20160816; b=Xw2nbbeMGu4ur5XUbeMwpHnO0ayJlTCEStSpIP9ZJgVNSCFMoth3POQah94Kr4l2vS wo1jjFaWcqPrbghkBdFx4A0yBG4xj6H2DsBtA8Ey19mw+3/qM3IVf8c7SL2kzj5pWu0/ 9HqvmzUPlamdJ1Jrr1pO4k+UFTg/8xU2g6ddyL7IBazeU6erWFQJLA0ZE92PVxLDZneF aWYVXKOlB2VdzNZfgJRHh2ZtPr4QQy/MjcPaV0iLbb5Td2hImsyYiN0FhGOmWIP1l7Fi tCcRDwQ9GO4A/Qd0dHtMlS8xwbxGIr1tUk6mq5F7uYoRTIgaanKTCbTrQ2Z4ydDiH+tl bcpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Xh0s1LpzcO7nydfkpZGpNseYKTnrZ+2Np/ZcfDCXpDc=; b=AlAmfhfUo3S1vWZHeI2bRd9x2iUNwwif8mAIkpkH0sLvIufoc35houvMDzr2X+CTvW /ehO2RPYCejLGmHTHlHfy5/cOj9rVEP/O1ho3IAYwFX+DbRvfQgLLkApr3CAQVSP/aLB NDOqdk7vGrkPFYwjC9x3Row4rNH9rFuCUybk3JjiMEhAxbPreVUCU9crAgLpe3cLakvs cljVkBO55RMRRBTRxqSdVKUx7ip+KUz9vkfZZDMBAQjjmFr8MA4QOyM/iqUXv6PxRXMd vAlzVzIA67Mx1mRs8Z47Y9Orn7w5XRjVHqLdzeLWJnNFxFuZ1kkx5VOehtcJdMPtK2aC 3qFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=GRRRgUtt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cr11-20020a170906d54b00b0072a9a683407si9414084ejc.118.2022.07.04.01.38.03; Mon, 04 Jul 2022 01:38:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=GRRRgUtt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233722AbiGDIN7 (ORCPT + 99 others); Mon, 4 Jul 2022 04:13:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233257AbiGDINf (ORCPT ); Mon, 4 Jul 2022 04:13:35 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F49ABE3F; Mon, 4 Jul 2022 01:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Xh0s1LpzcO7nydfkpZGpNseYKTnrZ+2Np/ZcfDCXpDc=; b=GRRRgUttFjPFbbfTAINrHCG6OO G3Ucab5+mdT7nPB0AuW6e16lKwr8uqFfCLD1pBhBi2XnR5OJs9KjIC0QdsEFFfzuXCBfQq2ia9qcc zfUxLnlTxNNrSOYXchj1Y416h76UnLVXcdFm2EZfEflJ8dDq0Fb6iWj2x6PLVujKUEPU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1o8HCK-009GCW-Ug; Mon, 04 Jul 2022 10:12:48 +0200 Date: Mon, 4 Jul 2022 10:12:48 +0200 From: Andrew Lunn To: Ahmad Fatoum Cc: Wei Fang , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, aisheng.dong@nxp.com, devicetree@vger.kernel.org, peng.fan@nxp.com, ping.bai@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, sudeep.holla@arm.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support Message-ID: References: <20220704101056.24821-1-wei.fang@nxp.com> <20220704101056.24821-3-wei.fang@nxp.com> <751e1ec6-2d34-44f6-a6c3-775df8a3cea2@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <751e1ec6-2d34-44f6-a6c3-775df8a3cea2@pengutronix.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>, > > + <&pcc4 IMX8ULP_CLK_ENET>, > > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>, > > + <&clock_ext_rmii>; > > + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref"; > > I think the default should be the other way round, assume MAC to provide reference > clock and allow override on board-level if PHY does it instead. I would make it the same as all the other instances of FEC in the IMX7, IMX6, IMX5, IMX4, Vybrid etc Andrew