Received: by 2002:ac0:de83:0:0:0:0:0 with SMTP id b3csp1391634imk; Mon, 4 Jul 2022 02:03:01 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v8pXtCkdvxYx112TLC5Jw7MWKy4VX+0XJAsIPsMvuodmYD5EKUbzw/iVaF9JJkz4k4dVRC X-Received: by 2002:a63:3dc3:0:b0:40c:9e0c:3587 with SMTP id k186-20020a633dc3000000b0040c9e0c3587mr24317008pga.468.1656925381589; Mon, 04 Jul 2022 02:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656925381; cv=none; d=google.com; s=arc-20160816; b=VfxiXBzs65l1eEmcEA2BLZMOMtryDAANkFSj4BeNBfZX7PSg6WOYKU+ytNupdcILwg PFpr59obngmEwS0DQJF80hVZOMU8FEkl6SrsV4odmN6h4qUfK28dczwkqS9zRIWE4CId 1jeeVOx+565p29M8wd6BtbdN4z1MaDlnMRAkIs6j8Mw0nLNgxD5EtItKmwckfYj5adOD V+/Nu5mSDOnowakMudEJBW6T84vniazHVYXs4zXjIW++0X4UE/SheMurYUHZuDRqa3wT DH8QYdAaKNhZr+Vmg/v+uRezUx56muHoV45vTxOa/zojqThwA1WtRjT10Nt1GfbqSEL4 dSHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=J2BxR/tYzT7Y40B83av/Kt3H4EieN+PKXbk78euHwNs=; b=OgprQrAYCcJBTVbtBCwHYWghIOxgtRuqwiZV6ZJACLA+x3ipPIG//IhmqixSCBbk6A b18Wkk2VLW8pSu9bLXhtDUfo6JEeicMM8yIlAfB23rutB2wONj01tH/s332dXKLpeV5R EXHQlZm7REzB8Q59I/C8XtBKPPuLJp6sRdI082W1LIeIRm8P/rbl+Y2Chqkke+D2rF1C PNfE+WHS9d6kyY3Nk8F5nml8JMzuzUDUKA+qHq/KnTbcVOh8Oa9ydMRVLrjRgjwj/ksh u+hqO8eynhMICpau4ylQF46XiiQycDE2mEscovrJlow4niDPpydYa9PxdqxtbAHB3Etl aTWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mu17-20020a17090b389100b001eeeb417990si27067542pjb.68.2022.07.04.02.02.47; Mon, 04 Jul 2022 02:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229961AbiGDI6U (ORCPT + 99 others); Mon, 4 Jul 2022 04:58:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233303AbiGDI6K (ORCPT ); Mon, 4 Jul 2022 04:58:10 -0400 Received: from out199-2.us.a.mail.aliyun.com (out199-2.us.a.mail.aliyun.com [47.90.199.2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 437ABBF43; Mon, 4 Jul 2022 01:58:08 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=mqaio@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VIJ0-Uh_1656925083; Received: from localhost(mailfrom:mqaio@linux.alibaba.com fp:SMTPD_---0VIJ0-Uh_1656925083) by smtp.aliyun-inc.com; Mon, 04 Jul 2022 16:58:04 +0800 From: Qiao Ma To: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, kuba@kernel.org, gustavoars@kernel.org, cai.huoqing@linux.dev, aviad.krawczyk@huawei.com, zhaochen6@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 3/3] net: hinic: fix bug that u64_stats_sync is not initialized Date: Mon, 4 Jul 2022 16:57:46 +0800 Message-Id: X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: <7e3115e81cd5cab71a4a79b8061062e9d25eb5af.1656921519.git.mqaio@linux.alibaba.com> In-Reply-To: References: X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In get_drv_queue_stats(), the local variable {txq|rxq}_stats should be initialized first before calling into hinic_{rxq|txq}_get_stats(), this patch fixes it. Fixes: edd384f682cc ("net-next/hinic: Add ethtool and stats") Signed-off-by: Qiao Ma --- drivers/net/ethernet/huawei/hinic/hinic_ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c index 93192f58ac88..75e9711bd2ba 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c @@ -1371,6 +1371,9 @@ static void get_drv_queue_stats(struct hinic_dev *nic_dev, u64 *data) u16 i = 0, j = 0, qid = 0; char *p; + u64_stats_init(&txq_stats.syncp); + u64_stats_init(&rxq_stats.syncp); + for (qid = 0; qid < nic_dev->num_qps; qid++) { if (!nic_dev->txqs) break; -- 1.8.3.1