Received: by 2002:ac0:de83:0:0:0:0:0 with SMTP id b3csp1425661imk; Mon, 4 Jul 2022 02:50:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tobSVnAiyLnJTVkNvzFNxbkVHDkAT75VxAiPgkrLlmnJH4E3wIv4ReUIC4K9TL/Sk/Hy6D X-Received: by 2002:a17:906:8501:b0:711:bf65:2a47 with SMTP id i1-20020a170906850100b00711bf652a47mr28205862ejx.150.1656928247179; Mon, 04 Jul 2022 02:50:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656928247; cv=none; d=google.com; s=arc-20160816; b=QXN4K0GxisQXafDw56k7QLYLSRkxtHtfiL2WeZkDKnNyfDfdq/xzqBquQFS1npGW8o Qp3EFeXeNTL9DwLK213kGlXIsaVkvxiQfHlNq/b2p83fzIHDxY2cCq/SaCLefFqA6W4d 5iQz3ncYVjS9l9qtS70IwE8bIJBzv8agyiRg+udh97zgTduXBRdt3U6f5D7tj1Y75BIA AWu/LcAV8P5VxrmNubJq1f3eYLh2JZ/BO0tZdNKfYJ8EVaWCmy0V/bSQ9Fb254HM5hn5 QtyQN3eBlhsEBQFJnShdlWCNBDIG4rvTcXOWbMziuBT3GcWZT/jPhLumz+Sc4+ao/KNO AV/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=okwJqVPfcP7H6g7jUGSBJP+7xMym/xGPtg4hVJTuA84=; b=qSLbuEM41tf0cPut0v86ZLXXcl8YmssKFKuGW1g/I4RzyBQ61WJ7262E6++xXBdKL1 W3dqNyfaN37hk6oHhUXOs8m2auzY9O94uQwRKVLgAsSjGZWy1ds4Zlx607e05cFDIWX3 9lioaT1i0GqjYzmXuPS3cdLPCPIr3ZpjeK8fxav2/xyxAnpu6EZFocwm4j7PygnChgRP A8Q4XBJQJDMzeDRUbUSBJyVQkUgrYfb31AyXRoP5GWheW38In/suKROmrmhWcXv/B2CN EvfXtitw2R5Rf8n9GMCE0vkSVcMPvYN6zOVxSJxIQRMTZW/u5xYXQ6IrBp49uOo0steD tiBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="CbC0is/h"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id he8-20020a1709073d8800b007262c304034si13916568ejc.759.2022.07.04.02.50.21; Mon, 04 Jul 2022 02:50:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="CbC0is/h"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233536AbiGDJFu (ORCPT + 99 others); Mon, 4 Jul 2022 05:05:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233386AbiGDJFs (ORCPT ); Mon, 4 Jul 2022 05:05:48 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4087AB7E7; Mon, 4 Jul 2022 02:05:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656925548; x=1688461548; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oYMxdXwMZ8CDTj0KC5ZtPFS2C/wMgn+PhtLPFA9iqdc=; b=CbC0is/hpJyrwmKTFx8z4bTW9x/FCOysyR3nSiaE4l3sexFLd23c3nZ9 X9O5fFS0N6LOo9G7PQI1AV1JdBqZF5TcpCmWudcFO1R/EMPOqSKX2LYmi i2MNWZiVfuVbSp1z08FW/hwLn/7vnvWZrQJ3sVvRNCfc8cTaBtvXh0W4G iZYfyCjsgYzBe+s9xrDYgQkWeMflSdh7R6b968s/AYaMgwJmUq/jbL/ms KA+BXPTuseZ552uszub+KGW48qOK4TAcYbtTuUO6iR7Tnm8h0fXPzZ2aG Nikd/NGt417AQADMTKDKib7Dcls/HoO583m/aDOR7JMEwzrM9QX2duG+i Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10397"; a="262871087" X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="262871087" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2022 02:05:48 -0700 X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="649491800" Received: from xingzhen-mobl.ccr.corp.intel.com (HELO [10.255.29.228]) ([10.255.29.228]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2022 02:05:45 -0700 Message-ID: <1d0e29b9-aa14-4cf5-9692-21244f7ddef5@linux.intel.com> Date: Mon, 4 Jul 2022 17:05:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 0/5] Add perf stat default events for hybrid machines Content-Language: en-US To: Namhyung Kim , Arnaldo Carvalho de Melo Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , alexander.shishkin@intel.com, Jiri Olsa , linux-kernel , linux-perf-users , Ian Rogers , Andi Kleen , Kan Liang References: <20220610025449.2089232-1-zhengjun.xing@linux.intel.com> From: Xing Zhengjun In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 6/15/2022 1:59 AM, Namhyung Kim wrote: > Hello, > > On Thu, Jun 9, 2022 at 7:55 PM wrote: >> >> From: Zhengjun Xing >> >> The patch series is to clean up the existing perf stat default and support >> the perf metrics Topdown for the p-core PMU in the perf stat default. The >> first 4 patches are the clean-up patch and fixing the "--detailed" issue. >> The last patch adds support for the perf metrics Topdown, the perf metrics >> Topdown support for e-core PMU will be implemented later separately. >> >> Kan Liang (4): >> perf stat: Revert "perf stat: Add default hybrid events" >> perf evsel: Add arch_evsel__hw_name() >> perf evlist: Always use arch_evlist__add_default_attrs() >> perf x86 evlist: Add default hybrid events for perf stat >> >> Zhengjun Xing (1): >> perf stat: Add topdown metrics in the default perf stat on the hybrid >> machine > > Acked-by: Namhyung Kim > Thanks Namhyung. Hi Arnaldo, Can this patch series go in? Thanks. > Thanks, > Namhyung > > >> >> tools/perf/arch/x86/util/evlist.c | 64 +++++++++++++++++++++++++----- >> tools/perf/arch/x86/util/evsel.c | 20 ++++++++++ >> tools/perf/arch/x86/util/topdown.c | 51 ++++++++++++++++++++++++ >> tools/perf/arch/x86/util/topdown.h | 1 + >> tools/perf/builtin-stat.c | 50 ++++------------------- >> tools/perf/util/evlist.c | 11 +++-- >> tools/perf/util/evlist.h | 9 ++++- >> tools/perf/util/evsel.c | 7 +++- >> tools/perf/util/evsel.h | 1 + >> tools/perf/util/stat-display.c | 2 +- >> tools/perf/util/topdown.c | 7 ++++ >> tools/perf/util/topdown.h | 3 +- >> 12 files changed, 166 insertions(+), 60 deletions(-) >> >> -- >> 2.25.1 >> -- Zhengjun Xing