Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Seunghui Lee" <sh043.lee@samsung.com>
To:     <alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
        <bvanassche@acm.org>, <jejb@linux.ibm.com>,
        <martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Cc:     <grant.jung@samsung.com>, <jt77.jang@samsung.com>,
        <dh0421.hwang@samsung.com>, <junwoo80.lee@samsung.com>,
        <jangsub.yi@samsung.com>, <cw9316.lee@samsung.com>,
        <sh8267.baek@samsung.com>, <wkon.kim@samsung.com>,
        <seunghwan.hyun@samsung.com>
In-Reply-To: <20220630044804.6080-1-sh043.lee@samsung.com>
Subject: RE: [PATCH] scsi: ufs: no sw reset after last linkstartup fail
Date:   Mon, 4 Jul 2022 20:11:25 +0900
Message-ID: <000001d88f96$ccd299d0$6677cd70$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQI5aYjeE/9Eh4/d2WnB5RXwuc7qWwHvC5v0rJzc7OA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20220630041602epcas1p3f3427b4ceac68f8325d3f89bc8635603@epcas1p3.samsung.com>
        <20220630044804.6080-1-sh043.lee@samsung.com>
Precedence: bulk

As we know, the ufs host controller is disabled and enabled in the ufshcd_h=
ba_enable(). So, host controller registers are clear after sw reset.

Once the host fails to link startup 3 times, all host's controller can be c=
lear due to executing last ufshcd_hba_enable()(s/w reset).
That's why we need to skip last sw reset to get valid host register values.

Before
(ufshcd_dme_link_startup() -> ufshcd_hba_enable() -> retries--) * 3 times.

After
(ufshcd_dme_link_startup() -> if retries is 0, break. ->  ufshcd_hba_enable=
() -> retries--) * 3 times.
In this case, ufshcd_print_host_state(), ufshcd_print_pwr_info(), ufshcd_pr=
int_evt_hist() are valid.

> -----Original Message-----
> From: Seunghui Lee <sh043.lee=40samsung.com>
> Sent: Thursday, June 30, 2022 1:48 PM
> To: alim.akhtar=40samsung.com; avri.altman=40wdc.com; bvanassche=40acm.or=
g;
> jejb=40linux.ibm.com; martin.petersen=40oracle.com; linux-scsi=40vger.ker=
nel.org;
> linux-kernel=40vger.kernel.org
> Cc: grant.jung=40samsung.com; jt77.jang=40samsung.com;
> dh0421.hwang=40samsung.com; junwoo80.lee=40samsung.com; jangsub.yi=40sams=
ung.com;
> cw9316.lee=40samsung.com; sh8267.baek=40samsung.com; wkon.kim=40samsung.c=
om;
> Seunghui Lee <sh043.lee=40samsung.com>
> Subject: =5BPATCH=5D scsi: ufs: no sw reset after last linkstartup fail
>=20
> Host driver resets the host(ufshcd_hba_enable) after last linkstartup
> command failed. All of the member or host dump after linkstartup fail are
> reset value because of sw reset.
>=20
> Signed-off-by: Junwoo Lee <junwoo80.lee=40samsung.com>
> Signed-off-by: Seunghui Lee <sh043.lee=40samsung.com>
> ---
>  drivers/ufs/core/ufshcd.c =7C 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
> 7c1d7bb9c579..2cdc14675443 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> =40=40 -4753,7 +4753,7 =40=40 static int ufshcd_link_startup(struct ufs_h=
ba *hba)
>  		 * but we can't be sure if the link is up until link startup
>  		 * succeeds. So reset the local Uni-Pro and try again.
>  		 */
> -		if (ret && ufshcd_hba_enable(hba)) =7B
> +		if (ret && retries && ufshcd_hba_enable(hba)) =7B
>  			ufshcd_update_evt_hist(hba,
>  					       UFS_EVT_LINK_STARTUP_FAIL,
>  					       (u32)ret);
> --
> 2.29.0