Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 4 Jul 2022 15:04:13 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     Martin Kaiser <lists@kaiser.cx>,
        Yang Li <yang.lee@linux.alibaba.com>,
        Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon
Message-ID: <20220704120412.GA16517@kadam>
References: <20220630090937.4983-1-yang.lee@linux.alibaba.com>
 <20220630115848.hkzavd67cwjubjq4@viti.kaiser.cx>
 <7d763251-c761-1260-b03a-cecf8f6f9738@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7d763251-c761-1260-b03a-cecf8f6f9738@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VrcsAEnOTc6ZkdWe6BfHbkcXKLI+TbcJOtY1Xf2IgB4I7AixWVe13JCq1pHE?=
 =?us-ascii?Q?NfCtPL3uQADRnlJ8LHs+ALu2ICuNeYJNuAL1Tp/BmrBu9EXACZ08sFPzJUT4?=
 =?us-ascii?Q?iDuJ87fY4Wvd7ChVcqaQTk7r5IySagq3iT1rI2J1WjAglWNmkf4iPQAHpMYG?=
 =?us-ascii?Q?gIv1T0IzwwLTEayhoJ+AEN6zqnI+JVuvmPOWGMWjhyND2uwFkJn8XFebnRQE?=
 =?us-ascii?Q?8LBdqBDYz4IFTKdG7OO6mCRAeyA7olT3xNcOn/+qOU+qj4oBXSrmmQJc4FP1?=
 =?us-ascii?Q?P6xVDBnVJm9KK0nXvWHbVdm8QdVpdZxUl1ZIk+6Ah7O0YXiESKIxqCtnVker?=
 =?us-ascii?Q?cLYx89qSwTyDVwQPgs4coMxO6pgz//WaMimjiDBJBCa578eDPrsKAAKGEWYC?=
 =?us-ascii?Q?r+B0hBKXzrlsdbHe+Gp8IAB1avSQ8L6W4qSdDGsJ2m+t2OZmc2b3bSMVS1DK?=
 =?us-ascii?Q?Kmq2JNQgYZAPIkYGy5IOZrZCwTG3puapThHeWMH8C5FpvDKoDr653JH6HBmb?=
 =?us-ascii?Q?U6GU1UVWxBBy4OtiE6TA6at6VqOKJzz6kYNgcyTszSJFONtHHQzP03hQ1U12?=
 =?us-ascii?Q?kLAQl+SOvLAyYvREIcvdxVKU2vi3Fk+X6JpHd6utnm+5GXgaOdUFFbHWQcxP?=
 =?us-ascii?Q?D0J5rOjqkHA8X9DultVqjIZCvi2Ss1k5p6613eYOjRU0NfWgHlzOGsCPYJ6r?=
 =?us-ascii?Q?IjBidNG7DHPs83GqSbC5XjCcuYFO3toq4k6URmf20R9zsiWKPv1fzWXWD2J7?=
 =?us-ascii?Q?U9urcpuXXZFEbHy2xSBOHoMGTguxRtN9IUYG4Pfr5a0VX1O0NrFZnqpjIv3v?=
 =?us-ascii?Q?/tfJsxKxTLs9+W3vivVGDV6NKrx40kj93w1Sui46veCaitVDleImDhPrnIoj?=
 =?us-ascii?Q?LdkorUVc5nV1/xripFftVyoyGeZOeWTVNWmghiR4LgIgtJFrjfzgbqLX38nI?=
 =?us-ascii?Q?DSN4MPnOqez1X4nWcf4sfuzFWdXRGTMGPzO8NEUH/TWUZ+9YA6tMPUcWYmbm?=
 =?us-ascii?Q?2V3T2fH+UQFZ50z3k1PE2br11fqZUJxAOxbot6o9Eb4pvLfr6rUVWt6Csm1f?=
 =?us-ascii?Q?GX/ptunPepjVCeZeLafVog4YkK3fTz/TQIBIqEw62/Ogz+98tfvm2iygqLQI?=
 =?us-ascii?Q?/n4oIPjlmA//0JlP2fhQe5MGSgQMoIVNH4hIbJDnH2BnaIwuSbNz/iIWdQt7?=
 =?us-ascii?Q?L7Y7EutjHmsMWeyiYjIrt+sy0Z/2v0DAsKcK6T4snT3jdW4MlVocLWt5EmI7?=
 =?us-ascii?Q?qGGOjW2jkosDJC86j8SHVyN8p4wsDyQh/RuNQ8ETB/MzLquTgOKgXOr3wtnz?=
 =?us-ascii?Q?xHPeskpx3rPhI4awdlge0Je/kdfE3QFTEI/3Sigsn/etln1uA24MxmPnQdq5?=
 =?us-ascii?Q?cGG7TfQv0A4TKJ+jW9svlf5bZZAYk/R4zV24c2lmOEVeZd843prd2BuwRGyx?=
 =?us-ascii?Q?o9o1/WSMcxSZi7cTUtTUrIYb78CT06LMubG58SoVmhWWkLT5M+HbnU3Vs76p?=
 =?us-ascii?Q?7MXVHJW7VcC/Y9mjLIc5DgvaHj71Yn9E0cBzMElJq1CHGyZqeTtMpdl3NxBp?=
 =?us-ascii?Q?FXRZaxojROUi2oTMmuCmCIazP5savkVrXBMUsHPJpkOUwUouDvPNsvJvP/Zl?=
 =?us-ascii?Q?MA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd4af83-b0fa-47c0-e51d-08da5db559d6
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 12:04:31.3596
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DKjn43dBD6DN48RE9nzOpxQLGnfhGoqqGq4bmNiVlajMMlbNB8kKSveYIw15tsQ1YQ1CxKIVwcYWAMWdHiykuTFNmBRSzLwTDEHexxlwKzY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4760
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-04_11:2022-06-28,2022-07-04 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 adultscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2207040052
X-Proofpoint-ORIG-GUID: aVPBa6AX0bdsSOFisvm3GXENrh-UFSjt
X-Proofpoint-GUID: aVPBa6AX0bdsSOFisvm3GXENrh-UFSjt
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 01, 2022 at 10:58:58PM +0300, Pavel Skripkin wrote:
> Hi Martin,
> 
> Martin Kaiser <lists@kaiser.cx> says:
> > Thus wrote Yang Li (yang.lee@linux.alibaba.com):
> > 
> > > Eliminate the following coccicheck warning:
> > > ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
> > 
> > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > > ---
> > >  drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > > diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > index b5f6d41464db..5b0f66573d94 100644
> > > --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
> > >  		break;
> > >  	default:
> > >  		return false;
> > > -	};
> > > +	}
> > 
> > >  	do {
> > >  		pwrcfgcmd = pwrseqcmd[aryidx];
> > > -- 
> > > 2.20.1.7.g153144c
> > 
> > Thanks for spotting this.
> > 
> > Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
> 
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> No need to backport code-style warning, so Fixes: is not needed here.
> 

The Fixes tag doesn't have to do with backporting...

I do think it should only be used for bugs.  So I would not have used it
here.  But other people do encourage it for style issues so I have given
up fighting about that.

regards,
dan carpenter