Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 04 Jul 2022 14:54:19 +0200
Message-ID: <87y1x9xclg.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        "Jonathan Corbet" <corbet@lwn.net>,
        "Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/12] docs: alsa: alsa-driver-api.rst: remove a kernel-doc file
In-Reply-To: <3cd6b93b36b32ad6ae160931aaa00b20688e241a.1656759989.git.mchehab@kernel.org>
References: <cover.1656759988.git.mchehab@kernel.org>
        <3cd6b93b36b32ad6ae160931aaa00b20688e241a.1656759989.git.mchehab@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 02 Jul 2022 13:07:42 +0200,
Mauro Carvalho Chehab wrote:
> 
> This file:
> 	sound/core/compress_offload.c
> 
> Doesn't define any docs, as everything is inside the header
> file. So, drop it, in order to remove a Sphinx warning.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Hmm, it looks rather like that some comments (at least for exported
functions) should be marked with kerneldoc markers instead.

I'm going to fix those comments.


thanks,

Takashi

> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/12] at: https://lore.kernel.org/all/cover.1656759988.git.mchehab@kernel.org/
> 
>  Documentation/sound/kernel-api/alsa-driver-api.rst | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/sound/kernel-api/alsa-driver-api.rst b/Documentation/sound/kernel-api/alsa-driver-api.rst
> index d24c64df7069..3cf8eb4ecaf4 100644
> --- a/Documentation/sound/kernel-api/alsa-driver-api.rst
> +++ b/Documentation/sound/kernel-api/alsa-driver-api.rst
> @@ -86,7 +86,6 @@ Compress Offload
>  
>  Compress Offload API
>  --------------------
> -.. kernel-doc:: sound/core/compress_offload.c
>  .. kernel-doc:: include/uapi/sound/compress_offload.h
>  .. kernel-doc:: include/uapi/sound/compress_params.h
>  .. kernel-doc:: include/sound/compress_driver.h
> -- 
> 2.36.1
>