Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7012090d-560c-a9ce-7852-0cc57d9c7edc@loongson.cn>
Date:   Mon, 4 Jul 2022 20:37:38 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] LoongArch: Clean useless vcsr in loongarch_fpu.
Content-Language: en-US
To:     Xi Ruoyao <xry111@xry111.site>, WANG Xuerui <kernel@xen0n.name>,
        Huacai Chen <chenhuacai@kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20220704061402.683762-1-huqi@loongson.cn>
 <1470d272-e148-c600-f759-a1e2dac776e1@xen0n.name>
 <7904571e-3ef4-5841-497d-6796c8c36c52@loongson.cn>
 <e187cda4edf0a3186e7caae8ed285e2564742f26.camel@xry111.site>
From:   Qi Hu <huqi@loongson.cn>
In-Reply-To: <e187cda4edf0a3186e7caae8ed285e2564742f26.camel@xry111.site>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/7/4 17:58, Xi Ruoyao wrote:
> On Mon, 2022-07-04 at 17:27 +0800, huqi wrote:
>
>>> The original code was written with future LSX/LASX support in mind;
>>> the code is dead currently, but expected to get utilized Soon (TM).
>>>
>>> So, I'd like to confirm if future LoongArch models would *not* feature
>>> LSX/LASX in its current form, and that the Loongson Corporation is not
>>> going to upstream LSX/LASX support, given you are apparently a
>>> Loongson employee with the first-hand information? We'd like to avoid
>>> code churn in general, so if the LSX/LASX support is to be eventually
>>> mainlined, removing them now would only lead to them being introduced
>>> later.
>> `vcsr` is removed because it has been removed in hardware. What's more,
>> it will not be used to support LSX/LASX in the future.
> It would be better to add this information into the commit message.  Is
> it already removed in 3A5000?  On my machine "movfcsr2gr $a0, $r16"
> produces SIGILL (but maybe it's because LSX is not enabled via the EUEN
> register).

Yes, adding this information to the commit message will be more 
reasonable. I will do it later.

It is true that 3A5000 has removed this register. $r16 to $r31 are 
reserved for LSX/LASX. So "movfcsr2gr $a0, $r16" will raise SXD/ASXD if 
LSX/LASX is not enabled, and kernel will raise SIGILL.