Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220704114430.625365-1-robimarko@gmail.com> <7cb6fd46-ac80-fbc5-67f7-920934bb801c@linaro.org>
In-Reply-To: <7cb6fd46-ac80-fbc5-67f7-920934bb801c@linaro.org>
From:   Robert Marko <robimarko@gmail.com>
Date:   Mon, 4 Jul 2022 14:34:17 +0200
Message-ID: <CAOX2RU5UeeAh0hzYjANd5w+Y4NfxWN0uVtbjQLGOcTzT7ZRkQA@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: ipq8074: add reset to SDHCI
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Rob Herring <robh+dt@kernel.org>,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Devicetree List <devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 4 Jul 2022 at 14:29, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 04/07/2022 13:44, Robert Marko wrote:
> > Add reset to SDHCI controller so it can be reset to avoid timeout issues
> > after software reset due to bootloader set configuration.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > ---
> >  arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> > index ddafc7de6c5f..d685ca1969a3 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> > @@ -482,6 +482,7 @@ sdhc_1: mmc@7824900 {
> >                                <&gcc GCC_SDCC1_APPS_CLK>,
> >                                <&xo>;
> >                       clock-names = "iface", "core", "xo";
> > +                     resets = <&gcc GCC_SDCC1_BCR>;
>
> I looked at the bindings and they do not allow reset property, so does
> it depend on anything?

Hi Krzysztof,
It seems like the driver changes [1] were merged at the same time as
when bindings
were being converted and nobody ever follow up with documenting the property.

I can document the property and send a v2 if that's OK?

Regards,
Robert

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/mmc/host/sdhci-msm.c?h=next-20220704&id=3e5a8e8494a8122fe4eb3f167662f406cab753b9

>
>
> Best regards,
> Krzysztof