Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4a57677268ac356a006ee35f73ceacdf49ae4221.camel@foss.st.com>
Subject: Re: [PATCH] genirq: Don't return error on missing optional
 irq_request_resources()
From:   Antonio Borneo <antonio.borneo@foss.st.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <linux-stm32@st-md-mailman.stormreply.com>
Date:   Mon, 4 Jul 2022 14:53:36 +0200
In-Reply-To: <20220512160544.13561-1-antonio.borneo@foss.st.com>
References: <20220512160544.13561-1-antonio.borneo@foss.st.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.2 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-05-12 at 18:05 +0200, Antonio Borneo wrote:
> Function irq_chip::irq_request_resources() is reported as optional
> in the declaration of struct irq_chip.
> If the parent irq_chip does not implement it, we should ignore it
> and return.
>=20
> Don't return error if the functions is missing.
>=20
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> ---
>=20
> As follow-up of discussion in
> https://lore.kernel.org/lkml/875ymd6xdu.wl-maz@kernel.org/
> here is a proposal for changing the returned value.
>=20
> A similar issue is present for the optional function
> irq_set_vcpu_affinity(), to be covered separately, if needed.

Gentle ping for this patch.
Does it match the expected behaviour for an optional function?

Thanks,
Antonio


>=20
> ---
> =C2=A0kernel/irq/chip.c | 3 ++-
> =C2=A01 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index 54af0deb239b..eb921485930f 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -1513,7 +1513,8 @@ int irq_chip_request_resources_parent(struct
> irq_data *data)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (data->chip->irq_reque=
st_resources)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0return data->chip->irq_request_resources(data);
> =C2=A0
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return -ENOSYS;
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* no error on missing optiona=
l
> irq_chip::irq_request_resources */
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0;
> =C2=A0}
> =C2=A0EXPORT_SYMBOL_GPL(irq_chip_request_resources_parent);
> =C2=A0
>=20
> base-commit: c5eb0a61238dd6faf37f58c9ce61c9980aaffd7a