Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 4 Jul 2022 15:14:31 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>,
        Linus Walleij <linus.walleij@linaro.org>,
        Tasanakorn Phaipool <tasanakorn@gmail.com>
Cc:     Sheng-Yuan Huang <syhuang3@nuvoton.com>,
        Kuan-Wei Ho <cwho@nuvoton.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2 0/1] add device driver for Nuvoton SIO gpio function
Message-ID: <20220704151431.31d2cbbb@md1za8fc.ad001.siemens.net>
In-Reply-To: <20220704130602.12307-1-henning.schild@siemens.com>
References: <20220704130602.12307-1-henning.schild@siemens.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EFFY/hifngb8riQsweO2gvrpqn9dROkawa1E+hzxWhIniEhOlRvLuTIgTxDe?=
 =?us-ascii?Q?SizsDyva8MFv6BtTzmaQSDw/+BOTsutr7zOt9pg+EG1UtdogNjD40H0Ox8OR?=
 =?us-ascii?Q?M02c8Uyc3MKl3aaM7fNEGCaWAajy/aG1g8S4W2Qm7LbfcxrK7+JIVAHj3Xid?=
 =?us-ascii?Q?xV9j742X9SnmpM/hJyDeK30WlartPulUKAbWh0cRgqZXlNspsAl49UKFQMsa?=
 =?us-ascii?Q?EFz7Q022IAe2GgE26cEhVSutkbYAkTW4pvn6CVGGaAE328cX59TvGBpZv/Lm?=
 =?us-ascii?Q?uzjTyv//e3kQmk+SHSsS7HS9WXTd1EXRluFcVlysj9/TjhX6cAiiSULGPjha?=
 =?us-ascii?Q?dQ3uBIrX01kssTLKM3xQdBEfcZrc7V4MeWMInBYAjj+9k0XzINGyzeUQTSn/?=
 =?us-ascii?Q?Zkoz+LK4vzdwNlxmUvFPq42SfpM3Py3vLYE+j4HEW5TjJcOsvYLUw10I6TOw?=
 =?us-ascii?Q?un8PPDvsFHNsHWWCm4DgpjGmjmBUYdXp5ZePSB4y9U9Bd07lJuFHegPU1iwF?=
 =?us-ascii?Q?k7HVUh6HpcvPEVsl+ZF00foXSd+cIdYvRxlrUC+Xp2V6PvWUzCuLRFmizxHE?=
 =?us-ascii?Q?UvxwEz71Wj4FXhEI10yPQs2xon81kiWm5uu8swH5kaG0LDhLQZzN4/afvhoP?=
 =?us-ascii?Q?vn9/LfDI9P4RKGRBKBrk91eJkE6xbprpyMq6p5wpMo+lKd3wxFFBVTC6N4TY?=
 =?us-ascii?Q?eTP5qWgEnbgD9y7Im6yDbXebUQ8aAL8pAdYzt8vDB2wC/lb24JvaOUkMgmRs?=
 =?us-ascii?Q?po+BbGUxAAVQxH5Mlpur9VhTAsvGar/OOhotFLxeGooi70xCtt+ruXZmEb/e?=
 =?us-ascii?Q?/ZWFwCkNC077Rhbs3Ma06dtIywmmfmns+qbd//J/v5gopEDpjrjbZS1eIp9P?=
 =?us-ascii?Q?anEp8NMX5TDb4qTqVFI2ilDpHOS0QcslET9ZxC/Ah8cdWhOTUMpueUK6w0iw?=
 =?us-ascii?Q?eiN9gJZuQYPHWQg3TwFKIlkrz4dbckKlq2n4cleRw6dSOAxkTIOnDkjAEyRu?=
 =?us-ascii?Q?cjp45XrupbeXGi3MOnPsaYMNmObUnoBWHnr1un4o984YiZoNDwFIL4CF/zXd?=
 =?us-ascii?Q?CQYmTO6msGCf8y4w7kAGI0PsmuxKMp5XRORAcaXApuPNwxisxcG3dt0SA/Be?=
 =?us-ascii?Q?Bzo3dVvg28u5ZoHZqhNgcloVDes7XoQkB3LN8jFrBCI6y/TKgUBc3jLZHMuh?=
 =?us-ascii?Q?zI1ogDBJcHW8oC6Y2NmtSsdnCx4VlemB71zdyqn7jvnvVL8bfiwAzXCeMuTb?=
 =?us-ascii?Q?Fjkz2dLMpXtRQWid5ONRRUZtEMQvGXOBpnoT0gjfZmPt0VWr2fh943sFSWDB?=
 =?us-ascii?Q?Ad6ogB4CXTYJGWqjESoZcYlbYDKfeW/5zEqi5jibZqmoYTLzo9WsHG/DKLpB?=
 =?us-ascii?Q?X4Hs9kcJi1Ze2Ftue/Q50GEp85AKrv6IpRO9dTbibxqUekxtpSIfr3irz2BZ?=
 =?us-ascii?Q?HDpFLXd02OhzaLyQCmlV4xNb7oNbMEr5v0pSVM2va4ofUGipr0Yrqv/2gq0F?=
 =?us-ascii?Q?f6qTebiUxF+H/WKA3Bf4arbG4VtTJQuB+jE7wZa595/qxWqrislvXZILtpfh?=
 =?us-ascii?Q?V0uuRC8ozB+sdgLQci2XNCcBVLbQiM35MIKilfuHuXxl+0d0sQFw4Jk8vvHz?=
 =?us-ascii?Q?Aw=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ecbeabf1-94d9-4409-a3bb-08da5dbf2339
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 13:14:33.8712
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BNJsp+EujTxM01xJ45w+5KRTzfGP8t06GZ7aXh6GNEfr+hJJ6/nvZ3Dr8Tsspmk7+WQUkNcHr9RR74Iwhi/61Sr20xkAAryNf+DdJSQsjas=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR10MB3384
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Mon, 4 Jul 2022 15:06:01 +0200
schrieb Henning Schild <henning.schild@siemens.com>:

> changes since v1:
>  - implement get_direction function
>  - style changes requested in review

I guess in terms of style there is more that could be done. Thanks Andy
for the suggestions so far. But i would also like to hear from the
subsystem maintainers what they think in general. Polishing this one to
look much different than similar drivers might in the end do more harm
than use.

regards,
Henning

> 
> This adds gpio support for several Super IO chips from Nuvoton. The
> driver was originally developed by Nuvoton and i am just contributing
> it on behalf, because other patches i will send later will require
> access to the gpios. The driver is valid on its own.
> 
> The driver supports several chips, of which i only managed to test one
> but did not want to drop the others.
> 
> I hope the original authors will help with the testing and addressing
> review feedback. The changes i did so far mainly are inspired by
> similar drivers and some just concern coding style. If more has to be
> done and the original authors do not jump in, we might start off with
> just that one chip i can test and add the others later on.
> 
> Henning Schild (1):
>   gpio: nct6116d: add new driver for several Nuvoton super io chips
> 
>  drivers/gpio/Kconfig         |   9 +
>  drivers/gpio/Makefile        |   1 +
>  drivers/gpio/gpio-nct6116d.c | 412
> +++++++++++++++++++++++++++++++++++ 3 files changed, 422 insertions(+)
>  create mode 100644 drivers/gpio/gpio-nct6116d.c
>