Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp126215imw; Mon, 4 Jul 2022 06:25:49 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vhqQvew3Wz4tqm/hJmpGp3x95sqyQWSl8Xw0+Y8+b8Xl3whyQ57Fz4s5RS5CSZ4axWuUpx X-Received: by 2002:a05:6402:5418:b0:435:5a48:daa9 with SMTP id ev24-20020a056402541800b004355a48daa9mr38979260edb.304.1656941148954; Mon, 04 Jul 2022 06:25:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656941148; cv=none; d=google.com; s=arc-20160816; b=JHn7XZl0Mfv9EtJKQMMx+Nhm7sD8jwphhPxtpZieD+yUgtjZLFM7t8ohDU97hsLsoE e1as2o7zvqZAi5pbhaRRronJMWJ7cHsH39ybWuqvM7hQgZ13Z68Wa1cpecM8roJ68/vy MXfUcW1IcdqAFk1HWddt+rdKnogHDEzLikdkxXiZIRUnJE2oZmAUnlIgYvaFa/kvzBkz T3ZJSvlGkWwbD6YZQf+BfBnFgeXA1qM0NyYCnzjGgovDdPi8nZxSHH8+yIjxAfu5AbPm sY1UlMo6Ci3VB26fhkDPpJ/+8lOMdtLiBfnRQctMzACweZeLsRCe5ksyaYomczuBjsC5 /ciA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=D8GOUKtfW6AtIGJu7aVSFH77HUkxWHeSSx+Nl1OlLlU=; b=jf6ZlvujHHrGXV5QEMwJtMPVURbvvOib8QeGOqTJQ36TFhm1OTgRZcFIWA1Z2T9OPx wospAF1AsXPLalWCcAObAkra+o6K52ekW10uGHyK+9YfvyMa7xNllWF4puyYPd28CSOE 5jII3u8r/5sjFwMne8vt80+PBqIqJMHOL4UXkOXLqe06koDn6EsN7zB4GYlKURD+LAmW 8QW63idfgTVAU7UzkhXBMTHZUhFvs+qK4OBsjk3G0G8AdK/29kZfNOdJOs1JnNyl686n pX5HmKnAYDeIO96J8wXnXNh0eacOVtq0KGAQsie+eWZIP4V6BEJw3ZWeh7Q/dVj4yrLc xvAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jr4-20020a170906a98400b00726fc3493e8si21999750ejb.854.2022.07.04.06.25.23; Mon, 04 Jul 2022 06:25:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233747AbiGDNFz (ORCPT + 99 others); Mon, 4 Jul 2022 09:05:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233370AbiGDNFy (ORCPT ); Mon, 4 Jul 2022 09:05:54 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71D4264C9; Mon, 4 Jul 2022 06:05:53 -0700 (PDT) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Lc5ZX6JgkzhZ4V; Mon, 4 Jul 2022 21:03:00 +0800 (CST) Received: from huawei.com (10.175.112.208) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 4 Jul 2022 21:05:23 +0800 From: Yuan Can To: CC: , , , , Subject: [PATCH -next] gpio: pxa: Add missing clk_disable_unprepare() in pxa_gpio_probe() Date: Mon, 4 Jul 2022 13:03:23 +0000 Message-ID: <20220704130323.104294-1-yuancan@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add clk_disable_unprepare() on error path in pxa_gpio_probe(). Reported-by: Hulk Robot Signed-off-by: Yuan Can --- drivers/gpio/gpio-pxa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index c7fbfa3ae43b..08963975dd1b 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -676,6 +676,7 @@ static int pxa_gpio_probe(struct platform_device *pdev) /* Initialize GPIO chips */ ret = pxa_init_gpio_chip(pchip, pxa_last_gpio + 1, gpio_reg_base); if (ret) { + clk_disable_unprepare(clk); clk_put(clk); return ret; } -- 2.17.1