Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5fa79e89-144c-7261-335a-8f509b182bba@linaro.org>
Date:   Mon, 4 Jul 2022 15:50:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v3 1/5] dt-bindings: interconnect: Update property for
 icc-rpm path tag
Content-Language: en-US
To:     Leo Yan <leo.yan@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Georgi Djakov <djakov@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>
References: <20220704093029.1126609-1-leo.yan@linaro.org>
 <20220704093029.1126609-2-leo.yan@linaro.org>
 <18f1ee4a-5787-40d7-2eb5-50a43298845d@linaro.org>
 <20220704130712.GD659023@leoy-ThinkPad-X240s>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220704130712.GD659023@leoy-ThinkPad-X240s>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04/07/2022 15:07, Leo Yan wrote:
> On Mon, Jul 04, 2022 at 02:47:13PM +0200, Krzysztof Kozlowski wrote:
>> On 04/07/2022 11:30, Leo Yan wrote:
>>> To support path tag in icc-rpm driver, the "#interconnect-cells"
>>> property is updated as enumerate values: 1 or 2.  Setting to 1 means
>>> it is compatible with old DT binding that interconnect path only
>>> contains node id; if set to 2 for "#interconnect-cells" property, then
>>> the second specifier is used as a tag (e.g. vote for which buckets).
>>>
>>> Signed-off-by: Leo Yan <leo.yan@linaro.org>
>>> ---
>>>  .../devicetree/bindings/interconnect/qcom,rpm.yaml         | 7 ++++++-
>>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
>>> index 8a676fef8c1d..cdfe419e7339 100644
>>> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
>>> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
>>> @@ -45,7 +45,12 @@ properties:
>>>        - qcom,sdm660-snoc
>>>  
>>>    '#interconnect-cells':
>>> -    const: 1
>>> +    description: |
>>> +      Number of interconnect specifier. Value: <1> is one cell in a
>>> +      interconnect specifier for the interconnect node id, <2> requires
>>> +      the interconnect node id and an extra path tag.
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>
>> Ah, too fast.  No ack. This ref is also pointless and not explained in
>> commit msg.
> 
> I referred other DT binding file for adding $ref to specify property
> type [1], so it's confused why it's pointless, anyway, I can drop $ref
> in next spin.
> 
> Thanks a lot for the review!

The "arm,prefetch-offset" is not a cells property.

Best regards,
Krzysztof