Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202207030630.6SZVkrWf-lkp@intel.com>
In-Reply-To: <202207030630.6SZVkrWf-lkp@intel.com>
From:   Vlad Dronov <vdronov@redhat.com>
Date:   Mon, 4 Jul 2022 16:35:34 +0200
Message-ID: <CAMusb+SaQOEw_deYyT-nB43Jvmy8W1Bd5gJrpcgvtMOTiEaoNg@mail.gmail.com>
Subject: Re: include/crypto/chacha.h:100: undefined reference to `chacha_crypt_arch'
To:     kernel test robot <lkp@intel.com>
Cc:     kbuild-all@lists.01.org, LKML <linux-kernel@vger.kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Harald Freudenberger <freude@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Sun, Jul 3, 2022 at 12:51 AM kernel test robot <lkp@intel.com> wrote:
> ...
> config: s390-buildonly-randconfig-r005-20220703 (https://download.01.org/=
0day-ci/archive/20220703/202207030630.6SZVkrWf-lkp@intel.com/config)
> ...
>    s390-linux-ld: lib/crypto/chacha20poly1305.o: in function `chacha_cryp=
t':
> >> include/crypto/chacha.h:100: undefined reference to `chacha_crypt_arch=
'
> >> s390-linux-ld: include/crypto/chacha.h:100: undefined reference to `ch=
acha_crypt_arch'
> ...
> Kconfig warnings: (for reference only)
>    WARNING: unmet direct dependencies detected for CRYPTO_LIB_CHACHA20POL=
Y1305
>    Depends on (CRYPTO_ARCH_HAVE_LIB_CHACHA || !CRYPTO_ARCH_HAVE_LIB_CHACH=
A && (CRYPTO_ARCH_HAVE_LIB_POLY1305 || !CRYPTO_ARCH_HAVE_LIB_POLY1305 && CR=
YPTO

Ok, this is either weird or I do not understand how the Kconfig system work=
s.

What I look at is CRYPTO_LIB_CHACHA20POLY1305 definition:

[ lib/crypto/Kconfig ]
config CRYPTO_LIB_CHACHA20POLY1305
    tristate "ChaCha20-Poly1305 AEAD support (8-byte nonce library version)=
"
    depends on CRYPTO_ARCH_HAVE_LIB_CHACHA || !CRYPTO_ARCH_HAVE_LIB_CHACHA
    depends on CRYPTO_ARCH_HAVE_LIB_POLY1305 || !CRYPTO_ARCH_HAVE_LIB_POLY1=
305
    depends on CRYPTO

and this test's random config (s390-buildonly-randconfig-r005-20220703):

$ grep -e CRYPTO_LIB_CHACHA20POLY1305 -e CRYPTO_ARCH_HAVE_LIB_CHACHA
-e CRYPTO_ARCH_HAVE_LIB_POLY1305 -e CRYPTO=3D config
CONFIG_CRYPTO=3Dy
CONFIG_CRYPTO_ARCH_HAVE_LIB_CHACHA=3Dm
CONFIG_CRYPTO_LIB_CHACHA20POLY1305=3Dy
// missing CRYPTO_ARCH_HAVE_LIB_POLY1305 implies =3Dn (I guess?)

I'm following the canonical "Kconfig Language" doc (
https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html )
which states:

> - dependencies: =E2=80=9Cdepends on=E2=80=9D <expr>
> This defines a dependency for this menu entry. If multiple dependencies a=
re defined, they are connected with =E2=80=98&&=E2=80=99.

and

>         '!' <expr>                           (6)
>         <expr> '&&' <expr>                   (7)
>         <expr> '||' <expr>                   (8)
>
> 6. Returns the result of (2-/expr/).
> 7. Returns the result of min(/expr/, /expr/).
> 8. Returns the result of max(/expr/, /expr/).
> An expression can have a value of =E2=80=98n=E2=80=99, =E2=80=98m=E2=80=
=99 or =E2=80=98y=E2=80=99 (or 0, 1, 2 respectively for calculations).

So calculating:

(CRYPTO_ARCH_HAVE_LIB_CHACHA || !CRYPTO_ARCH_HAVE_LIB_CHACHA) &&
(CRYPTO_ARCH_HAVE_LIB_POLY1305 || !CRYPTO_ARCH_HAVE_LIB_POLY1305) &&
CRYPTO

I find it equal to:

(m || !m) && (n || !n) && y  =3D>  m && y && y  =3D>  m

So CRYPTO_LIB_CHACHA20POLY1305 should be no higher than M, but it is
=3DY in a config file =3D> weird :\ (or me wrong somewhere).

WDYT?

Best regards,
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer