Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761380AbXE2SI0 (ORCPT ); Tue, 29 May 2007 14:08:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752220AbXE2SIS (ORCPT ); Tue, 29 May 2007 14:08:18 -0400 Received: from nic.NetDirect.CA ([216.16.235.2]:44997 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751912AbXE2SIR (ORCPT ); Tue, 29 May 2007 14:08:17 -0400 X-Originating-Ip: 72.143.65.211 Date: Tue, 29 May 2007 14:07:01 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Andrew Morton cc: Linux Kernel Mailing List , Alexander Viro Subject: Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t. In-Reply-To: <20070529110041.49bf57f1.akpm@linux-foundation.org> Message-ID: References: <20070529110041.49bf57f1.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-16.8, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, INIT_RECVD_OUR_AUTH -20.00, RCVD_IN_SORBS_DUL 20.00) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1953 Lines: 65 On Tue, 29 May 2007, Andrew Morton wrote: > On Tue, 29 May 2007 13:11:07 -0400 (EDT) > "Robert P. J. Day" wrote: > > > > > Delete the apparently unused array "int dummy[5]" from struct > > inodes_stat_t. > > > > Signed-off-by: Robert P. J. Day > > > > --- > > > > no idea what that array is for, but no one seems to care about it. > > removal compile-tested on x86 with "make allyesconfig" and nobody > > misses it (unless it's used for padding of some kind). > > > > > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index 7cf0c54..dec83dd 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -44,7 +44,6 @@ extern int get_max_files(void); > > struct inodes_stat_t { > > int nr_inodes; > > int nr_unused; > > - int dummy[5]; > > }; > > extern struct inodes_stat_t inodes_stat; > > > > kernel/sysctl.c: > > { > .ctl_name = FS_STATINODE, > .procname = "inode-state", > .data = &inodes_stat, > .maxlen = 7*sizeof(int), > .mode = 0444, > .proc_handler = &proc_dointvec, > }, > > akpm:/home/akpm> cat /proc/sys/fs/inode-state > 608039 178454 0 0 0 0 0 > > So it _is_ used: to present those five zeroes. I think this is for > back-compatibility with some cretaceous-era kernel. ah, gotcha. well, i'll leave this up to someone else to do anything with if they are so inclined. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/