Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp228884imw; Mon, 4 Jul 2022 08:11:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s8GdHeLSBO5tBBw5Ie1sHdHPiFBiTJ/BNO4sXLAOiK1ujLy7MNEqfQG2rc8ROWvyGutFTL X-Received: by 2002:a17:907:2d08:b0:726:35bd:b3c1 with SMTP id gs8-20020a1709072d0800b0072635bdb3c1mr28532184ejc.281.1656947462375; Mon, 04 Jul 2022 08:11:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656947462; cv=none; d=google.com; s=arc-20160816; b=ZzASJK/faC+eCEIO6aqLl5Vaskyq6wN2qwpWrMJF6d8JeBIPJJlli1d8XfsV1Wkn1e KEwQaCej6TrKng3+7FrkR1G8ibpp52J0ih/5Em7zi7aYMC1oog6HJH1Ui9qqr0EdHmEn yBNb3vKz/qIBxKL0WtSUyag7KswokWlgvSE32l0/J7rufAS6hWx7VgOPSQvJXDmNwFqm vJ7Lp53m3zqLMzNYufkGpsHk1qqrDsxMd+Nr5WEtje1NnzhUgenHQNpXXfoE+FuHuw8m BhfV6y2aoti950bQT+TTFO8jYarqD/HtIOXJ33iT3u/HZSqkGiY9E9Oe2/TQOnLZec3Y ruOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cbPVFg5HfSLExs8n8PnCNX+mcFJDkOgFSN/8HExwOpA=; b=jXtf5qi10mHyZmQcRbj4VXIoRwvWVSGiupeuvfMF4UeBJ5ywo3Ad4bjW+wZ/7a5rNT len+2mtvlGSNi8ZP+1PHgWCRvPiH6LaVkcWWyuR3/DDuZTrfsLOFdaSUZRfszZ+GQyZe LhTyiUrZAxkO/PMku7rnzE1V0w2TDnMHVvUlRMyd3uExFg12VdpPpEtXhzxWODatJ9WQ Gp8geg+UgbhMuMxuGjjBEqtC3/mLPwDLp8Zc1DaAO/K01QjVcDwsygmkLm6fCnIZ42FV m5/Q+RXzuNTZ19QFpvEKnLk8EsNAWFSabr8g/ZFouVKIj/4IOifYQDj6YFHn4NGqI5LC XEmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W6jiU6gT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k12-20020a17090666cc00b00718cd011cd9si15675960ejp.59.2022.07.04.08.10.37; Mon, 04 Jul 2022 08:11:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W6jiU6gT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231289AbiGDPC5 (ORCPT + 99 others); Mon, 4 Jul 2022 11:02:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231376AbiGDPCz (ORCPT ); Mon, 4 Jul 2022 11:02:55 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0303E6368 for ; Mon, 4 Jul 2022 08:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656946974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cbPVFg5HfSLExs8n8PnCNX+mcFJDkOgFSN/8HExwOpA=; b=W6jiU6gTMCXKcmBER4CK2Bd6NVm6+GG6ZsHmpbcVZDh7hlnw6X4xo7LwKZOfLCC/X6ABq7 h9MsVnlVUpGFAOLClk7z3qSISIJxRyuVrxXyQ/NcPGzDR4YWhbJnV1CZ+6ER96vlAk64q3 x7852aTUplUwzrT4PUHkATXbPvJ4fk4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-468-LaUrDOIwPeKNeOoav0URaQ-1; Mon, 04 Jul 2022 11:02:53 -0400 X-MC-Unique: LaUrDOIwPeKNeOoav0URaQ-1 Received: by mail-wm1-f70.google.com with SMTP id c187-20020a1c35c4000000b003a19b3b9e6cso2587526wma.5 for ; Mon, 04 Jul 2022 08:02:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cbPVFg5HfSLExs8n8PnCNX+mcFJDkOgFSN/8HExwOpA=; b=YJy+iYUU9mzQaeqKyPzGc6W/pyfaAn18diTpgXewRPw1l8uXtc+VQ7n7+7dFyQOIYu BZTbzV1uJOXAmVUIbb2PkShY7+uIGBSNNVHjh0y1LwyriqKu0NObWAzP7VTeuHpLzvPX RCETMk7zEiAJvwPeaABvM7TY5ElILxXPYLCcst9h1l3n3eMcVqGhchQhR46hZml7T2mb PnnhiRVjsVqr81vAfunhPgjTDeoDPEx6JO3knPho1YjUOjtEfqvl18T0E+tgTt/N95PH L13KUDIeXh7khU7lx7H948UnwqcTfbAuYaR2un4LnOzhnC8Je+OBET8PsWaXsNu4YfV6 rypw== X-Gm-Message-State: AJIora8E+W717b7O9XV/tBVJrTMku2KK10/JTllNjmNJRnLy1fJlLdlg oO0SK8WhXaWgzqXJ+GCZ/vzNaMSYwY7GAn+OVoHGOReq2V2Rf3xR6B3IwVGLiPxBQYAtQrklIgH IwrjWj5oCC7FpO2Yy3EAg7ng= X-Received: by 2002:adf:e702:0:b0:21d:6900:ea1c with SMTP id c2-20020adfe702000000b0021d6900ea1cmr6477178wrm.620.1656946971482; Mon, 04 Jul 2022 08:02:51 -0700 (PDT) X-Received: by 2002:adf:e702:0:b0:21d:6900:ea1c with SMTP id c2-20020adfe702000000b0021d6900ea1cmr6477151wrm.620.1656946971326; Mon, 04 Jul 2022 08:02:51 -0700 (PDT) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id 12-20020a05600c020c00b003a04b0bcb43sm19451631wmi.40.2022.07.04.08.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 08:02:50 -0700 (PDT) Date: Mon, 4 Jul 2022 16:02:49 +0100 From: Aaron Tomlin To: Luis Chamberlain Cc: Steven Rostedt , Christopher Lamenter , Petr Mladek , Miroslav Benes , Christophe Leroy , Andrew Morton , "linux-kernel@vger.kernel.org" , linux-modules@vger.kernel.org, atomlin@atomlin.com, ghalat@redhat.com, oleksandr@natalenko.name, neelx@redhat.com, daniel.thompson@linaro.org, Christoph Hellwig , Thomas Gleixner , linux-rt-users@vger.kernel.org Subject: Re: [PATCH] module: kallsyms: Ensure preemption in add_kallsyms() with PREEMPT_RT Message-ID: <20220704150249.rwxekvj7nlarja6b@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20220703123109.3770204-1-atomlin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2022-07-04 07:55 -0700, Luis Chamberlain wrote: > Aaron, thanks for the patch! Your commit log however reads like an > optimization but it's a fix that needs to go to Linus, as such, can you > update it to explain clearly *why* it's a fix. Hi Luis, Sure - will do. Kind regards, -- Aaron Tomlin