Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 4 Jul 2022 18:13:40 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Carlos Llamas <cmllamas@google.com>
Cc:     Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Christian Brauner <brauner@kernel.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Hridya Valsaraju <hridya@google.com>,
        Suren Baghdasaryan <surenb@google.com>,
        kernel-team@android.com, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] binder: fix redefinition of seq_file attributes
Message-ID: <YsMRtGg8xQ2Qicr2@kroah.com>
References: <20220701182041.2134313-1-cmllamas@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220701182041.2134313-1-cmllamas@google.com>
Precedence: bulk

On Fri, Jul 01, 2022 at 06:20:41PM +0000, Carlos Llamas wrote:
> +	binder_for_each_debugfs_entry(db_entry) {
> +		dentry = binderfs_create_file(binder_logs_root_dir,
> +					      db_entry->name,
> +					      db_entry->fops,
> +					      db_entry->data);
> +		if (IS_ERR(dentry)) {
> +			ret = PTR_ERR(dentry);
> +			goto out;
> +		}

I know this is a copy of what is there already, but there is never a
need to check the result of a debugfs_create_* call.  Just call it and
move on, never "abort" based on the result of a debugfs call, that's not
a good idea.

So can you change this here, or want to send a follow-on patch that
removes these checks?

>  	}
>  
>  	proc_log_dir = binderfs_create_dir(binder_logs_root_dir, "proc");

Also there's never a need to save a directory, you can always look it up
when you want to remove it.

thanks,

greg k-h