Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d803c02c-1a9c-59be-969a-5e4daae5f59c@infradead.org>
Date:   Mon, 4 Jul 2022 12:15:42 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v8 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring
 driver
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Georgi Djakov <djakov@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc:     Rajendra Nayak <quic_rjendra@quicinc.com>,
        Thara Gopinath <thara.gopinath@gmail.com>
References: <20220704121730.127925-1-krzysztof.kozlowski@linaro.org>
 <20220704121730.127925-3-krzysztof.kozlowski@linaro.org>
 <3770bc6d-b3cc-9e49-a832-4c15af0b5f1a@infradead.org>
 <9cd658cd-3b8c-89d1-651d-ce81794fb68c@linaro.org>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <9cd658cd-3b8c-89d1-651d-ce81794fb68c@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/4/22 08:22, Krzysztof Kozlowski wrote:
> On 04/07/2022 17:20, Randy Dunlap wrote:
>> Hi,
>>
>> On 7/4/22 05:17, Krzysztof Kozlowski wrote:
>>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>>> index e718b8735444..2c8091535bf7 100644
>>> --- a/drivers/soc/qcom/Kconfig
>>> +++ b/drivers/soc/qcom/Kconfig
>>> @@ -228,4 +228,19 @@ config QCOM_APR
>>>  	  application processor and QDSP6. APR is
>>>  	  used by audio driver to configure QDSP6
>>>  	  ASM, ADM and AFE modules.
>>> +
>>> +config QCOM_ICC_BWMON
>>> +	tristate "QCOM Interconnect Bandwidth Monitor driver"
>>> +	depends on ARCH_QCOM || COMPILE_TEST
>>> +	select PM_OPP
>>> +	help
>>> +	  Sets up driver monitoring bandwidth on various interconnects and
>>
>> 	  Sets up driver bandwidth monitoring
>>
>> would be better, I think.
> 
> It's a driver which monitors bandwidth, so your version sounds a bit
> like monitoring of driver's bandwidth.
> 
> Maybe should be:
>     Sets up driver which monitors bandwidth...
> ?

Yes, that's OK.
Thanks.

-- 
~Randy