Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <453e4f5e-fd04-5aa4-3e2f-f9296e11abab@intel.com>
Date:   Mon, 4 Jul 2022 21:16:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH] ACPICA: Use swap() instead of open coding it
Content-Language: en-US
To:     Tan Zhongjun <tanzhongjun@coolpad.com>, <robert.moore@intel.com>,
        <lenb@kernel.org>
CC:     <linux-acpi@vger.kernel.org>, <devel@acpica.org>,
        <linux-kernel@vger.kernel.org>
References: <20220704140614.39763-1-tanzhongjun@coolpad.com>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
In-Reply-To: <20220704140614.39763-1-tanzhongjun@coolpad.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGoyZDV1K1dWRVRXWmUwc3dkdXFYdThxd0dyVGNCWVp1RjF6SVF5d0NsU216?=
 =?utf-8?B?VE5uZVl2RWRnT2ozeHlqUXpWNEJ4YnJvZzdsb3Bhd3pJWFFmVWdmV0QxOWJU?=
 =?utf-8?B?R3I2U2d4KzRjVk1kTFhQUnErWnVYdG1CS1FEeDdSR3V1a0REOXJoaFMybC83?=
 =?utf-8?B?SERqalFLMjE4c2xiTDlCUTZ1OGp5N01QYXRRdnFZSFpOVnFnMUN4WjZZK1Jw?=
 =?utf-8?B?OHFYTzdLNFFhbXNPSzZSYzRvSWxzRkd5dVgrY25IUFo4c1VOT0x1OUFIRFNu?=
 =?utf-8?B?OU5RVnhLMUxXL0hSR0lnQnUwUVA2SUs3TThBL21zTk1kcHRQdzNMMFlacENI?=
 =?utf-8?B?cVBaLytEeWZTK0YwVTRtT1FsMFhsU0NmM08zbDhWL0h2MXVSVjc3a1ZjRXZ1?=
 =?utf-8?B?ZnV3aWdUcGdOVEpwZWRJWDY2MnZtRmNONDhGMkx0T3dkaTdteWVMbzZoYUdK?=
 =?utf-8?B?WUtOdUhBaHZhN2hHNXRQRzY5SnNEREd6YThNbkZLWm8yeDJtcmYyZ01GL3BW?=
 =?utf-8?B?UENhVGJrTTRycFkzUkRhc2JudHRsc0dHVDRZRVZ1U2I5bHB6SUVaNnF6VVRF?=
 =?utf-8?B?WGRyM0g0QUozL2VGcWpWOXFic0hOOEZ6TzUxa1RrRG5TbmUwUFFkK2Q5TDd1?=
 =?utf-8?B?MVZJalRKdy9RZi9rWEV3T2FuWlpSWUs1cUFIMGlPOHJPMlFSL1BuakppNDgy?=
 =?utf-8?B?T3dOM0FyZFpoNkdsZkhTK3EzTlFLY0taRnRaQXdxalBXNjB4aE90SlZOT2Z2?=
 =?utf-8?B?KytWcnFXVFZSUFlZOTYzSy8raEhseTBmT3FlanY2YVpuYlpxQ0Zwc2MvTytP?=
 =?utf-8?B?Q3N0YW44SjJHK0NkOWNFOXlxb2VrL01lZXJZYkhrVlJvZ3puQ0JKUjlTcVNW?=
 =?utf-8?B?Sy82ZzJxQ00rVEdRQkxyYUlUcWp1Uko1YTJNL0xYSkRSUWptanQwOXI0aFM5?=
 =?utf-8?B?VCttSi85M0V3OVdOczRGNmVFTFB5UXh0NWpXZ1NoZC90eDRjbisrZ3Bzc3J6?=
 =?utf-8?B?ek9NT09EcGIrQ2ROK1BSeUdOZFk3dVRiZGJoaDREbCtJcUxiZU1BOWh2RHAw?=
 =?utf-8?B?OHJxVnlNRWZLa0pTUlBxZTgvUWJwTmpmTHZSWFloVWFlaUQ2SGt6S0dnb1JQ?=
 =?utf-8?B?QUJNSllqMnlIRzZwODQxbFJiUldmUGlhTStnWlVuVUpGV01iZUFkK0RVTkxy?=
 =?utf-8?B?cHN2bnVBRlhGSHRIZzMwNHdtOFZwRTNZYlNGZWpCVGhUQWZEbkk1dG1WaFow?=
 =?utf-8?B?eW1mQmZLa1pINlBnUmsxMVFUcFFyaEh4Zk4ydFEwZjU0djdPSXhsWEtITlNq?=
 =?utf-8?B?UU8zMWtxTzBrYzd4TWxNY09Vb1RlcG95NTZIY05YcVB5UHdPRWgrSHVmSFFn?=
 =?utf-8?B?N3NPZmhZeTJrTDNuRnRFU1NabHJIblZUM1NwVkwzY2t1MVRiejR4bXlIejkz?=
 =?utf-8?B?cGk4ZWFQVkZQRjFMcDNvWVgzMWN1OFFBZ25TUnQ1MzFFaWZmUHpjS0lnNzRa?=
 =?utf-8?B?VUNFdkQyRnM1ZEFNSFFPcnVwYzFwVjlodHZYbjl4b3YxL29UWXI5VlJ6V0lR?=
 =?utf-8?B?dndpQUtKSVpadkNBZkIyWmhNeTdIOVlrUnJIRi9BRDFYcENqU0tONVFaZi81?=
 =?utf-8?B?RmpOSUUrc1J6Y0ZOVmdkQVFwclFjampnOC9jTlg1UjJCdVluQXMySk44ZHF0?=
 =?utf-8?B?ZFRCamRFbXFTYXpKUFlYbjVwd0xiQ1YyN212SHpJVElLYWFaOFpqTVpjMGhm?=
 =?utf-8?B?Vi9FQUtxZXJJdU9udDkrZUhlUjhZS0xIRU5sZWNsZDBFQU9ITFIvakwyMFhQ?=
 =?utf-8?B?c0tlVWFzUDBodXJqQ0tmUmtZTU1ONFFHSVVaTnhuanZSaXFyc2dBRUVUb3lQ?=
 =?utf-8?B?SnVHT3lPSDhuQ0tSQXVXUTFqNkg3cmhVUmNWdDk1blhrQUZQdk1zenFwcVZE?=
 =?utf-8?B?anZoS1djSy9qU0E0TFRGQ29kTXhaMFlOUDdGZzdBSG13VXBqMkVGZmw1R1JW?=
 =?utf-8?B?UTBaQzhFaktMelVlOXdTMFNWb0R6aDB6MmtvM3BYanRzUHJCYmF6UFN6dU5Y?=
 =?utf-8?B?TE5pRmhKNWZqTi9QcUtIOW1SUjYxNVVObG15NGt1Ui9tRHgvaGxPR0F5VXJ6?=
 =?utf-8?B?MHBEWlNZRDF6R1phMnFxNER4VjNCTytFM3hkSEVwdzlZUGNXWWpob3pCMWVu?=
 =?utf-8?B?YkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b44755b-7695-415a-d177-08da5df1c277
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 19:16:56.0448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wo5Ad8SKwrjrUaJPs6OHO6mEQR9Nu14SanYWe7hvGgz1H0LBqn7Yks/03NTnaXJusNwqeTGSMLav1nAjXmEPnFqrbWODw4UbmtQK1DQgS6A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3004
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/4/2022 4:06 PM, Tan Zhongjun wrote:
> Use swap() instead of open coding it
>
> Signed-off-by: Tan Zhongjun <tanzhongjun@coolpad.com>

Changes in the ACPICA files need to be routed through the upstream 
ACPICA project at github.

Please submit a pull request in there.


> ---
>   drivers/acpi/acpica/nsrepair2.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/acpica/nsrepair2.c b/drivers/acpi/acpica/nsrepair2.c
> index dd533c887e3a..3735ba06ea16 100644
> --- a/drivers/acpi/acpica/nsrepair2.c
> +++ b/drivers/acpi/acpica/nsrepair2.c
> @@ -875,7 +875,6 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
>   {
>   	union acpi_operand_object *obj_desc1;
>   	union acpi_operand_object *obj_desc2;
> -	union acpi_operand_object *temp_obj;
>   	u32 i;
>   	u32 j;
>   
> @@ -892,9 +891,7 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
>   			    || ((sort_direction == ACPI_SORT_DESCENDING)
>   				&& (obj_desc1->integer.value <
>   				    obj_desc2->integer.value))) {
> -				temp_obj = elements[j - 1];
> -				elements[j - 1] = elements[j];
> -				elements[j] = temp_obj;
> +				swap(elements[j - 1], elements[j]);
>   			}
>   		}
>   	}