Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220704172116.195841-1-marcus.folkesson@gmail.com> <20220704172116.195841-6-marcus.folkesson@gmail.com>
In-Reply-To: <20220704172116.195841-6-marcus.folkesson@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 4 Jul 2022 23:56:41 +0200
Message-ID: <CAHp75Vc84jTQmTo7sb9sohkG0LmZmQX+hDimwCUb89vqmGfdcA@mail.gmail.com>
Subject: Re: [PATCH v3 5/9] iio: adc: mcp3911: add support for buffers
To:     Marcus Folkesson <marcus.folkesson@gmail.com>
Cc:     Kent Gustavsson <kent@minoris.se>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jul 4, 2022 at 7:20 PM Marcus Folkesson
<marcus.folkesson@gmail.com> wrote:
>
> Add support for buffers to make the driver fit for more usecases.

use cases

...

> +       for_each_set_bit(scan_index, indio_dev->active_scan_mask,
> +                       indio_dev->masklength) {
> +               const struct iio_chan_spec *scan_chan =
> +                       &indio_dev->channels[scan_index];
> +
> +               adc->scan.channels[i] = adc->rx_buf[scan_chan->channel * 3 + 0] << 16 |
> +                                       adc->rx_buf[scan_chan->channel * 3 + 1] << 8 |
> +                                       adc->rx_buf[scan_chan->channel * 3 + 2] << 0;

get_unaligned_be24()

> +               i++;
> +       }

...

> @@ -325,6 +403,7 @@ static int mcp3911_probe(struct spi_device *spi)
>         if (ret)
>                 return ret;
>
> +
>         indio_dev->name = spi_get_device_id(spi)->name;
>         indio_dev->modes = INDIO_DIRECT_MODE;
>         indio_dev->info = &mcp3911_info;

Stray change.

-- 
With Best Regards,
Andy Shevchenko