Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i0ad843c9:Fastmail
Subject: Re: [PATCH v12 2/7] dt-bindings: pinctrl: sunxi: Make interrupts
 optional
To:     Andre Przywara <andre.przywara@arm.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
        linux-gpio@vger.kernel.org
References: <20220701112453.2310722-1-andre.przywara@arm.com>
 <20220701112453.2310722-3-andre.przywara@arm.com>
From:   Samuel Holland <samuel@sholland.org>
Message-ID: <74a5466c-a84b-57fa-79ad-96155c1324a0@sholland.org>
Date:   Mon, 4 Jul 2022 18:55:59 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20220701112453.2310722-3-andre.przywara@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/1/22 6:24 AM, Andre Przywara wrote:
> The R_PIO pinctrl device on the Allwinner H616 SoC does not have an
> interrupt (it features only two pins).
> However the binding requires at least naming one upstream interrupt,
> plus the #interrupt-cells and interrupt-controller properties.
> 
> Drop the unconditional requirement for the interrupt properties, and
> make them dependent on being not this particular pinctrl device.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>

Acked-by: Samuel Holland <samuel@sholland.org>

> ---
>  .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml      | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> index bfce850c20351..0bd903954195b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> @@ -133,14 +133,11 @@ patternProperties:
>  
>  required:
>    - "#gpio-cells"
> -  - "#interrupt-cells"
>    - compatible
>    - reg
> -  - interrupts
>    - clocks
>    - clock-names
>    - gpio-controller
> -  - interrupt-controller
>  
>  allOf:
>    # FIXME: We should have the pin bank supplies here, but not a lot of
> @@ -148,6 +145,18 @@ allOf:
>    # warnings.
>  
>    - $ref: "pinctrl.yaml#"
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            enum:
> +              - allwinner,sun50i-h616-r-pinctrl
> +    then:

Nit: all of the existing ifs and thens have blank lines between them.

> +      required:
> +        - "#interrupt-cells"
> +        - interrupts
> +        - interrupt-controller
> +
>    - if:
>        properties:
>          compatible:
>