Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp678506imw; Mon, 4 Jul 2022 17:47:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tF7KNHw6XJSN9K4FIpAvv2TrBB7CVbFl7r/YB7hFCienaXC9LhFmVuxrdno1EoCxvBukb2 X-Received: by 2002:a05:6402:5384:b0:431:6d84:b451 with SMTP id ew4-20020a056402538400b004316d84b451mr41705534edb.46.1656982023506; Mon, 04 Jul 2022 17:47:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656982023; cv=none; d=google.com; s=arc-20160816; b=r0OmQRAlH6wsq9n73EKActDDK/oD7PCy1ki6X9IzFU/ApZzSJR7SVxYfDqU8dyw0D/ A/OotHh2xQA4qEUuQY6/d6pDqwcTyU/U60/Ax2v+5UtNZ7AFL3/UN78PoS7fUSd6FJit 9X01YuyIH0qoZMwwytIsgkmW7fZ0HWZjYoNOnz28QCMnwwhI2Up3pV5MzXw37m6PZLEn RJSgju+q/SyHGvqHUI3RgP/camVps7Ru4fDO+017jaJ4bID8doeYCB0Ngj/n64bKpCVU QbVwlYcHB4Zo8j6BI+Sg51dEWpnz8h/hwlsPJDETPI/e6HFNgxNpy9vrBMsEaLmlf2fb uspQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sgvzDtqbn90VcVBoAgG33irI5inVtBBIKP+zsASphds=; b=r5fJxA4Zzb2rTdFp+D/LBjWZAphcL1Sk+KzkFoayy9aPEcMbWo9FkOkj9xTulVJYTr p9ttmXtacYReJDwYrSydrq4EUCNuhUk0be6Mc6Q16mxmeqSSFoAeKeM53wXQCDHDxLyi 34fnXEyiD/F0+o6bJDu8uTlaUtRBgciWMfBw/hIOesMxtAnK09O8bvdgnvH0Z1EDM/+L +wnexN4q4/KKI5bf9w3mEkwn/67m1lejyc4uY6f/n8LE4I7YqFct/IG1VaZUEJIrlsOK ldL7Q33YvOPX40O0/rwTqien5XiAP2fBvz0t5yn3AyCro+AlLDzR6tXq8IwbTeInS0eS mR+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="cML8F2/r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa12-20020a1709076d0c00b007269ef1872esi19127400ejc.897.2022.07.04.17.46.38; Mon, 04 Jul 2022 17:47:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="cML8F2/r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231778AbiGEAmp (ORCPT + 99 others); Mon, 4 Jul 2022 20:42:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbiGEAmo (ORCPT ); Mon, 4 Jul 2022 20:42:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BC492BEA for ; Mon, 4 Jul 2022 17:42:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7F7F616ED for ; Tue, 5 Jul 2022 00:42:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA609C3411E; Tue, 5 Jul 2022 00:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656981763; bh=NH5c7njVSOspj3x3CMKvmR0zmbbUmwx4E9ZZYbEUmyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cML8F2/rNnHbks8e7CnqUhOmIdkzwwsccL1VmbQy1N2i896KnOAyzzcV3IQUw1bun j4wTeQLNJ9g/xMhFZUcxNQ+dywd34+nYX2acDwVvOMgiInFIKtXsefmpSyizqVknnM b7hftZlzd3RUANdcMcdUiaB/qXh3GqfM5UdNLZnt3l1astEM0M8K5ny93L1nZHmdtH WeRFtSh7WOBl/Hl/Vfpay2u18ChiFwaXNlOg9VgXlLpXvH1+HuHeiIaDWTUrspVb7m p2gnRyMtBxZuJJGAX3yv9ZbePsBuE8dM/atdGFhOYKu0YROHQovEZ1YP5l+yyLiPih WoRW00tur0vZA== Date: Tue, 5 Jul 2022 08:42:37 +0800 From: Shawn Guo To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, michael@walle.cc, arnd@arndb.de Subject: Re: [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init() Message-ID: <20220705004237.GP819983@dragon> References: <20220628140249.1073809-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628140249.1073809-1-yangyingliang@huawei.com> X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022 at 10:02:48PM +0800, Yang Yingliang wrote: > In case of error, of_iomap() returns NULL pointer not ERR_PTR(). > The IS_ERR() test in the return value check should be replaced > with NULL test and return -ENOMEM as error value. > > Fixes: ab4988d6a393 ("soc: fsl: guts: embed fsl_guts_get_svr() in probe()") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Applied both, thanks!