Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp747184imw; Mon, 4 Jul 2022 19:31:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vxB6qRbBZBhFybCdL8Nak7RdwuuvJQt50QDZC3NWoB96Q86QSsHwqQ5b3vFWKisn7ju4Tj X-Received: by 2002:a05:6402:444a:b0:43a:63fd:eec6 with SMTP id o10-20020a056402444a00b0043a63fdeec6mr9514604edb.18.1656988284481; Mon, 04 Jul 2022 19:31:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656988284; cv=none; d=google.com; s=arc-20160816; b=QoeFyXXPZ7HKv2+bVbPMXDLPHWYSwnbiS8z2/MUGvz+EDFw6QqxKQN5eDmioNMY6jB hbXy8vr3lTYt9WsRokgGCmobG5MnFwcdPh2QGyKar2ibiqlXy9ZPDoLDw0AyeP9BKkGC pbw5bcDcjHwvRP5Y1/+hfClvuyX7ZTeLYWUP0gnbUENR7dyemzd9e93uaOfkkRYNuqNY a7TQH+RdkRRq54pEPz97CiuIKbQSMUVebbU49Mw0CIdBRIktR6Vl94FTuD2rNL3ImqQt +r8w4atzeK2mVzxTRkYGxXSkDL4U0ssqH9nqf57OFXhdYSpnjw9JAJ5hsQx+PkCoeynw 4LCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ylg4Pau4j+0Wi3P+QdsHAP6IDPjCd7WkHJuN8xLKC3I=; b=rLKIrDozo29Mz1wZ/Uk/nm1NmdLPIOsKPrZ24N0Xjnpy8wnqtQWMTLXfjHdobzy7DF yfIYgJWmSywh4N/bAH9w43WS+DmDyopL7bLrAyyug6zIi9p9vumNRZdMoRCUODtxle5A I1X1Zy7mOSVoGpMJCRmA2GHQiw9ubya56IlyWCI0GI3tIGLH8kTupB7yTbZBXiaGX3d0 S56+zzmuKDsUGg34AHAF2vFjFnOJQUOu21oodGuWkrToHxwp+sueXD1YkocNHjsI+IOJ do73jwYcRImq6oRffzNUeYhewtN1Sp2iWON5mBavaPmeO8WGTPBeloUyYNGB0U6t4RqP lIEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jRmKww1r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ej13-20020a056402368d00b0043783a835aasi15494257edb.410.2022.07.04.19.31.00; Mon, 04 Jul 2022 19:31:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jRmKww1r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234218AbiGECWl (ORCPT + 99 others); Mon, 4 Jul 2022 22:22:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231329AbiGECWh (ORCPT ); Mon, 4 Jul 2022 22:22:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4A35A10AD for ; Mon, 4 Jul 2022 19:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656987756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ylg4Pau4j+0Wi3P+QdsHAP6IDPjCd7WkHJuN8xLKC3I=; b=jRmKww1rYLLY8NhM/8eeTe6zMAdYNJqMqdxXjacES6yhXdThuZeo46Mc97errLunPh32Vx OVszrPi8Gj5lBPLsNZQ7S3BpBDfF1ydZS6VoqTOhfy/OFSjoV8tm/nJgaA3cETC3+u91zt wFBMwd2GRJiVVgJADvyROHBwddeh+wA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-147-duY3c0KQNwWyZbH2abTbOg-1; Mon, 04 Jul 2022 22:22:30 -0400 X-MC-Unique: duY3c0KQNwWyZbH2abTbOg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 53541804181; Tue, 5 Jul 2022 02:22:30 +0000 (UTC) Received: from lxbceph1.gsslab.pek2.redhat.com (unknown [10.72.47.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B6571121315; Tue, 5 Jul 2022 02:22:27 +0000 (UTC) From: xiubli@redhat.com To: dhowells@redhat.com Cc: linux-kernel@vger.kernel.org, willy@infradead.org, keescook@chromium.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, Xiubo Li Subject: [RFC PATCH] netfs: do not get the folio reference twice Date: Tue, 5 Jul 2022 10:22:19 +0800 Message-Id: <20220705022219.286459-1-xiubli@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiubo Li And also the comment said it will drop the folio references but the code was increasing it. Signed-off-by: Xiubo Li --- fs/netfs/buffered_read.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c index 5b93e22397fe..a44a5b3b8d4c 100644 --- a/fs/netfs/buffered_read.c +++ b/fs/netfs/buffered_read.c @@ -396,9 +396,6 @@ int netfs_write_begin(struct netfs_inode *ctx, */ ractl._nr_pages = folio_nr_pages(folio); netfs_rreq_expand(rreq, &ractl); - - /* We hold the folio locks, so we can drop the references */ - folio_get(folio); while (readahead_folio(&ractl)) ; -- 2.36.0.rc1