Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp761913imw; Mon, 4 Jul 2022 19:54:51 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sJtleih9zqVG81Ae79NC4WBGm6+JD7o3yzBWHZXcbhoDdXN0hGDMyc61hPbm2nV39fxmqO X-Received: by 2002:a05:6402:4518:b0:43a:3b90:7457 with SMTP id ez24-20020a056402451800b0043a3b907457mr13731952edb.422.1656989691234; Mon, 04 Jul 2022 19:54:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656989691; cv=none; d=google.com; s=arc-20160816; b=Wsy7+jzAg4adweII8uFvz2MwaCoqJKE0aKWI2vn6grfEJHZ4/jDr9qHwI//xockuYE 6bJ4Hz7F9hBG7ziO8fwPy4CyCuANawUZbdxao5DCV4fE5bYdauqOD4iz19SLEhESFfCH /76y+lgjcYvaiMvXtrjxwJ1tA8nCHb1gY+WZWi1dUZaIx9sOP8KSCx9LJSnVEvqtZJ6G vig1oPcf1rQiLY+YidsqOTxUGRcgGYfNBzNHKVp9DmYKdthdCmWnCUxHRQMPn7WpFlqe A9vLZlC/yIskZyEM0gAOPwKBhVY3dT7D1KlQ7/HNaZ+LQmJBbFQ+alqR5PpX0xyCL761 1f3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=FDoE/8Awdtvks8bNbtNpSLLHjXC8LT6Ntw8V4yNyebw=; b=UOXUHhs+4z+4FUs4e0ui3MMw11mRnFdj9NDV0abI0Slq3CyiDXfpfE42TOuk40cu0Z rwPBZpLIN6guEdQ+sme1VS5sOTbufODupazAsPA+LfC5MY1hJpFAI36ijyZKDClMoX27 NAaZsFTsfpRAG1tSOmkZYyE79wdrp1vaSpmHdu5EFqP5+dkwG4+MPUxWA8/A2nmPOL21 /AUMdwFfn0obv3V7aEC8nScmWwZLyLas8IvwyyntxRibJg4NY5WsUv4zDAFHT59oldec t7kPzTjYOA8xDP5uNq0MTT0uOrYNjGEL019GqaGvYqQBX5Wl9titi4Aq6yOzlH2zhHq6 AqVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m7-20020a509307000000b00435799ce323si12749439eda.190.2022.07.04.19.54.26; Mon, 04 Jul 2022 19:54:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234530AbiGEC02 (ORCPT + 99 others); Mon, 4 Jul 2022 22:26:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234470AbiGEC00 (ORCPT ); Mon, 4 Jul 2022 22:26:26 -0400 Received: from mail.nfschina.com (unknown [IPv6:2400:dd01:100f:2:72e2:84ff:fe10:5f45]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1291A1274C; Mon, 4 Jul 2022 19:26:24 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 2DAE51E80D71; Tue, 5 Jul 2022 10:24:22 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SBn1PamTXi59; Tue, 5 Jul 2022 10:24:19 +0800 (CST) Received: from localhost.localdomain (unknown [180.167.10.98]) (Authenticated sender: jiaming@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id BB7911E80D19; Tue, 5 Jul 2022 10:24:18 +0800 (CST) From: Zhang Jiaming To: song@kernel.org Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, d@ja.vu, liqiong@nfschina.com, renyu@nfschina.com, Zhang Jiaming , Paul Menzel Subject: [PATCH v2] block: Fix spelling mistakes in comments Date: Tue, 5 Jul 2022 10:26:17 +0800 Message-Id: <20220705022617.12555-1-jiaming@nfschina.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220704012328.6507-1-jiaming@nfschina.com> References: <20220704012328.6507-1-jiaming@nfschina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,RDNS_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix spelling of dones't and waitting in comments. Fix tense mistakes of hold and finsh in comments. Use underline to connecting reconfig and mutex. Signed-off-by: Zhang Jiaming Reviewed-by: Paul Menzel --- drivers/md/raid5-cache.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c index 83c184eddbda..8d5154d94f86 100644 --- a/drivers/md/raid5-cache.c +++ b/drivers/md/raid5-cache.c @@ -125,7 +125,7 @@ struct r5l_log { * reclaimed. if it's 0, reclaim spaces * used by io_units which are in * IO_UNIT_STRIPE_END state (eg, reclaim - * dones't wait for specific io_unit + * doesn't wait for specific io_unit * switching to IO_UNIT_STRIPE_END * state) */ wait_queue_head_t iounit_wait; @@ -1326,12 +1326,12 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log, * Discard could zero data, so before discard we must make sure * superblock is updated to new log tail. Updating superblock (either * directly call md_update_sb() or depend on md thread) must hold - * reconfig mutex. On the other hand, raid5_quiesce is called with - * reconfig_mutex hold. The first step of raid5_quiesce() is waitting - * for all IO finish, hence waitting for reclaim thread, while reclaim - * thread is calling this function and waitting for reconfig mutex. So + * reconfig_mutex. On the other hand, raid5_quiesce is called with + * reconfig_mutex held. The first step of raid5_quiesce() is waiting + * for all IO to finish, hence waiting for reclaim thread, while reclaim + * thread is calling this function and waiting for reconfig_mutex. So * there is a deadlock. We workaround this issue with a trylock. - * FIXME: we could miss discard if we can't take reconfig mutex + * FIXME: we could miss discard if we can't take reconfig_mutex */ set_mask_bits(&mddev->sb_flags, 0, BIT(MD_SB_CHANGE_DEVS) | BIT(MD_SB_CHANGE_PENDING)); -- 2.34.1