Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Jul 2022 10:57:34 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        bliang@analogixsemi.com, qwen@analogixsemi.com,
        jli@analogixsemi.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v12 3/3] usb: typec: anx7411: Add Analogix PD ANX7411
 support
Message-ID: <20220705025734.GD2303286@anxtwsw-Precision-3640-Tower>
References: <20220628044843.2257885-1-xji@analogixsemi.com>
 <20220628044843.2257885-3-xji@analogixsemi.com>
 <Yrrcj5rnP8y4mjqQ@kuha.fi.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yrrcj5rnP8y4mjqQ@kuha.fi.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D0ExSks3A+xU3BqqYKrbnesdCQ6Bo9W4WdysAgOjkQva8DD31khUwII7lqJ6?=
 =?us-ascii?Q?4Byo+nOomXmXOP5pJLp8vV3h0dSb8Yj9nj1Jx9GglACxct4nyo7SPtrC/Owe?=
 =?us-ascii?Q?gl00DyVQ58wjj8VsLr1x7vHV+Pc5e/h79x+1MjeaXs+8EOLTSTr5IymXwBSY?=
 =?us-ascii?Q?dwIkIqLr4a+6VlMZJQJi/g15nmsj9e44t63eMcjzpKpgLSXW/2SeaSQM9dze?=
 =?us-ascii?Q?LbrS88qxH4ssYoKACiQIY9WsZn1HCpYJrlfapAp1qh5YBEort5yeCymnmFye?=
 =?us-ascii?Q?2eev61vXEorIutClSoVX1JUvG9ez+4hQOateVdE+KaJ0TpfruCqE+OqJT5fw?=
 =?us-ascii?Q?YNqUIxS9VeXV7K8S/+OB6hWMx8fI7GsMwNB65jCmLzkJWOfEcUHuk98UWU9x?=
 =?us-ascii?Q?NSBI2VHXdxNmxQNm3IUBBkBDlrb60h7ZsoNV11xdovtcu6wdxZ0njcEpxfqw?=
 =?us-ascii?Q?D4pzO7exPQ3CpkZwqG+cmez3/IGkkFyIWyOwKrA1BcU1y7X3asLonuJ3/kFc?=
 =?us-ascii?Q?r3zH5B5XtWW0YTYzUPtkm1u/XqxM/O0MTrHeCqPG4qZZ6vyLZrskm1S7yJzS?=
 =?us-ascii?Q?i2ypgZ+NhsQ/giuahnl/JY9MvKyxW4nV3kAW/jL35Az1MzwraR25km47AvwW?=
 =?us-ascii?Q?737xxHwU7iKgngMfgo0s5EHyauROEOVIQIaMKzol3cC2FA+Ynp4dVjBjnejK?=
 =?us-ascii?Q?AQsjV4c1n3CEEkJS1Baaj7RX9PzLeDZdMUymc8GtubA6a06uN7AFlfg2nYbZ?=
 =?us-ascii?Q?wGf5WUOHXRz46HoljfMSLCXroeOwSE5Xi+WSxs/zjS1irsQrKfiGOY2ldCB8?=
 =?us-ascii?Q?4pPuICkxLn7hNbKdNyEOvaR1nND8dbfXlovXW0bF4KSSkoHrOgNP8RVRD9hc?=
 =?us-ascii?Q?t1pYBD7f5s7rjkUQd3ltryXrB3KFbbnjzvsezYOmyiz3JfQ3ns6bGNGoo1p+?=
 =?us-ascii?Q?mRR1CEewhqIioDbn1f62pyh91jb4KG4MgxolbC7vh/YMpBroH4cQNpGU8jpu?=
 =?us-ascii?Q?IX/SBnufo09nZCGBsFT+poKnqelOc5dNEYcxVV0c8vg9F3FNffDqIbaJ2b/e?=
 =?us-ascii?Q?FsXepiCy5xsF6OC0nLNLNbENnYgtoDybZPM2AUK40mwQEBpsN8UOokdyimAS?=
 =?us-ascii?Q?YamNoZlW+9ym6/w8FqSW72me08/rr449ry3YU1qawfhMLUrjGyd2rrzvoVhx?=
 =?us-ascii?Q?rKWBRqVrT3fAkDt34uTLuyNqq1YXgBTGriuAp05H7IsLL/dop+mhsFE0mIBJ?=
 =?us-ascii?Q?butoboPs9xBBxJSWo5vyFunFnK9xmQYaCs0rs5U5bQRDt7kouhKXSsDrzI6l?=
 =?us-ascii?Q?BVoA/1RjowG6mfmogBcOaRhNwfVpJ49mNSxta5qtQ4PzqNxtSOQ3tn/q+jvM?=
 =?us-ascii?Q?IBCRuf2AhP8UeXTAOabb/ls5Jd2uNcN6EnzTWzkgXUwPKqgMhZXD9KRFfZ1N?=
 =?us-ascii?Q?YDcPMPzyT8wpLFDT2/5oGDBRhDOx6t8uWwYQt8dW4rvoL0nOErc1BCAmmxGX?=
 =?us-ascii?Q?A7YaWhjZV3CMmfSvaBS7JejDd7bZUtQnnD0mNeGW2gLSbu55bURmO8onVUiZ?=
 =?us-ascii?Q?IcfHOGInyjcxXbPenWgzbI8aM0thSifV4m4h+Oni?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4595d227-5162-4399-a4aa-08da5e321f27
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 02:57:39.1820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uMqAPDMbyFtr7hRzrHWrx5k/zBQ34tQu8cVwbEMbgwnVGSgBEXHgor3bz1vXdt7Tj+m8954VfCpAUfBQaq15Fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4137
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi heikki, OK. I'll add comment.
Thanks,
Xin

On Tue, Jun 28, 2022 at 01:48:47PM +0300, Heikki Krogerus wrote:
> Hi,
> 
> On Tue, Jun 28, 2022 at 12:48:42PM +0800, Xin Ji wrote:
> > diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
> > new file mode 100644
> > index 000000000000..76e4b5fc0d9e
> > --- /dev/null
> > +++ b/drivers/usb/typec/anx7411.c
> > @@ -0,0 +1,1564 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +
> > +/*
> > + * Copyright(c) 2022, Analogix Semiconductor. All rights reserved.
> > + *
> > + */
> 
> Could you also add a line to that comment that tells what this driver
> is? So something like this:
> 
> /*
>  * Driver for Analogix ANX7411 USB Type-C and PD controller
>  *
>  * Copyright(c) 2022, Analogix Semiconductor. All rights reserved.
>  */
> 
> thanks,
> 
> -- 
> heikki