Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1655892104-10874-1-git-send-email-u0084500@gmail.com>
 <1655892104-10874-3-git-send-email-u0084500@gmail.com> <Yrm9ObaltUiQUTqS@google.com>
 <CADiBU3802sLTPjrGiaQ-xw-2jep1UXo+t7pYc6bCC4MiJLhOyA@mail.gmail.com>
 <CADiBU3838Mgi3sqv+R_=8g-ROTrbN45AKPaTS_9GCWVDYASMyg@mail.gmail.com>
 <Yr6kVg2OlHkm6+bB@google.com> <CADiBU396poOuzdGABzTazouM5MX=auZ9OdyT_sqWrKnZk3tFRw@mail.gmail.com>
 <CADiBU3_7MmPkfV7-B8rhxFRtZcrJ6BPocXzT4bs3cu36UR5XGw@mail.gmail.com> <YsK44Dp3yZwqPi0H@google.com>
In-Reply-To: <YsK44Dp3yZwqPi0H@google.com>
From:   ChiYuan Huang <u0084500@gmail.com>
Date:   Tue, 5 Jul 2022 11:04:10 +0800
Message-ID: <CADiBU38M=iTJnsV0_pmQnyjuw_hXrzGLb3pDpSEZ05=eY2iC=Q@mail.gmail.com>
Subject: Re: [PATCH v2 2/4] mfd: rt5120: Add Richtek PMIC support
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Mark Brown <broonie@kernel.org>, dmitry.torokhov@gmail.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        cy_huang <cy_huang@richtek.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        linux-input@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Lee Jones <lee.jones@linaro.org> =E6=96=BC 2022=E5=B9=B47=E6=9C=884=E6=97=
=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=885:54=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Mon, 04 Jul 2022, ChiYuan Huang wrote:
>
> > Hi, Lee:
> >
> > ChiYuan Huang <u0084500@gmail.com> =E6=96=BC 2022=E5=B9=B47=E6=9C=881=
=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=885:56=E5=AF=AB=E9=81=93=EF=BC=
=9A
> > >
> > > Lee Jones <lee.jones@linaro.org> =E6=96=BC 2022=E5=B9=B47=E6=9C=881=
=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=883:38=E5=AF=AB=E9=81=93=EF=BC=
=9A
> > > >
> > > > On Fri, 01 Jul 2022, ChiYuan Huang wrote:
> > > >
> > > > > HI, Lee:
> > > > >
> > > > > ChiYuan Huang <u0084500@gmail.com> =E6=96=BC 2022=E5=B9=B46=E6=9C=
=8827=E6=97=A5 =E9=80=B1=E4=B8=80 =E6=99=9A=E4=B8=8A10:56=E5=AF=AB=E9=81=93=
=EF=BC=9A
> > > > > >
> > > > > > Lee Jones <lee.jones@linaro.org> =E6=96=BC 2022=E5=B9=B46=E6=9C=
=8827=E6=97=A5 =E9=80=B1=E4=B8=80 =E6=99=9A=E4=B8=8A10:22=E5=AF=AB=E9=81=93=
=EF=BC=9A
> > > > > > >
> > > > > > > On Wed, 22 Jun 2022, cy_huang wrote:
> > > > > > >
> > > > > > > > From: ChiYuan Huang <cy_huang@richtek.com>
> > > > > > > >
> > > > > > > > Add Richtek RT5120 PMIC I2C driver.
> > > > > > >
> > > > > > > Why a whole new driver?
> > > > > > >
> > > > > > > How different is this to rt5033?
> > > > > > >
> > > > > > > Looks like this could easily be woven into this existing supp=
ort?
> > > > > > >
> > > > > > It's different with the function domain.
> > > > > > RT5033 is most like as the SubPMIC that includes PMU (battery
> > > > > > charger/gauge/led/few buck and ldo)
> > > > > > RT5120 is a main PMIC with default-on power that follows the bo=
ot on sequence.
> > > > > > RT5120 only integrates regulator and power key report module.
> > > > > >
> > > > > Since I have explained the chip difference, do you still think it=
's
> > > > > better to merge this code into rt5033 mfd?
> > > >
> > > > I think it's okay to group devices which are similar but not exactl=
y
> > > > the same, if they can be.  The integration of this device into the
> > > > other looks trivial to my naive eyes.
> > > >
> > > > A PMIC is a PMIC, main or sub.
> > > >
> > > M.. ok. I will try to group all chip changes like as devices
> > > list/regmap_irq/regmap_config ..., etc.
> > > Treat it as one set of chip config and use 'of_device_get_match_data'
> > > to get the chip config data.
> > >
> > There's a question.
> > As I know, it's not the same chip series.
> > The rt5033 is submitted from Samsung at 2015.
> > The driver data is also defined in header file.
> >
> > Do you still suggest to do the merge?
> > Even in our internal, it's difficult to find a rt5033 EVB for testing.
> >
> > And one more question is the binding. If yes, for the binding, I need t=
o add
> > rt5033 related.....
> >
> > Actually, it's a tough work.
>
> If it's genuinely difficult to integrate, you can keep them separate.
>
Keep it in this patch series and wait for your reviewing.
Hope that I'm not misunderstanding.
> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Principal Technical Lead - Developer Services
> Linaro.org =E2=94=82 Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog