Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Jul 2022 07:37:21 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org,
        Wedson Almeida Filho <wedsonaf@google.com>
Subject: Re: [PATCH] char: misc: make misc_open() and misc_register() killable
Message-ID: <YsPOEYU7ZqmpD8dw@kroah.com>
References: <000000000000d9ff3a05bb37069e@google.com>
 <72e74af9-f1b6-e383-a2c3-6ee8a0aea5e0@I-love.SAKURA.ne.jp>
 <YsKW6VvWqvcMRBSl@kroah.com>
 <100f445e-9fa8-4f37-76aa-8359f0008c59@I-love.SAKURA.ne.jp>
 <YsLIepAXeBKT0AF/@kroah.com>
 <01a93294-e323-b9ca-7e95-a33d4b89dc47@I-love.SAKURA.ne.jp>
 <YsL5pUuydMWJ9dSQ@kroah.com>
 <617f64e3-74c8-f98b-3430-bd476867e483@I-love.SAKURA.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <617f64e3-74c8-f98b-3430-bd476867e483@I-love.SAKURA.ne.jp>
Precedence: bulk

On Tue, Jul 05, 2022 at 02:21:17PM +0900, Tetsuo Handa wrote:
> On 2022/07/04 23:31, Greg KH wrote:
> > I don't understand what you are trying to "fix" here.  What is userspace
> > doing (as a normal user) that is causing a problem, and what problem is
> > it causing and for what device/hardware/driver is this a problem?
> 
> Currently the root cause is unknown.
> This might be another example of deadlock hidden by device_initialize().
> 
> We can see from https://syzkaller.appspot.com/text?tag=CrashReport&x=11feb7e0080000 that
> when khungtaskd reports that a process is blocked waiting for misc_mtx at misc_open(),
> there is a process which is holding system_transition_mutex from snapshot_open().

/dev/snapshot is not read/writable by anyone but root for obvious
reasons.

And perhaps it's something that syzbot shouldn't be fuzzing unless it
wants to take the system down easily :)

thanks,

greg k-h