Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [RFC PATCH] netfs: do not get the folio reference twice
To:     dhowells@redhat.com
Cc:     linux-kernel@vger.kernel.org, willy@infradead.org,
        keescook@chromium.org, linux-fsdevel@vger.kernel.org,
        linux-cachefs@redhat.com
References: <20220705022219.286459-1-xiubli@redhat.com>
From:   Xiubo Li <xiubli@redhat.com>
Message-ID: <2dcc7854-643c-0c77-b0b6-9443b9ee1dcd@redhat.com>
Date:   Tue, 5 Jul 2022 14:11:20 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20220705022219.286459-1-xiubli@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 7/5/22 10:22 AM, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
>
> And also the comment said it will drop the folio references but
> the code was increasing it.
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>   fs/netfs/buffered_read.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c
> index 5b93e22397fe..a44a5b3b8d4c 100644
> --- a/fs/netfs/buffered_read.c
> +++ b/fs/netfs/buffered_read.c
> @@ -396,9 +396,6 @@ int netfs_write_begin(struct netfs_inode *ctx,
>   	 */
>   	ractl._nr_pages = folio_nr_pages(folio);
>   	netfs_rreq_expand(rreq, &ractl);
> -
> -	/* We hold the folio locks, so we can drop the references */
> -	folio_get(folio);
>   	while (readahead_folio(&ractl))
>   		;
>   

Will drop this patch, the above fix it incorrect.

Thanks!