Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kavyasree.Kotagiri@microchip.com>
To:     <robh@kernel.org>
CC:     <Nicolas.Ferre@microchip.com>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <Claudiu.Beznea@microchip.com>, <krzysztof.kozlowski@linaro.org>,
        <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH v4 1/3] dt-bindings: mfd: atmel,flexcom: Convert to
 json-schema
Thread-Topic: [PATCH v4 1/3] dt-bindings: mfd: atmel,flexcom: Convert to
 json-schema
Thread-Index: AQHYgktCiqqptpU+dEuWUcG+O1Oj/61ToBIAgASPMICADTTcAIAKCYeg
Date:   Tue, 5 Jul 2022 06:36:01 +0000
Message-ID: <SA2PR11MB487472B96E8B1FBC0B50424A92819@SA2PR11MB4874.namprd11.prod.outlook.com>
References: <20220617130729.12072-1-kavyasree.kotagiri@microchip.com>
 <20220617130729.12072-2-kavyasree.kotagiri@microchip.com>
 <1655474312.882258.1508989.nullmailer@robh.at.kernel.org>
 <CO1PR11MB48653378BAECD414F497D59592B09@CO1PR11MB4865.namprd11.prod.outlook.com>
 <20220628211638.GC963202-robh@kernel.org>
In-Reply-To: <20220628211638.GC963202-robh@kernel.org>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RJI1nUUaaVx69Od7DLDOW4uqVfbrr42h8WcYURh0ojKRk95yOSe7DNTKjNy/?=
 =?us-ascii?Q?I1TLkL3B/Did/2cXMBiokr0sYGF5IRcUO9b1uT7vZdxVc4tiJmy13Pm+glZL?=
 =?us-ascii?Q?i5j9UP6CCg7i1yJ8YJtXp38lTEfa7Ha8rlzHlxPkYJaSAUWS3SYIGJsi6TU9?=
 =?us-ascii?Q?bq6TFeT8NWm4/0ajPRroIs4A1Yy4lXo8O2ZUnw47dIvun+MZTaLDPmcpVE1R?=
 =?us-ascii?Q?tUb4rO0IfEawNy7dipwNg17Z5yb4bGEV9HlhoVrWf0kAvIjufsFVYT3UN4P+?=
 =?us-ascii?Q?byPZyxIovDjDYQGqkZBReO8PFNcs2LOdcsgvQ09iS6xi7PmqNRaM0C1pOsq/?=
 =?us-ascii?Q?lroLxgGa0j4v4z5V+QkUCLoNU4r1Jcb6S8nZVaC+Go4NUB4ouGgAlmpiaNyL?=
 =?us-ascii?Q?5eWjDGeOpymc06wwBHMc2SGpEdoY6A0JD/D0VUPY0LURxAQQEdBSRxWWd4q3?=
 =?us-ascii?Q?Hrte6H+zBiZjFnhsniRlG1iHSrk3Iq/Y36JethBA9icKl6uLEaV1L3z2SiVB?=
 =?us-ascii?Q?5Pd8gMSK7Z8e4euuiw+frgdZRtipXanKDCJw//ACBQ/bdlX2MVo33zH81xOB?=
 =?us-ascii?Q?a9yCAG5ye29K259kVuWUK+ZUvYperHivOppQxE+OVNd7mLbsRlmg945mUyFW?=
 =?us-ascii?Q?UA74IFUDbbceGCF4euXIX2JM6PFk9pT6JFjFetlkVJ5x0UX047xL5p7GxtO+?=
 =?us-ascii?Q?VD2h0Ji4XGxY4Vwj/o6un6/9MX4eQM11kMwbM9wkZiMmtj2yDPBTYaQ/w1XM?=
 =?us-ascii?Q?U75n4M1hnwKVjADS9mM10exn3uLwyPUZBVK+z2DFhRiZb9sIxajHeza0v3ao?=
 =?us-ascii?Q?b6EeeT3DDgzkuQUFnnU7wrT4QHi6Zm8dQz6NE2i3Af5/E56bOuV15wP7T42y?=
 =?us-ascii?Q?LAl2J2FJ8qXxUUkNF5bylu/Z9JhfvonEE3Irdlu3tuq9gOR71ygvQyXeoanV?=
 =?us-ascii?Q?yU4DWGuKXHGqco27wMxO3E0Ms+JCcDh0jtEOktm/q3DyygxsExFMudpeiUpK?=
 =?us-ascii?Q?WVH6PIKgWXFxUPL92mpHqAZK1w4uQ6D5w6bM8QjEE4QqpAtC1RYsv+fgQctA?=
 =?us-ascii?Q?WoTeLeDAQbrxmk4MJPlnCl66zLzvzrAZv6XqE6xouQp8IDvAlSKU9Ap5hZiH?=
 =?us-ascii?Q?n32pioAXmfLufvkQNF8TpAI/tql1HZTVS9/wDo1ztNsXN+g/SYFWchq+bGSw?=
 =?us-ascii?Q?t1EcrfMF/Q7B5mjctKoTOevNNUd0W6X+mUJktsCOGD6ziN/dGgwn/YO4CmSp?=
 =?us-ascii?Q?z6w22g5ct6cWa3F+/1ykwXrZU6t8EO+bgySvdniGDaulWu/5j9X5MScHfdOM?=
 =?us-ascii?Q?IairJ4V1FlBHwfWaLXlDzxfnTq8yoay1GoKI6z2qq/liqJPYwSrTANuip5B0?=
 =?us-ascii?Q?+gj4ZyVcm3rS3fYD/NI512ybn7FPe2Yo8XnZN+ouB5kYDk/imlBbqdj7kZIX?=
 =?us-ascii?Q?cINxEISDKNby4RCDqC03fIfII45NDtdEkes9y5lLG0l6sNf0kv8lk7a5dMBn?=
 =?us-ascii?Q?h7XoXql6tyvBGYwozjzx8WKzXgeVQwAcYo2yGBK8VTjhwTtDu2eYrdcMRGVf?=
 =?us-ascii?Q?O6KPsJyNBReiKKvIguqi0UUcS0eBZxa+SjFIjaRjz4QdQGf+sQc+MW7wTNNY?=
 =?us-ascii?Q?ew=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4874.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f5ce4a4-3496-46ee-784f-08da5e50a0cc
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2022 06:36:01.4183
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sOUu9awJzni7esaZ1ggFLnBLL9Q3PUiLJ5mw2ls49BEBN0OYNtvE/BLbo5lWJ1ujh62jjTuGJ/AWN64No2iXFzF/YAeCgbFPVGKh6Og+ApkM2XbUm6BibOklkpWbYmd/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5478
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > > > Convert the Atmel flexcom device tree bindings to json schema.
> > > >
> > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com=
>
> > > > ---
> > > > v3 -> v4:
> > > >  - Corrected format of enum used for compatible string.
> > > >
> > > > v2 -> v3:
> > > >  - used enum for compatible string.
> > > >  - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> > > >  - fixed dtschema errors.
> > > >
> > > > v1 -> v2:
> > > >  - Fix title.
> > > >
> > > >  .../bindings/mfd/atmel,flexcom.yaml           | 104 ++++++++++++++=
++++
> > > >  .../devicetree/bindings/mfd/atmel-flexcom.txt |  63 -----------
> > > >  2 files changed, 104 insertions(+), 63 deletions(-)
> > > >  create mode 100644
> > > Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> > > >  delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> > > flexcom.txt
> > > >
> > >
> > > Running 'make dtbs_check' with the schema in this patch gives the
> > > following warnings. Consider if they are expected or the schema is
> > > incorrect. These may not be new warnings.
> > >
> > > Note that it is not yet a requirement to have 0 warnings for dtbs_che=
ck.
> > > This will change in the future.
> > >
> > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > >
> > >
> > > flexcom@f0000000: spi@400:compatible:0: 'atmel,at91rm9200-spi' was
> > > expected
> > >         arch/arm/boot/dts/at91-sam9x60ek.dtb
> > >
> > > flexcom@f0000000: spi@400:compatible: ['microchip,sam9x60-spi',
> > > 'atmel,at91rm9200-spi'] is too long
> > >         arch/arm/boot/dts/at91-sam9x60ek.dtb
> >
> > These errors are expected because "microchip,sam9x60-spi" and
> "atmel,at91rm9200-spi"
> > are documented in Documentation/devicetree/bindings/spi/spi_atmel.txt.
> > which I added in description as
> > " description: See ../spi/spi_atmel.txt for details of SPI bindings."
>=20
> If that was still true, there would not be a warning because .txt files
> don't cause warnings. You've defined the SPI compatible here and that
> doesn't agree with the dts files. One of them is wrong.
>=20
> Normally, child nodes either just reference another schema or document
> everything locally. You've done a mixture which is not right. Presumably
> that was to avoid 'undocumented compatible' warnings. To fix that you
> either need to convert the SPI binding or don't use it in the example.
>=20
For now, I will remove the spi node from example and send my v6 patch serie=
s.
I will add it back once below patch is accepted:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.=
137099-1-sergiu.moga@microchip.com/
Please let me know your comments.=20

> Rob