Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp908136imw; Mon, 4 Jul 2022 23:45:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uvC0UZhLfNF9u63c0vU2dWtDPg5uVxzpwRXeOX+hAay4nx/XT1Lb8o5zvIaUd3oGK+tUeE X-Received: by 2002:a17:907:75d7:b0:72a:3de2:d29b with SMTP id jl23-20020a17090775d700b0072a3de2d29bmr31624746ejc.642.1657003535194; Mon, 04 Jul 2022 23:45:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657003535; cv=none; d=google.com; s=arc-20160816; b=htbAHM/JTGi/wqWtyqICEoYCQNinGMQv+bokv61wV4VQBFnOZCgk0U20vUN0GCH2cD omVhawVLkE0SqOm/7KJNkBLNY93SiYu6kjxQmM0hSt437fY29kZQJmIRQhfZYPrxAOFC nOWyWi8/algh6eQgz+v4YtY6IAvRFsiIia5ynkLj3PTTxfttK3sOc40XT120NjZIUIGI O6/9a6/UGoUVrpt0w2ngIC+/2BEygE8NOxbYROARLYiZkokCeHJtupx1ZnwQNItrQr5l GFtrLBB9xWDIRChM5TwBoorAxb46sVPwuJ42ZPhb5Ui9UAs7HLf929mbxRwXhR1jkRxC ZiwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=J2BxR/tYzT7Y40B83av/Kt3H4EieN+PKXbk78euHwNs=; b=Cwg5bH8Bykdz1r9/zXWOKqNslNsePKGiZNQQX8psq+ve/AC6L93fiuUhlG6QLl7XV2 C4Zd2ATcWNW+FR3ZQPvi+TtZmU8zV6Gi/WSTTpW3vAwN06VD6/3ZPlq0hGWfZhzlibu9 mw6aNtvy02o/AHBPp6zc1h/MldD2EXU7nDMhkoLQqDFCmFYV/IgZDTgiZLVJw4UWzSvv o0akSOuXNpNpSz2CmoDqeXt9XDMBIb5BRio5OmLASvh/TIj82DfkHjXY9MovBf/pxhi5 hmPlYp5OsknCGX42eIm4JF6jKj2H3mAbHdf+BWuIG2aZrDYLM8uKU42473IA8XdQtKpZ QY0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b10-20020a056402350a00b00435dd1a4021si48117101edd.626.2022.07.04.23.45.10; Mon, 04 Jul 2022 23:45:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbiGEG0a (ORCPT + 99 others); Tue, 5 Jul 2022 02:26:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229762AbiGEG0Y (ORCPT ); Tue, 5 Jul 2022 02:26:24 -0400 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAB25A1AB; Mon, 4 Jul 2022 23:26:23 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R531e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=mqaio@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VIQzUB7_1657002379; Received: from localhost(mailfrom:mqaio@linux.alibaba.com fp:SMTPD_---0VIQzUB7_1657002379) by smtp.aliyun-inc.com; Tue, 05 Jul 2022 14:26:19 +0800 From: Qiao Ma To: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, kuba@kernel.org, gustavoars@kernel.org, cai.huoqing@linux.dev, aviad.krawczyk@huawei.com, zhaochen6@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 3/3] net: hinic: fix bug that u64_stats_sync is not initialized Date: Tue, 5 Jul 2022 14:26:01 +0800 Message-Id: <7723937608e9f23b2a904615ae447beaf9f28586.1657001998.git.mqaio@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <0146c84b4161172e7a3d407a940593aa723496ea.1657001998.git.mqaio@linux.alibaba.com> References: <8cadab244a67bac6b69324de9264f4db61680896.1657001998.git.mqaio@linux.alibaba.com> <0146c84b4161172e7a3d407a940593aa723496ea.1657001998.git.mqaio@linux.alibaba.com> In-Reply-To: References: X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In get_drv_queue_stats(), the local variable {txq|rxq}_stats should be initialized first before calling into hinic_{rxq|txq}_get_stats(), this patch fixes it. Fixes: edd384f682cc ("net-next/hinic: Add ethtool and stats") Signed-off-by: Qiao Ma --- drivers/net/ethernet/huawei/hinic/hinic_ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c index 93192f58ac88..75e9711bd2ba 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c @@ -1371,6 +1371,9 @@ static void get_drv_queue_stats(struct hinic_dev *nic_dev, u64 *data) u16 i = 0, j = 0, qid = 0; char *p; + u64_stats_init(&txq_stats.syncp); + u64_stats_init(&rxq_stats.syncp); + for (qid = 0; qid < nic_dev->num_qps; qid++) { if (!nic_dev->txqs) break; -- 1.8.3.1