Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp959428imw; Tue, 5 Jul 2022 01:00:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tpsT0sW3vUcWdYWN7dC6lqzcQLfduAM1sre30UzQhJUvj/sN7dBpFZv2N9s54Mz/2wcuxo X-Received: by 2002:a17:907:62a6:b0:6ef:8118:d3e2 with SMTP id nd38-20020a17090762a600b006ef8118d3e2mr31462672ejc.605.1657008040865; Tue, 05 Jul 2022 01:00:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657008040; cv=none; d=google.com; s=arc-20160816; b=lPdSg0R69mellZdCEZ63nsa9h1i1b2n9zIPzHWiluZf44R8EcVxwMSVNurQRKIM804 lwictcgoSpQmJdve8lfxOA5Z0bYtBorDwIQLQUMUXEMKMZ4M+Kg+plETDn+qLZwfaBj9 Z+Gdz739Wx2XtJ0RQf5yIoX87u4lRbkPZnz/v+Xi4RsHWqjcpV6FpG0/GPU09nd70kxV +mk7tzm3Z5FkfDXYSbYxJv4om6buPJmfUbvGAH5XWGjlvm5f6f1qS+m6BdNAGJcGaaes /e+YVHSn4jPz/mi+ryITvs5tLVK7yym7jZGH3NkD5LjI7wxi39clOOC8IzWFCK6W6Ggn JCaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=/vepQl1vtemGKmutRdXSKWgV8bQAVH9vge5clbomKgo=; b=xn0Rywi/YIChEJDL26ZFzT7bKHKH/8Sw55cYupSM7bSFuxf3Yl/SBIfm36NVIPnoeC AiRljDHUwy4g7AxaV5rTiAWL9qhrQBN4zovby4qb000VhOSBLX9vR7/OC4QKQvnZyMPo /fK+v07Z4kDeYJwhQrupCVUQtO8eGREMWJmfDJjlBLYxFR5qczbyJ48aIzZQ242/D7cL Tf/GfuRjEbKMlp3GZH1JzoAnWWb+4q97v5JgePjNwxHsOZwKE2afCqVIg1lg2vxyG3pp HataoTznsJcnkoq+5W2pnshKnJjBgGX9dUQe0B1+RQcqA4sQVldIzY+Q61Ba+2eCVAza dbdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L1qnrz27; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v24-20020aa7d658000000b0043a7c1caadasi383170edr.298.2022.07.05.01.00.15; Tue, 05 Jul 2022 01:00:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L1qnrz27; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231341AbiGEHbq (ORCPT + 99 others); Tue, 5 Jul 2022 03:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbiGEHbo (ORCPT ); Tue, 5 Jul 2022 03:31:44 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D98012D17 for ; Tue, 5 Jul 2022 00:31:43 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id 9so10678043pgd.7 for ; Tue, 05 Jul 2022 00:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/vepQl1vtemGKmutRdXSKWgV8bQAVH9vge5clbomKgo=; b=L1qnrz27rkhQz4LHaw+WohXWeRTJ+FO92rTugSr1MelYv7j87eg3/A7ZCaYg2XxX+d zADRmzioXyqJ0QjPAbip43nNTnDmn/HTpK22EkosVd0GyggreKuIsjhtbypah0qiTXq5 6FoSsHQELRIY++2dBUqI0vutljIhHaj0HZCz08tQobbCgkXduvpzqovba++poXfRVj7Z kwtR39yD0mGEoRe4zOU4xF5DIMdd9DZFiJ4JSyZdyCol12T8koKE+Ff8UIEujkiWuceb ozz4urXKWXQZ+1p93ka/EEPSDvkfDyVv2vH5+Sjl0ntiURZntRzkR4RhnCScx0MeaJUM x9NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/vepQl1vtemGKmutRdXSKWgV8bQAVH9vge5clbomKgo=; b=hHgdVtqtsQZfYN66zEQTPIxkiR2vTeJYCliI8wcBrmxGjFia6tGZDp3A+VyhCawoig OXfEj5wUwkyHs6vX6b5E5AENKZAWe6vurdcjTRFSapNr4kIvernpNdqg+cPeF64ou8Pz ul5xviYA/yUJJfS6h6dK8edKX5SVTASIcmglzRp7ndxTnAmX31Y6bPIYEpSm9I0diFZZ n+HLaqnLxaqr6L6NUXxw41K5GyMqMYpKG5gDh6qkYST+0t0ObaZpVa+Nz8KFJBuT610X xwewGmCcCyW8ff2qtdxmYylsgiZR/Aj9drtTBK2R+9wsaEbf6bkOjwfSGTTjHb3DvQX+ nlSw== X-Gm-Message-State: AJIora/WDprMHH7Wl28q89CLDttYhum/30zlw3r0e529j4c7YnY0QXfk ukBXqyv58eR9RNGsAm92xJr4eg== X-Received: by 2002:a63:d94a:0:b0:412:6986:326e with SMTP id e10-20020a63d94a000000b004126986326emr3932902pgj.56.1657006302881; Tue, 05 Jul 2022 00:31:42 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([154.3.32.171]) by smtp.gmail.com with ESMTPSA id w18-20020a627b12000000b00527e026591esm12669211pfc.150.2022.07.05.00.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 00:31:42 -0700 (PDT) Date: Tue, 5 Jul 2022 15:31:38 +0800 From: Leo Yan To: Andy Gross , Bjorn Andersson , Georgi Djakov , Bryan O'Donoghue , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] interconnect: qcom: msm8939: Use icc_sync_state Message-ID: <20220705073138.GA180752@leoy-ThinkPad-X240s> References: <20220416012634.479617-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220416012634.479617-1-leo.yan@linaro.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Georgi, Bjorn, On Sat, Apr 16, 2022 at 09:26:34AM +0800, Leo Yan wrote: > It's fashion to use the icc_sync_state callback to notify the framework > when all consumers are probed, so that the bandwidth request doesn't > need to stay on maximum value. > > Do the same thing for msm8939 driver. Ping for this patch. This patch is needed for enabling ICC driver on msm8939, I verified it based on Bryan O'Donoghue's DT binding patches. Please see the branch which contains complete patches: https://git.linaro.org/people/leo.yan/linux.git/log/?h=v5.19-rc4%2bicc_sleep_clock_v2 Thanks, Leo > Signed-off-by: Leo Yan > --- > drivers/interconnect/qcom/msm8939.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/interconnect/qcom/msm8939.c b/drivers/interconnect/qcom/msm8939.c > index f9c2d7d3100d..ca5f611d33b0 100644 > --- a/drivers/interconnect/qcom/msm8939.c > +++ b/drivers/interconnect/qcom/msm8939.c > @@ -1423,6 +1423,7 @@ static struct platform_driver msm8939_noc_driver = { > .driver = { > .name = "qnoc-msm8939", > .of_match_table = msm8939_noc_of_match, > + .sync_state = icc_sync_state, > }, > }; > module_platform_driver(msm8939_noc_driver); > -- > 2.25.1 >