Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 05 Jul 2022 09:45:51 +0200
Message-ID: <87r130vw7k.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Tom Rix <trix@redhat.com>
Cc:     perex@perex.cz, tiwai@suse.com, vitalyr@opensource.cirrus.com,
        sbinding@opensource.cirrus.com, tanureal@opensource.cirrus.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/cs8409: change cs8409_fixups v.pins initializers to static
In-Reply-To: <20220704142836.636204-1-trix@redhat.com>
References: <20220704142836.636204-1-trix@redhat.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 04 Jul 2022 16:28:36 +0200,
Tom Rix wrote:
> 
> sparse reports
> sound/pci/hda/patch_cs8409-tables.c:79:25: warning: symbol 'cs8409_cs42l42_pincfgs_no_dmic' was not declared. Should it be static?
> 
> cs8409_cs42l42_pincfgs_no_dmic is only used by cs8409_fixups table as an
> initializer for the hda_fixup element v.pins.  Both are defined in the
> patch_cs8408-table.c file but only cs8409_fixups is used externally in
> patch_cs8409.c.  So cs8409_cs42l42_pincfgs_no_dmic should have a static
> storage class specifier.
> 
> The other v.pins initializers in cs8409_fixups table, though declared
> extern in patch_cs8409.h are also only used in patch_cs8409-tables.c.
> So change all the v.pins initializers to static.
> 
> Fixes: 9e7647b5070f ("ALSA: hda/cs8409: Move arrays of configuration to a new file")
> Signed-off-by: Tom Rix <trix@redhat.com>

Thanks, applied now.


Takashi