Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f6b46a29-0f65-9081-5228-a1028fea2bef@virtuozzo.com>
Date:   Tue, 5 Jul 2022 12:01:58 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v4 1/1] Create debugfs file with virtio balloon usage
 information
Content-Language: en-US
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     David Hildenbrand <david@redhat.com>,
        Jason Wang <jasowang@redhat.com>, kernel@openvz.org,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <20220705083638.29669-1-alexander.atanasov@virtuozzo.com>
 <20220705045912-mutt-send-email-mst@kernel.org>
From:   Alexander Atanasov <alexander.atanasov@virtuozzo.com>
In-Reply-To: <20220705045912-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VElyTDRsWTVmRTlxVTNLSnhTcnZlMVlmYjJiazZKR0gzbXNaMG5WVnAzL1BL?=
 =?utf-8?B?cTZoeldDWDg0UlZEYTlzbGF5VVZra0J2c1BtNWNBd3pHRWlNWCtwcWpxSGVK?=
 =?utf-8?B?UFMwa2tsYnU5SXNzcE1iT3dMOXB4MzBXSTZnVmZ5ckx5eGoxR1RkODl3U0c5?=
 =?utf-8?B?VFdkdFN3S0lJaG94K2RHbWY2MnRRTlExLzhrM1QrbEVPbm5qSVVIdjBGc1pv?=
 =?utf-8?B?YTdpeHVMRWRNQWJKMWhUanpVZk9oWjV2b3VwQk5ZM1RvbkVEbTRZM2RSRHlh?=
 =?utf-8?B?STlQWVRDem5ZR2hKSjlFTWRlZm1qRjFja1RhbWpzdWxyQVo4SlA2eWQ5RGZE?=
 =?utf-8?B?TGRQajJMeExCa1ZsN0tna25uZDc1S0g0N1hGTmdrMkF0UnhJbEZlbFVYemhv?=
 =?utf-8?B?d0ZhcUc1dCszQ3RsRW01Q2RCTms3dzEwWTJzNDZpdUxvblFIMkFya0x6c2JF?=
 =?utf-8?B?Q0UzS0Ivc3c0cnM5ODc0aldRd2JTVkx4a2lqK1dIWEdnRU1sQUQzY3lQQm1W?=
 =?utf-8?B?NGlPZWZXZ1l6UzdGZWJTdC9MOENhUFMxQURSaTBsNlpCaTh3K1BwUXRVZDN3?=
 =?utf-8?B?NkEydmhFMTVoL1ZpZmtZMEU5V0ZwZHU1TFlOQ0ZieHVMNk96Uk52aGd3Q2xp?=
 =?utf-8?B?cnhqVFdUWGZ2Um56ZGxHT250REFJSVF1aDVOalhPNVFuZ1B1QlZmdm9SU3Ir?=
 =?utf-8?B?WS81RmxwdURxREZZTnN0dmtBeHZRRnlwUUFIUk0xNkZLenhSUDNDZERhQzlx?=
 =?utf-8?B?U2YrVmorWXpRem9qWDRpWUJKSEQ4ZWxDRjNaZmh5aHRZeWRLSmxIN1dlaGNs?=
 =?utf-8?B?U09hcG5lYWpmSm10M3cvMlliNzJLUFRaakpadlRyKzlnT1BRQVpPa1NVblc5?=
 =?utf-8?B?aDQra0xOMm1LK2VkMFB1UXNtb0lVclVzU3U5cWZUT2w5b29URVcvVEJxdFBu?=
 =?utf-8?B?TmhmNnJ0dEpIUkp0cEQwUWFGZjlIaWZTdHdSWHVTdi9YYjdVR1ZuYmhiSGoz?=
 =?utf-8?B?Z1dwT3FhOWlWOHFSNlNUL3JGZW9US05WY2dUdWlzaFpWRFlETVN0cVRXdHNz?=
 =?utf-8?B?elljNXkvWEVxdEZjVUFTV0JrcGZTOWJFTFkrZ2JtcSs1RXNKRC9IUjlCUmtF?=
 =?utf-8?B?d0txWFpCSFIzY2VEM0FLSG9VV0Q1YjVTdzVhVzk1Sjl4UEdRZDRRWTNMYVZY?=
 =?utf-8?B?Q1cxcHdrMHIxMmJlc2diVGM5NDZmMlo4VUIrd3BWVUxQMm43UVdlMzloblJs?=
 =?utf-8?B?ZUVzLzNyWjhsYXVsZEN0b2IzK3BmeVBXMUlINXZrTWxvL1lGNUoyUi9UMlRF?=
 =?utf-8?B?dVdnblNydEhWc2RsMWRxTXBqU2pHSmUzZE84MTN0bjFEaFBEb1R5Q2JsZ01X?=
 =?utf-8?B?TWVLYTRQZEJUVkQwT2NYcE9WdFk5dFhkbEpKSHVwWEV4SCszRTdUanhSMSt2?=
 =?utf-8?B?NmRkZjU4VmJEYnUxWmJPdHo0TWdoSFlyWXNDTGVjQWhQU3hScFh4WGhneUJL?=
 =?utf-8?B?V0JNYnlRUFZNakRsUjdLbXhybTR0clZ6UmJtZGoyWXBRa0Z4SFUvRW1ra2pX?=
 =?utf-8?B?ZXNZNGcrS05rMWVxcGZUanc2MTByK2pjRkp2amszV0tBaVRhOTFDcTZJK2Nv?=
 =?utf-8?B?MWFvY0k2Y3JmMENBSTFneFh0RHZvS0Y5Mk1ya3VIalJuS0lGQ1BvZnpDeGpz?=
 =?utf-8?B?MDJLWW9qb0pXVWt5a3RQR3VoRUJUMUJhc0QvTFV6YU9wYWJMM29kbUo4YTRT?=
 =?utf-8?B?OFl6ek5aSEhxakdreUVCLzhFL0ZUZGk5ZGxYZmM4M2JVUmM3S2Y5VStOMzg2?=
 =?utf-8?B?SGROcUhTS09TcEJWS2Z0cnNRTUZkend1dmhlbnVZbzdZNm5UZGtEWE4vUTdn?=
 =?utf-8?B?Z1pPY20xdS96d0tuWVM1UW9xRThpbDlzbU1ueGxMaDhrQmZ3N3dZSnlrbGhI?=
 =?utf-8?B?WWtha0RqRUNzWUZVR0Z6VUo5Mk1uSTh6SkVBMEUvTkJjQWdNNHVpbmh4SHdu?=
 =?utf-8?B?U3hTeks5dzhnbXlVYmFLWTV1ZU5uRDdwblQ3eFhYb3NUOTlHc0U4SFliWUsv?=
 =?utf-8?B?bFhtUmJ3T2c5NW82MjRNeDd2ZDNaK2xlZUdKM1Y4Nk9KN0pVWWtuNng1WDI3?=
 =?utf-8?B?S1licjc0VmxaYlVGSUtYNjRYZUV1VVd6MUpaNHlXQmJKMll0ZzVOUklNM2JN?=
 =?utf-8?B?OHc9PQ==?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6006916-26f2-4770-b33a-08da5e650554
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4765.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 09:02:00.1897
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jkB87yS4IkSen4Rlny1waaxp79homTa6shnGAxdnMtIQ1PwU1mSdhSRP8lwdOvGdYVTyTYifwnYH4rBVkbhlw85I4mawFazbF572e4/z20bURYmoIwhb1a7NoKa8cWQf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6141
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On 05/07/2022 11:59, Michael S. Tsirkin wrote:
> On Tue, Jul 05, 2022 at 08:36:37AM +0000, Alexander Atanasov wrote:
>> Allow the guest to know how much it is ballooned by the host.
>> It is useful when debugging out of memory conditions.
>>
>> When host gets back memory from the guest it is accounted
>> as used memory in the guest but the guest have no way to know
>> how much it is actually ballooned.
>>
>> Signed-off-by: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
>> ---
>>   drivers/virtio/virtio_balloon.c     | 77 +++++++++++++++++++++++++++++
>>   include/uapi/linux/virtio_balloon.h |  1 +
>>   2 files changed, 78 insertions(+)
>>
>> V2:
>>   - fixed coding style
>>   - removed pretty print
>> V3:
>>   - removed dublicate of features
>>   - comment about balooned_pages more clear
>>   - convert host pages to balloon pages
>> V4:
>>   - added a define for BALLOON_PAGE_SIZE to make things clear
>>
>> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
>> index b9737da6c4dd..dc4ad584b947 100644
>> --- a/drivers/virtio/virtio_balloon.c
>> +++ b/drivers/virtio/virtio_balloon.c
>> @@ -10,6 +10,7 @@
>>   #include <linux/virtio_balloon.h>
>>   #include <linux/swap.h>
>>   #include <linux/workqueue.h>
>> +#include <linux/debugfs.h>
>>   #include <linux/delay.h>
>>   #include <linux/slab.h>
>>   #include <linux/module.h>
>> @@ -731,6 +732,77 @@ static void report_free_page_func(struct work_struct *work)
>>   	}
>>   }
>>   
>> +/*
>> + * DEBUGFS Interface
>> + */
>> +#ifdef CONFIG_DEBUG_FS
>> +
>> +#define guest_to_balloon_pages(i) ((i)*VIRTIO_BALLOON_PAGES_PER_PAGE)
>> +/**
>> + * virtio_balloon_debug_show - shows statistics of balloon operations.
>> + * @f: pointer to the &struct seq_file.
>> + * @offset: ignored.
>> + *
>> + * Provides the statistics that can be accessed in virtio-balloon in the debugfs.
>> + *
>> + * Return: zero on success or an error code.
>> + */
>> +
>> +static int virtio_balloon_debug_show(struct seq_file *f, void *offset)
>> +{
>> +	struct virtio_balloon *b = f->private;
>> +	u32 num_pages;
>> +	struct sysinfo i;
>> +
>> +	si_meminfo(&i);
>> +
>> +	seq_printf(f, "%-22s: %d\n", "page_size", VIRTIO_BALLOON_PAGE_SIZE);
>> +
>> +	virtio_cread_le(b->vdev, struct virtio_balloon_config, actual,
>> +			&num_pages);
>> +	/*
>> +	 * Pages allocated by host from the guest memory.
>> +	 * Host inflates the balloon to get more memory.
>> +	 * Guest needs to deflate the balloon to get more memory.
>> +	 */
>> +	seq_printf(f, "%-22s: %u\n", "ballooned_pages", num_pages);
>> +
>> +	/* Total Memory for the guest from host */
>> +	seq_printf(f, "%-22s: %lu\n", "total_pages",
>> +			guest_to_balloon_pages(i.totalram));
>> +
>> +	/* Current memory for the guest */
>> +	seq_printf(f, "%-22s: %lu\n", "current_pages",
>> +			guest_to_balloon_pages(i.totalram) - num_pages);
>> +
>> +	return 0;
>> +}
>> +
>> +DEFINE_SHOW_ATTRIBUTE(virtio_balloon_debug);
>> +
>> +static void  virtio_balloon_debugfs_init(struct virtio_balloon *b)
>> +{
>> +	debugfs_create_file("virtio-balloon", 0444, NULL, b,
>> +			    &virtio_balloon_debug_fops);
>> +}
>> +
>> +static void  virtio_balloon_debugfs_exit(struct virtio_balloon *b)
>> +{
>> +	debugfs_remove(debugfs_lookup("virtio-balloon", NULL));
>> +}
>> +
>> +#else
>> +
>> +static inline void virtio_balloon_debugfs_init(struct virtio_balloon *b)
>> +{
>> +}
>> +
>> +static inline void virtio_balloon_debugfs_exit(struct virtio_balloon *b)
>> +{
>> +}
>> +
>> +#endif	/* CONFIG_DEBUG_FS */
>> +
>>   #ifdef CONFIG_BALLOON_COMPACTION
>>   /*
>>    * virtballoon_migratepage - perform the balloon page migration on behalf of
>> @@ -1019,6 +1091,9 @@ static int virtballoon_probe(struct virtio_device *vdev)
>>   
>>   	if (towards_target(vb))
>>   		virtballoon_changed(vdev);
>> +
>> +	virtio_balloon_debugfs_init(vb);
>> +
>>   	return 0;
>>   
>>   out_unregister_oom:
>> @@ -1065,6 +1140,8 @@ static void virtballoon_remove(struct virtio_device *vdev)
>>   {
>>   	struct virtio_balloon *vb = vdev->priv;
>>   
>> +	virtio_balloon_debugfs_exit(vb);
>> +
>>   	if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_REPORTING))
>>   		page_reporting_unregister(&vb->pr_dev_info);
>>   	if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_DEFLATE_ON_OOM))
>> diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h
>> index ddaa45e723c4..f3ff7c4e5884 100644
>> --- a/include/uapi/linux/virtio_balloon.h
>> +++ b/include/uapi/linux/virtio_balloon.h
>> @@ -40,6 +40,7 @@
>>   
>>   /* Size of a PFN in the balloon interface. */
>>   #define VIRTIO_BALLOON_PFN_SHIFT 12
>> +#define VIRTIO_BALLOON_PAGE_SIZE (1<<VIRTIO_BALLOON_PFN_SHIFT)
>>   #define VIRTIO_BALLOON_CMD_ID_STOP	0
>>   #define VIRTIO_BALLOON_CMD_ID_DONE	1
> Did you run checkpatch on this?


Sure, i did:

scripts/checkpatch.pl 
../outgoing/v4-0001-Create-debugfs-file-with-virtio-balloon-usage-inf.patch
total: 0 errors, 0 warnings, 108 lines checked

../outgoing/v4-0001-Create-debugfs-file-with-virtio-balloon-usage-inf.patch 
has no obvious style problems and is ready for submission.

-- 
Regards,
Alexander Atanasov