Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Jul 2022 13:53:24 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Hans S <schultz.hans@gmail.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Hans Schultz <schultz.hans+netdev@gmail.com>,
        linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/1] net: bridge: ensure that link-local
 traffic cannot unlock a locked port
Message-ID: <YsQYJElDK8DBHYz8@shredder>
References: <Yr2LFI1dx6Oc7QBo@shredder>
 <CAKUejP6LTFuw7d_1C18VvxXDuYaboD-PvSkk_ANSFjjfhyDGkg@mail.gmail.com>
 <Yr778K/7L7Wqwws2@shredder>
 <CAKUejP5w0Dn8y9gyDryNYy7LOUytqZsG+qqqC8JhRcvyC13=hQ@mail.gmail.com>
 <Yr8oPba83rpJE3GV@shredder>
 <CAKUejP4_05E0hfFp-ceXLgPuid=MwrAoHyQ-nYE3qx3Tisb4uA@mail.gmail.com>
 <YsE+hreRa0REAG3g@shredder>
 <CAKUejP4H4yKu6LaLUUUWypt7EPuYDK-5UdUDHPF8F2U5hGnzOQ@mail.gmail.com>
 <YsLILMpLI3alAj+1@shredder>
 <CAKUejP5=eNyAso=MW2nb2o=OKMaysmWUJ-zqLcerPg6EzsQVYQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKUejP5=eNyAso=MW2nb2o=OKMaysmWUJ-zqLcerPg6EzsQVYQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZryG6fiRt66xlCvk9PO1OlcwSG4P7ZU3hcHmbZlhXoD18ky3fJatdl5jxRTI?=
 =?us-ascii?Q?/1XcBviQ7LhcE4kmrvAeYpn85rZ+dbsDQuytD/Jt1xPFA+WYiZqz4QkpxLz4?=
 =?us-ascii?Q?iEnWGpHTY748GXysDdEJFj0i86UQgrUmsdjvIhj07N48rmWBLepsnEsMW1+Q?=
 =?us-ascii?Q?JBoxlMUiQ6w6huwK0lzw0/O111ocIHzk9Xo2NB1iyJD63BYiLkZFXzCyhgPZ?=
 =?us-ascii?Q?cG8dN/g/pgjf70dyObcpudzsi5KwuOj5fDNUNowSusXBmOVg3nc4en5tbZAi?=
 =?us-ascii?Q?r9+a6MJTti/HQLDuOBVo+DLd+ovF4Y/LX95ZfScHRef3VvFaDWP4h+s5nt2F?=
 =?us-ascii?Q?ITZKOWg73FvOrvpwVaXjLM3o488CUGy3AqYjjIXrU8bqDLUWhKUTC/ausM04?=
 =?us-ascii?Q?/mwkSUPzZpldpj56fO9G3JFBNvlRNSiv+T3pXmZTAEb8p1GA83ZX1KMJ8HQS?=
 =?us-ascii?Q?ayt/YXCn7DygkGHEG3Eb8gBKqHTGU3jl05K+5K2HeyldFf8nXwkmogAbY0jE?=
 =?us-ascii?Q?TlCfRl3kmj+BaLHzPGaGtqR1SrSasCTKEknGNBIoTCgWSIqeroQeK93bQ3ci?=
 =?us-ascii?Q?YJKfVMEchKdsMXEM/zvx5MRjdKxZe3uLRsMRyhoDy8sMjCziBguiI2kCWVxf?=
 =?us-ascii?Q?I8p4QFEv1GWXL4kwlJ3TX07XV9YrLdHv0hfYe5NbVn/Y5kLrOaSkZGbXkcLW?=
 =?us-ascii?Q?PzYF3aLcsDnsQo0rSCOGiujPtNPoQd4tw/09SvfDuT45rWlQvkOBOz/6ZqUp?=
 =?us-ascii?Q?oFn4zb3HArtYxNcah678lHkdwIjVJ6ic8SNYEemjAHqvLFQsIcumrq/oWPgp?=
 =?us-ascii?Q?CgeS1zZi7dIN+2dkxkNNbYO704WWD4om75t0G1IQXkK+6T7rWF6tlpVUl2ya?=
 =?us-ascii?Q?znMOg4wJLhDhO88uovfbjzXY7oF7DkmYCr5D/kbx77I58nueCYLdt0JBEoYU?=
 =?us-ascii?Q?6eaLqE8PnKeiBaneiF/iTUfehnUPdiqkTMpw5W7jrNuqt+QNSepZ3jNes9Ea?=
 =?us-ascii?Q?QQAsX+ZClAJibby2aGq7yaBvbTrogC0K9VeMSajcstMSqjCBPfNVrPw1fYGd?=
 =?us-ascii?Q?MWz1OOmMtB6wF3m6c3vkf3jofT9+asdk/W92yZDAtPFI4qJxsT0gqr/ZJP71?=
 =?us-ascii?Q?rZXSO/WFy+slmlPTaIGZI1YgOFKe32Xamrz/d+oJQL5eqg6JpSR0Zmm9zoZB?=
 =?us-ascii?Q?WCPONQHgxofsLoy5eeojxr4ieB5i4FXDyP7pMqO4YoE2i9iS+VFdpdpqxnF4?=
 =?us-ascii?Q?vT/rqXoi2DIV6fnCkm5IL5LcfTufYXC2qun5omFecV2xo9/CYTw2YskeRT+l?=
 =?us-ascii?Q?yVErXwZ/Kz4xOhfJYZJ2M4TCXIY73MGpBPsSC1kaqbb0rlEdB5X02oyyCb/N?=
 =?us-ascii?Q?Ngc2/iutwfFzjlN96UUHGpfSqXwI6qFzqG5DNxTida9U9A04gBjCa8oq86oL?=
 =?us-ascii?Q?wBJv3g/NqLLTptU+zmJLcc5AA5zbxZW7KXA/hpL+7aOSxZnzucM6aO6niIu4?=
 =?us-ascii?Q?Bqf9eKAdrZMPR/KFHnj+vYgIdzWY23NTSyGDvlZ9w6Ielo4wvb05cE/ER8Ba?=
 =?us-ascii?Q?iJV99FG6eqEpjG0WCfhGhtzbhph9UuxcxqR2Z1W4?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c8230df-bf3d-4dfe-72e2-08da5e7498c6
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 10:53:30.2454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rgf2Nuf4PqWKNfiD6LAAZsstYbx3XaL0FMqb9XCcVDjs0Rq88Jqs+8h7eZOWvxt3icf+/uFlcY3X9pXwZE9XYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4189
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 04, 2022 at 04:36:12PM +0200, Hans S wrote:
> On Mon, Jul 4, 2022 at 1:00 PM Ido Schimmel <idosch@nvidia.com> wrote:
> >
> > On Mon, Jul 04, 2022 at 09:54:31AM +0200, Hans S wrote:
> > > >
> > > > IIUC, with mv88e6xxx, when the port is locked and learning is disabled:
> > > >
> > > > 1. You do not get miss violation interrupts. Meaning, you can't report
> > > > 'locked' entries to the bridge driver.
> > > >
> > > > 2. You do not get aged-out interrupts. Meaning, you can't tell the
> > > > bridge driver to remove aged-out entries.
> > > >
> > > > My point is that this should happen regardless if learning is enabled on
> > > > the bridge driver or not. Just make sure it is always enabled in
> > > > mv88e6xxx when the port is locked. Learning in the bridge driver itself
> > > > can be off, thereby eliminating the need to disable learning from
> > > > link-local packets.
> > >
> > > So you suggest that we enable learning in the driver when locking the
> > > port and document that learning should be turned off from user space
> > > before locking the port?
> >
> > Yes. Ideally, the bridge driver would reject configurations where
> > learning is enabled and the port is locked, but it might be too late for
> > that. It would be good to add a note in the man page that learning
> > should be disabled when the port is locked to avoid "unlocking" the port
> > by accident.
> 
> Well you cannot unlock the port by either enabling or disabling
> learning after the port is locked, but Mac-Auth and refreshing might
> not work. I clarify just so that no-one gets confused.

I was referring to the fact that if learning is enabled, a host can
populate the FDB with whatever MAC it wants by crafting a link-local
packet with this MAC as SA. Subsequent packets with this MAC as SA will
pass the locking check in the bridge driver.

> I can do so that the driver returns -EINVAL if learning is on when
> locking the port, but that would of course only be for mv88e6xxx...

Working around this issue in the mv88e6xxx driver is the correct thing
to do, IMO. We avoid leaking this implementation detail (i.e., forcing
learning to be enabled) to user space, which in turn helps us avoid
working around issues created by it (this patch, for example).