Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Jul 2022 13:16:21 +0200
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Li zeming <zeming@nfschina.com>
Cc:     w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
        speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] accessibility/speakup/speakup_acnt: Add header file
 macro definition
Message-ID: <20220705111621.smcxnfx45ai7vixy@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Li zeming <zeming@nfschina.com>, w.d.hubbs@gmail.com,
        chris@the-brannons.com, kirk@reisers.ca, speakup@linux-speakup.org,
        linux-kernel@vger.kernel.org
References: <20220705101955.27337-1-zeming@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220705101955.27337-1-zeming@nfschina.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Hello,

Li zeming, le mar. 05 juil. 2022 18:19:55 +0800, a ecrit:
> I think the header file could avoid redefinition errors.
>  at compile time by adding macro definitions.

Redefining a macro to the same value is not a problem, but better have it
indeed.

> Signed-off-by: Li zeming <zeming@nfschina.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Could you also patch speakup_dtlk.h the same way? Thanks.

Samuel

> ---
>  drivers/accessibility/speakup/speakup_acnt.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/accessibility/speakup/speakup_acnt.h b/drivers/accessibility/speakup/speakup_acnt.h
> index cffa938ae580..cea05d770f6d 100644
> --- a/drivers/accessibility/speakup/speakup_acnt.h
> +++ b/drivers/accessibility/speakup/speakup_acnt.h
> @@ -1,5 +1,7 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
>  /* speakup_acntpc.h - header file for speakups Accent-PC driver. */
> +#ifndef _SPEAKUP_ACNT_H
> +#define _SPEAKUP_ACNT_H
>  
>  #define SYNTH_IO_EXTENT	0x02
>  
> @@ -17,3 +19,4 @@
>  #define SYNTH_FULL	'F' /* synth is full. */
>  #define SYNTH_ALMOST_EMPTY 'M' /* synth has less than 2 seconds of text left */
>  #define SYNTH_SPEAKING	's' /* synth is speaking and has a fare way to go */
> +#endif
> -- 
> 2.18.2
>