Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0bbf075f-ebd7-321f-4692-5bb5da0d638d@amd.com>
Date:   Tue, 5 Jul 2022 13:21:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH RESEND V2 1/3] drm/amdgpu: fix checkpatch warnings
Content-Language: en-US
To:     Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc:     Sunil-kumar.Dommati@amd.com, David Airlie <airlied@linux.ie>,
        Basavaraj.Hiregoudar@amd.com, "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        open list <linux-kernel@vger.kernel.org>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>,
        zhuning@everest-semi.com,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
References: <20220704135421.1215140-1-Vijendar.Mukunda@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220704135421.1215140-1-Vijendar.Mukunda@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzhWb25mRWRvUzgybmZWa1lHZXhCdmNrek5PY2NHd2gxNEVFZEJRd1o1ZHlT?=
 =?utf-8?B?Z3hhLzNocU9kZG5GZUUzbFhnQ3BZZ3ptTFZybC9CN0YvVzFvMUt3MVMwcDJX?=
 =?utf-8?B?SENJY2FGUFVydXFoVSt4ZGYyMUdYUWljeHo0eG1oNENaWEtLY0ZPUFlhWmM5?=
 =?utf-8?B?SERnK2ZlNDNCa3kxSm9ZUkZwZGJlTDhQYmhpK051cjdmRmoyY3ZMZ1E3ZUt4?=
 =?utf-8?B?TVNDa3pKUVB6ck5EcmpRWmM1NzdzazlQNVhmMWc3L2orc094L2YyZlkyZHNR?=
 =?utf-8?B?VVVXcTQzMkc2cWx3L3pYb20xaTBvaEFTd0lEVGFjUjd0RmdJTTJJc1g0aGkr?=
 =?utf-8?B?UDA4ZU5POENtQ1ljQVppWGNWOUszNXhPVW43RFNGWHFtWnE0Vkxma3VoQks0?=
 =?utf-8?B?Umx4YVhUVEtJYjh3MkdjbGxUSGU0RVlVdlROMlRBUlI1RnRrN3VSNW1LUEts?=
 =?utf-8?B?TFhiYVBqSURIUjBKSk5wM09rWmJWcDZVbHBaSlNkeGU2eU1aUlRFeitOZHdP?=
 =?utf-8?B?MzBZMFhqZDgxYWVxYk9GRDlBcEx6UFpTbnI3dUFaTHM0cjdTL21ocDBoRFFt?=
 =?utf-8?B?b3pXaUxRcTNuWnA0ZlVlekNESXN1K1R6c0dzY1l3WGZPcVVZbk1mRnRZSGox?=
 =?utf-8?B?UlVWK3Y2ajFQZHFVdzc3b294cmgrM3RzL1RSRU0yaGZpK3pWWjI0bVpKZHF2?=
 =?utf-8?B?YTQ1UHVyRXdneTNmNW50MGdDUnhiU3B5dlpKZjRQdyt6ZDY1MXBoc1ByR2x3?=
 =?utf-8?B?YTZVZVlER1RNNFdDVjdZK3JxUnJKbXJSaVRGRGUvL2FnWUhMTVNFL0g0WW8v?=
 =?utf-8?B?alkxaTZXd1lYTm0zS1laRmJPYkpBZ2lYZjY5VS8zcndTSDJ1eWZpSEZYaG5U?=
 =?utf-8?B?a1oxUXNZa0ZjQ0EwejV2eGxsTmFyS0tQZ0U2L2NKZ2YyaFZPSTlXT3NOekl1?=
 =?utf-8?B?c0ZvNUREZDBKYk1TelRKdDdyTzlqOEE5N1BwSEs4QnBXbTJ1WjdST1hMbTl4?=
 =?utf-8?B?VTlrbWNnanNwS1FjZlQ4NkFUblBhdndxSTZkcU5nUHpxTjZZdGY3NFhYaDkw?=
 =?utf-8?B?VWNvRmxHNTBkMTBuR1ZLK1M4djVsNlk1QVZPRGo5MWVuRDYzL3pUK2hlUkpI?=
 =?utf-8?B?MFZWZW9wTHB0dDNhRlRsZGd4Zlp4ZEVuemdYbFNUQS9hN0RyMzhrazF1WnA1?=
 =?utf-8?B?bFpvSWdBMlpTYnR2LytDQ2xGYmV0Y0RsVHJBbEExc2lJZUQwTkdTWmthVmRh?=
 =?utf-8?B?N0RJSTdxU09DUm9nblk2VDR0UnZ4NStscjJMdHpQeXVFemNLcjB5UEZBTFE0?=
 =?utf-8?B?M056S0NuK1JEWitOR1I5cmF6M3g2NFEyb2kxcjJQY1FQaDVVUkJmT2RlZWFJ?=
 =?utf-8?B?N21WRFdvMXRES241SFo0WXFKT1p0QzhHaXhPMlBDSVBPSlJvQ2lITzltaWI4?=
 =?utf-8?B?YlZqdHpPdjl5UElRRWFCQ3ZhQzVBNWpYbGFEeGtsL0o3NjRmMk1hUUNXZk5S?=
 =?utf-8?B?OUVLT3FUNzlTTTd2Uk9EdTRqMU5CelRBaEM5ZkIzM3VDMjBMMVFvclo1NVp0?=
 =?utf-8?B?Um90YkN0TVJDd3NzMXBSdW9JSWZXWW90UEJ3N2MrU1N4cVluRGRSbGRWc0R1?=
 =?utf-8?B?c3NNMU9ySW9WS0FvRmlRNHdKdWlhTkZnNGdabEtKeGN5KzRnYytwTW1tQk9C?=
 =?utf-8?B?NkRkR1IvTEIyQUtucUYvaEU3M1Fhd1IvUllxeVJKS2ZpMS9wZFU3dE80MFVo?=
 =?utf-8?B?YjlmOWs3MFRhRTlpTFQrR3NadjVkQlJvRmlJUnpPUis1czkyOGJ5ZEJCMFZl?=
 =?utf-8?B?WDBKT2o2dXJidTBIVEdTYlhrcEVhdEVUZmt4c29FaDhxNmxzdVdiY2VBWnVk?=
 =?utf-8?B?UWYvZElSVEVtSlFDeC9wTGJ2M2l0RW44L25iRkY5UzUxSTV3RTFmYVJ3ZFNH?=
 =?utf-8?B?dWlWZVN3UWtJRlJDVmJDdmZ3NnpVRm85aE9haW1KdmNOdk1CMTlMU2toWlBC?=
 =?utf-8?B?UmZGVE55V0xCNncyWHZNYzZBNlNISTFSS0l0TEljWC9sdVRQVk1naEhtdTds?=
 =?utf-8?B?N3J5NnltU29tbi9KVytxOENyeXMxMjVoSHhXOHYrZkQ4aWcvWU5wU3l3RVQ1?=
 =?utf-8?Q?pK3f5iFGy9AGsF3Hnp/mlYrUo?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44be45a3-557d-4cb1-ad01-08da5e78814e
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 11:21:28.7506
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GJGp5enHju2+oh6QbzeItigAp7nmVc3hnDGhQW5cc1v/EDHkV361O00KBqLqL0Hd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4004
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 04.07.22 um 15:54 schrieb Vijendar Mukunda:
> From: vijendar <vijendar.mukunda@amd.com>
>
> Fixed below checkpatch warnings and errors
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL could be written "apd"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:150: CHECK: Comparison to NULL could be written "apd"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:196: CHECK: Prefer kernel type 'u64' over 'uint64_t'
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:224: CHECK: Please don't use multiple blank lines
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:226: CHECK: Comparison to NULL could be written "!adev->acp.acp_genpd"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:233: CHECK: Please don't use multiple blank lines
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:239: CHECK: Alignment should match open parenthesis
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:241: CHECK: Comparison to NULL could be written "!adev->acp.acp_cell"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:247: CHECK: Comparison to NULL could be written "!adev->acp.acp_res"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:253: CHECK: Comparison to NULL could be written "!i2s_pdata"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:350: CHECK: Alignment should match open parenthesis
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:550: ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> changes since v1:
>      Modified commit label as drm/amdgpu
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 27 +++++++++----------------
>   1 file changed, 10 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
> index cc9c9f8b23b2..ba1605ff521f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
> @@ -128,7 +128,7 @@ static int acp_poweroff(struct generic_pm_domain *genpd)
>   	struct amdgpu_device *adev;
>   
>   	apd = container_of(genpd, struct acp_pm_domain, gpd);
> -	if (apd != NULL) {
> +	if (apd) {

Well that's still not correct. The variable apd is compute by an upcast 
of the genpd parameter.

Since that upcast never returns a NULL value (gpd is not the first 
member of the structure) this whole check is completely nonsense.

I strongly suggest to just remove most of those NULL checks.

Only the ones directly after memory allocation really make sense.

Regards,
Christian.

>   		adev = apd->adev;
>   	/* call smu to POWER GATE ACP block
>   	 * smu will
> @@ -147,7 +147,7 @@ static int acp_poweron(struct generic_pm_domain *genpd)
>   	struct amdgpu_device *adev;
>   
>   	apd = container_of(genpd, struct acp_pm_domain, gpd);
> -	if (apd != NULL) {
> +	if (apd) {
>   		adev = apd->adev;
>   	/* call smu to UNGATE ACP block
>   	 * smu will
> @@ -193,7 +193,7 @@ static int acp_genpd_remove_device(struct device *dev, void *data)
>   static int acp_hw_init(void *handle)
>   {
>   	int r;
> -	uint64_t acp_base;
> +	u64 acp_base;
>   	u32 val = 0;
>   	u32 count = 0;
>   	struct i2s_platform_data *i2s_pdata = NULL;
> @@ -220,37 +220,32 @@ static int acp_hw_init(void *handle)
>   		return -EINVAL;
>   
>   	acp_base = adev->rmmio_base;
> -
> -
>   	adev->acp.acp_genpd = kzalloc(sizeof(struct acp_pm_domain), GFP_KERNEL);
> -	if (adev->acp.acp_genpd == NULL)
> +	if (!adev->acp.acp_genpd)
>   		return -ENOMEM;
>   
>   	adev->acp.acp_genpd->gpd.name = "ACP_AUDIO";
>   	adev->acp.acp_genpd->gpd.power_off = acp_poweroff;
>   	adev->acp.acp_genpd->gpd.power_on = acp_poweron;
> -
> -
>   	adev->acp.acp_genpd->adev = adev;
>   
>   	pm_genpd_init(&adev->acp.acp_genpd->gpd, NULL, false);
>   
> -	adev->acp.acp_cell = kcalloc(ACP_DEVS, sizeof(struct mfd_cell),
> -							GFP_KERNEL);
> +	adev->acp.acp_cell = kcalloc(ACP_DEVS, sizeof(struct mfd_cell), GFP_KERNEL);
>   
> -	if (adev->acp.acp_cell == NULL) {
> +	if (!adev->acp.acp_cell) {
>   		r = -ENOMEM;
>   		goto failure;
>   	}
>   
>   	adev->acp.acp_res = kcalloc(5, sizeof(struct resource), GFP_KERNEL);
> -	if (adev->acp.acp_res == NULL) {
> +	if (!adev->acp.acp_res) {
>   		r = -ENOMEM;
>   		goto failure;
>   	}
>   
>   	i2s_pdata = kcalloc(3, sizeof(struct i2s_platform_data), GFP_KERNEL);
> -	if (i2s_pdata == NULL) {
> +	if (!i2s_pdata) {
>   		r = -ENOMEM;
>   		goto failure;
>   	}
> @@ -346,8 +341,7 @@ static int acp_hw_init(void *handle)
>   	adev->acp.acp_cell[3].platform_data = &i2s_pdata[2];
>   	adev->acp.acp_cell[3].pdata_size = sizeof(struct i2s_platform_data);
>   
> -	r = mfd_add_hotplug_devices(adev->acp.parent, adev->acp.acp_cell,
> -								ACP_DEVS);
> +	r = mfd_add_hotplug_devices(adev->acp.parent, adev->acp.acp_cell, ACP_DEVS);
>   	if (r)
>   		goto failure;
>   
> @@ -546,8 +540,7 @@ static const struct amd_ip_funcs acp_ip_funcs = {
>   	.set_powergating_state = acp_set_powergating_state,
>   };
>   
> -const struct amdgpu_ip_block_version acp_ip_block =
> -{
> +const struct amdgpu_ip_block_version acp_ip_block = {
>   	.type = AMD_IP_BLOCK_TYPE_ACP,
>   	.major = 2,
>   	.minor = 2,