Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c2c1cf0c-9462-9ba5-a297-70d13a063de1@linaro.org>
Date:   Tue, 5 Jul 2022 13:39:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 01/40] dt-bindings: input: gpio-keys: enforce node
 names to match all properties
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     soc@kernel.org, linux-kernel@vger.kernel.org,
        Olof Johansson <olof@lixom.net>, devicetree@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh@kernel.org>, arm@kernel.org,
        linux-input@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
References: <20220616005224.18391-1-krzysztof.kozlowski@linaro.org>
 <20220616005333.18491-1-krzysztof.kozlowski@linaro.org>
 <cab6fd96-4b8e-42a3-4dce-db63656df92c@linaro.org>
In-Reply-To: <cab6fd96-4b8e-42a3-4dce-db63656df92c@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/06/2022 10:17, Krzysztof Kozlowski wrote:
> On 16/06/2022 02:52, Krzysztof Kozlowski wrote:
>> The gpio-keys DT schema matches all properties with a wide pattern and
>> applies specific schema to children.  This has drawback - all regular
>> properties are also matched and are silently ignored, even if they are
>> not described in schema.  Basically this allows any non-object property
>> to be present.
>>
>> Enforce specific naming pattern for children (keys) to narrow the
>> pattern thus do not match other properties.  This will require all
>> children to be properly prefixed or suffixed (button, event, switch or
>> key).
>>
>> Removal of "if:" within patternProperties causes drop of one indentation
>> level, but there are no other changes in the affected block.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>>  .../devicetree/bindings/input/gpio-keys.yaml  | 157 +++++++++---------
>>  1 file changed, 77 insertions(+), 80 deletions(-)
>>
> 
> Dmitry,
> 
> Any comments from your side? Are you planning to pick up the dt-bindings
> here (patch 1-3)?

Hmmm, I guess this should go via dt-bindings then...

Best regards,
Krzysztof