Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e5d2d2b9-b346-0481-03be-4a94c87a816f@linaro.org>
Date:   Tue, 5 Jul 2022 14:13:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] dt-bindings: leds: lp50xx: fix LED children names
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Dan Murphy <dmurphy@ti.com>, linux-leds@vger.kernel.org,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, Pavel Machek <pavel@ucw.cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
References: <20220624111325.96478-1-krzysztof.kozlowski@linaro.org>
 <1656091594.405509.146345.nullmailer@robh.at.kernel.org>
 <31f5f441-eba3-4ffb-cf68-159cd827ade7@linaro.org>
In-Reply-To: <31f5f441-eba3-4ffb-cf68-159cd827ade7@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24/06/2022 19:31, Krzysztof Kozlowski wrote:
> On 24/06/2022 19:26, Rob Herring wrote:
>> On Fri, 24 Jun 2022 13:13:25 +0200, Krzysztof Kozlowski wrote:
>>> The lp50xx LEDs expects to have single-color LED children with unit
>>> addresses.  This is required by the driver and provided by existing
>>> DTSes.  Fix the binding to match actual usage.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers")
>>> ---
>>>  Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++-
>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.example.dtb: led-controller@14: multi-led@2:#size-cells:0:0: 0 was expected
>> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>>
> 
> This is expected and fixed in:
> https://lore.kernel.org/all/20220607075247.58048-1-krzysztof.kozlowski@linaro.org/
> 
> I did not combine this patch with above patchset because this one is a
> fix and might be backported to stable.
> 

Anyone willing to pick this up? This is a fix.

Best regards,
Krzysztof