Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] MAINTAINERS: adjust XDP SOCKETS after file movement
To:     Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Magnus Karlsson <magnus.karlsson@gmail.com>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Network Development <netdev@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
References: <20220701042810.26362-1-lukas.bulwahn@gmail.com>
 <Yr7mcjRq57laZGEY@boxer>
 <CAJ8uoz16yGJqYX2xOcczTGKFnG4joh8+f1uPGMAP4rmm3feYDQ@mail.gmail.com>
 <Yr78Md1Nqpj+peO0@boxer>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <c9c2d7b3-7d29-252d-6070-77d562ee4c3b@iogearbox.net>
Date:   Tue, 5 Jul 2022 14:01:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <Yr78Md1Nqpj+peO0@boxer>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/1/22 3:52 PM, Maciej Fijalkowski wrote:
> On Fri, Jul 01, 2022 at 03:13:36PM +0200, Magnus Karlsson wrote:
>> On Fri, Jul 1, 2022 at 2:38 PM Maciej Fijalkowski
>> <maciej.fijalkowski@intel.com> wrote:
>>>
>>> On Fri, Jul 01, 2022 at 06:28:10AM +0200, Lukas Bulwahn wrote:
>>>> Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves
>>>> files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust
>>>> the XDP SOCKETS (AF_XDP) section in MAINTAINERS.
>>>>
>>>> Adjust the file entry after this file movement.
>>>>
>>>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>>>> ---
>>>> Andrii, please ack.
>>>>
>>>> Alexei, please pick this minor non-urgent clean-up on top of the commit above.
>>>>
>>>>   MAINTAINERS | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index fa4bfa3d10bf..27d9e65b9a85 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -22042,7 +22042,7 @@ F:    include/uapi/linux/xdp_diag.h
>>>>   F:   include/net/netns/xdp.h
>>>>   F:   net/xdp/
>>>>   F:   samples/bpf/xdpsock*
>>>> -F:   tools/lib/bpf/xsk*
>>>> +F:   tools/testing/selftests/bpf/xsk*
>>>
>>> Magnus, this doesn't cover xdpxceiver.
>>> How about we move the lib part and xdpxceiver part to a dedicated
>>> directory? Or would it be too nested from main dir POV?
>>
>> Or we can just call everything we add xsk* something?
> 
> No strong feelings. test_xsk.sh probably also needs to be addressed.
> That's why I proposed dedicated dir.

Could one of you follow-up on this for bpf-next tree? Maybe for selftests something
similar as in case of the XDP entry could work.

Thanks,
Daniel