Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1254218imw; Tue, 5 Jul 2022 06:30:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uSRu6oWXeGkH5w9OSYh13BnldT25dNjVrEL5yKRFf6uTq0lDAg+hV72k+rvceLcNAzJrUS X-Received: by 2002:a17:902:a586:b0:16b:e787:53f8 with SMTP id az6-20020a170902a58600b0016be78753f8mr8518798plb.163.1657027802065; Tue, 05 Jul 2022 06:30:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657027802; cv=none; d=google.com; s=arc-20160816; b=bHDF0AYt+icN2YEm0f7WVsgy6+3+xdDop2ZH74ErB7+D6rtJirTtE1YaW0CDKvZ0ZT bpGaJpI3QrVw+hmMDa/ekaBrZQURJQvc6qajMwgjzP+o+PJ3tM0cK0T2VHRA1DZXxmTs yMNQfZ386M4LpQ/cdu4X1CbrT1BG1gvgrn1YFdSpdPehTSDsB5EJTyB2abtxq4jlZJJI +AxfUmlr4xMquiIxCr+Nt9Ac5ntXiKIxS9yAhb1CoDPzvPEZfUtBa+OTpk4ic+3WXZiN SCyUr3bE5tgYTV9uNjjSB8cpLX0d9qVQ2GoeO5DEWk54hPFOFHY22/rBqLxNPjAoJ2D8 J1XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=YRsVqKY1FP8GB58R3OD493uBwRt0/4HsIz06TH1IPTg=; b=XKlaepOqDbNJvNV4fm99Nmd/tXstdypjjBayZUlddx/Rb0dq4BabaA+jElvIPsLyai 7R1zEvQG4BgcPnlgzvLoIbfLqrnVw0wG0akf9VhIJ8wt44cWQN0L/efVLJEtm2nSRGz6 xpdwMo7rskDn6t2HXSExKS3/fC5zu/PWTIcZOUGoQz8iPmg+4O5nfeHebqPRPNl/U8Kg l/e+BtFNMYedmWrbwuhZQ+FkU+qbJAJoVvDkSf/2blfitP+svvHuUipZOgGywjSi3L1K GBgChYcy5+fY3fKAgrnxOpRil+JQuAZtAZw6cAFASs0v+RwvIBB4XoEwAnhuAJIu8ndl IHJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=yDR7LzRk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x71-20020a63864a000000b004127d2cb54asi1396252pgd.56.2022.07.05.06.29.49; Tue, 05 Jul 2022 06:30:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=yDR7LzRk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236069AbiGEMQX (ORCPT + 99 others); Tue, 5 Jul 2022 08:16:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235289AbiGEMIv (ORCPT ); Tue, 5 Jul 2022 08:08:51 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CA9E10B8; Tue, 5 Jul 2022 05:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657022930; x=1688558930; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=YRsVqKY1FP8GB58R3OD493uBwRt0/4HsIz06TH1IPTg=; b=yDR7LzRkvFDpNmBlhdPqLj+249WDf+BKk8msN1AZpWK5hDXBfFkuckcT tfPXt64DAafMTCc8D+gi1KKAzTRnWwXkN0WXvazs5HH/aReGqFM5aIiA0 lSQ83wgOyO6wqVzheuCWJbhv7YllwqdSuEh2Vfw4JJS7HEaMfeh5Qyeyc A=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-01.qualcomm.com with ESMTP; 05 Jul 2022 05:08:50 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2022 05:08:49 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 5 Jul 2022 05:08:49 -0700 Received: from blr-ubuntu-87.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 5 Jul 2022 05:08:45 -0700 From: Sibi Sankar To: CC: , , , , , , , Siddharth Gupta , Sibi Sankar Subject: [V3 3/7] remoteproc: qcom: pas: Mark devices as wakeup capable Date: Tue, 5 Jul 2022 17:38:16 +0530 Message-ID: <1657022900-2049-4-git-send-email-quic_sibis@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1657022900-2049-1-git-send-email-quic_sibis@quicinc.com> References: <1657022900-2049-1-git-send-email-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Siddharth Gupta device_wakeup_enable() on its own is not capable of setting device as wakeup capable, it needs to be used in conjunction with device_set_wakeup_capable(). The device_init_wakeup() calls both these functions on the device passed. Fixes: a781e5aa5911 ("remoteproc: core: Prevent system suspend during remoteproc recovery") Signed-off-by: Siddharth Gupta Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_q6v5_pas.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index df13cfc3aeb8..43dde151120f 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -486,7 +486,9 @@ static int adsp_probe(struct platform_device *pdev) adsp->decrypt_shutdown = desc->decrypt_shutdown; platform_set_drvdata(pdev, adsp); - device_wakeup_enable(adsp->dev); + ret = device_init_wakeup(adsp->dev, true); + if (ret) + goto free_rproc; ret = adsp_alloc_memory_region(adsp); if (ret) -- 2.7.4