Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa905bab-e8bf-feaf-aa20-d4ce967a3d36@intel.com>
Date:   Tue, 5 Jul 2022 14:42:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.10.0
Subject: Re: [PATCH v2 1/1] ASoC: Intel: catpt: remove duplicating driver data
 retrieval
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>
CC:     <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        "Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
References: <20220703145152.62297-1-andriy.shevchenko@linux.intel.com>
 <9c67d656-9990-7206-58b4-3de25d8341a0@linux.intel.com>
 <YsMTXVYv/ks+nyqu@smile.fi.intel.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <YsMTXVYv/ks+nyqu@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWxWWE1LK2ZjMHBEeFg1Rm1oekhhQU5hQUtMSE1pNEpSaDJTdXowOEtpM2lI?=
 =?utf-8?B?TTJUdWRtSGR3NGF6K0NraCt4eThvTmFnRWt6ZlZiY1Ayck92QzkzaTRJNVVU?=
 =?utf-8?B?MDdiTE1YcCtuUC9SOXNBVjUyYlR1OHpPL1ZPelU4VWZ4NzVJd0oxUkxUaFlS?=
 =?utf-8?B?R2crcFVhT1JlaU1sK0ZYNTI3MzgxRGdwOFE2bVNjVjFFNlpYaTg5b3VxcWFE?=
 =?utf-8?B?OUt1VEJpUEVQR1U4MGJHNGlTSGtoQTh1L1dZK1hCRVoxTUQ2eXFmYVRMWk5o?=
 =?utf-8?B?dWNQbEFWRFpqYk1FV3JyNUJqU3VINDYxUjV1WjFXblJpNFJlTDRNZkhjY25R?=
 =?utf-8?B?bjEzckh5K21QTzU1M2hPVHZQTWdGQ2p0a2N0ZUtuWmEwRW1GOVVhZzdHMTVt?=
 =?utf-8?B?Lys4TEhKRUlDb2JKNGdzSWp3UnZIVjB0S1lESC9rMGRNczQ4MGxwMTNZdU5F?=
 =?utf-8?B?djJXK0w5bElEYzhiRDFHZGZEclVRbG5TeHc5TUoxVlBuS2VHRFd1MXhDZFNJ?=
 =?utf-8?B?d3lKaHhkeEorVkF1bHBEU2hQS2J1Ujk3SVV3S2hRMHNvR3F0bnlLdzJQeXo0?=
 =?utf-8?B?VWFaUEJ1anprTENubEsyTUg0bFF4ZDM3TGZvc20zR2kxUnVPb25LZUY4Tkli?=
 =?utf-8?B?QWFYZ3RGSTJMUGZtNVp0L0pKMnRrbklRQWVuZDFIZ2M3Qm1DenNXeWFwRGJa?=
 =?utf-8?B?QU81ekx6QUtzRmxmaWNieHZRajEzN1dXQ0daWUZIM0ZxMVQrZXk2YWhoZjEw?=
 =?utf-8?B?emdvOXFTOHdxb29WeG03YnovUm9EZVhRVTcxbmcyZXpuMVdlQ3pSY2dSTHJu?=
 =?utf-8?B?Z0F3U21ML0kxRDZxT3ZkSnl6WWVzT2NYRjYzSUgyZ1dqMDc1TThvbnZLbk1z?=
 =?utf-8?B?bjNsc0h6ODhFZkR1U3FkVHlEdU1lcW40NUJrQm41UFlFYVZ6ZnltSnZ1d0VQ?=
 =?utf-8?B?REhEcFo1WFNINlE1SFdVZWg0N0NZUnptWnVFcVpadEZyQVp0cFdoVjgxbkkw?=
 =?utf-8?B?SE9IcDNLeFZ6Nkk4QWNxVkUvK2UrdERqUVp6Ymx5TUtmZWhlYW1IMjRIZ3VL?=
 =?utf-8?B?bDRObnNtV0ttQWhpWDhvSU90T0lJY1kvUzIwaEtjaVAxYmVJb1FabWRKOXA2?=
 =?utf-8?B?bFNYdUxtcG1hMis0Wml5clFoUVhITTBFK2RIL21UZ0lZZjNTYnJSR2tNWWcw?=
 =?utf-8?B?L3NXSHR1QWdEaGlRYUZTVVlEdUprTGI2c1h2eE5nNmlHMWlkTVQ0OURPUVJx?=
 =?utf-8?B?cWsvWW43YzBJS0hsSG9yamtySmVGZXYwdkJ0dngwYW5JWU1FazlJTDlGVzl2?=
 =?utf-8?B?MjFPR0ZzcXVnMnhJMEtFb21OVXh0UnpqZlJwNis0RHBMaGo2Z0ErZkR6Rzhw?=
 =?utf-8?B?ZFJPQlFWZkQ0SUlqcElWUU05ZXg1QStyQlBKdVd4Qm11Y1M2NWRUeDg2NWVw?=
 =?utf-8?B?WHJKb1AvYlhXRXVNVmtZMUlQS1RkamhwMThrQ0c5RWMxM1dKMnh4d1U0Y3BU?=
 =?utf-8?B?MHNwOUJlWkxCTHpYRFlBQmhlRU8wTmFNaGFadGhDQkg0MUdaSzV3SDZPZWJ4?=
 =?utf-8?B?OHpkNE9HOG1yTVlCcy91N3dUZHI3MWJxV2dZYVJ5Z2ZxVUwzUXFFOWhmMTZp?=
 =?utf-8?B?bVE3bWMrbjg2eFlLMVJYTVMyTHp4WkpBRDk0QW1kdXJzeTdlMVhBenZWVmZ2?=
 =?utf-8?B?OEVneld3V3Fjem9NdndiaWtXbHh5a05yVzZYYXpoSE12Wk0yN3Y3WUozZEJ4?=
 =?utf-8?B?UTMwZ2hRbUFRZUVlQm1mcEZhcGhiUUxrQTl5dVlVNXd2aWZib0ZLaDg4MVBv?=
 =?utf-8?B?bUw1M1dmQXpUekRKUnowcE9ZTnE3WVdLNHVqcEdCaTdHQURmdlk0Sy80Nmgw?=
 =?utf-8?B?SVlQb0puRDdWdjhYUFlGdkV2Wk5HRFNCa3lmSjRrZjZuNm5ybllGZHpYbHJD?=
 =?utf-8?B?V2Y1ZkJXMC9yVjJUNm9ldXliWTEvODhmblQybGY5dUFTYWNRQzUra0FJK0pG?=
 =?utf-8?B?NjhiYnRXOVhoMEVHQ29HdDMrb3lUNjJObDZ2d0MvM3hHTlZtREVtRmZENGlz?=
 =?utf-8?B?a3k3cDJQbDg0OXY0ZVR5SE5hMGhqMTlnWlRwOFFTRVBDVEs4dUs1Vk8xNWxX?=
 =?utf-8?B?NWlJNXAyM2t6RDBxcmI5WG85RjB5RDZkV0tKdFJKaTdWdmtiaEp6Lzl4MXZF?=
 =?utf-8?B?V2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fbd1101b-a27f-4360-0e42-08da5e83d7f5
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:42:38.5109
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sc5hSBDkdpkLrMgRbCYqB19Aiwa6YXrD+prkMIpxoSBUGHtMt01obp0SFxd2VrF1xvTrCgUP0tHipVeB7zdmB239sn/PZevBUnFwwzUpzEM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2696
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-07-04 6:20 PM, Andy Shevchenko wrote:
> On Mon, Jul 04, 2022 at 10:36:33AM +0300, Péter Ujfalusi wrote:
>> On 03/07/2022 17:51, Andy Shevchenko wrote:

...

>> We could just pass the "(const struct catpt_spec *)id->driver_data" in
>> place of spec to catpt_dev_init() and we can get rid of the local
>> temporary pointer?
> 
> I would not go this way for non-POD types.


Agree with Andy here.

>> If not, then I would cast out the spec before it's use:
>> spec = (const struct catpt_spec *)id->driver_data;
>> catpt_dev_init(cdev, dev, spec);
> 
> This I can do (as well as in the other patch).


Agree with Peter's suggestion here too.


Thank you both for taking time in improving driver's quality!

Regards,
Czarek